From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C9006A04B1
	for <public@inbox.dpdk.org>; Wed,  9 Sep 2020 01:27:49 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C3D281BEB1;
	Wed,  9 Sep 2020 01:27:49 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id DF4101BEAC; Wed,  9 Sep 2020 01:27:48 +0200 (CEST)
In-Reply-To: <20200901115113.1529675-20-jiawenwu@trustnetic.com>
References: <20200901115113.1529675-20-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20200908232748.DF4101BEAC@dpdk.org>
Date: Wed,  9 Sep 2020 01:27:48 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw76223 [PATCH v1 20/42] net/txgbe:
	add RX and TX stop
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76223

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#58: 
Add receive and transmit units stop for specified queue, release mbufs and free queues.

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#222: FILE: drivers/net/txgbe/txgbe_rxtx.c:178:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#272: FILE: drivers/net/txgbe/txgbe_rxtx.c:228:
+	unsigned i;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#289: FILE: drivers/net/txgbe/txgbe_rxtx.c:245:
+	for (i = 0; i < len; i++) {
+		rxq->rx_ring[i] = zeroed_desc;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#298: FILE: drivers/net/txgbe/txgbe_rxtx.c:254:
+	for (i = rxq->nb_rx_desc; i < len; ++i) {
+		rxq->sw_ring[i].mbuf = &rxq->fake_mbuf;
+	}

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#310: FILE: drivers/net/txgbe/txgbe_rxtx.c:266:
+
+}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#315: FILE: drivers/net/txgbe/txgbe_rxtx.c:271:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#343: FILE: drivers/net/txgbe/txgbe_rxtx.c:298:
+	unsigned i;

CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#552: FILE: drivers/net/txgbe/txgbe_rxtx.h:98:
+	struct rte_mbuf *rx_stage[RTE_PMD_TXGBE_RX_MAX_BURST*2];
 	                                                    ^

total: 0 errors, 7 warnings, 2 checks, 468 lines checked