From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw76224 [PATCH v1 21/42] net/txgbe: add RX and TX queues setup
Date: Wed, 9 Sep 2020 01:27:53 +0200 (CEST) [thread overview]
Message-ID: <20200908232753.1D22A1BEAC@dpdk.org> (raw)
In-Reply-To: <20200901115113.1529675-21-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76224
_coding style issues_
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#133: FILE: drivers/net/txgbe/txgbe_rxtx.c:116:
+ unsigned i;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc > TXGBE_RING_DESC_MAX'
#195: FILE: drivers/net/txgbe/txgbe_rxtx.c:207:
+ if (nb_desc % TXGBE_TXD_ALIGN != 0 ||
+ (nb_desc > TXGBE_RING_DESC_MAX) ||
+ (nb_desc < TXGBE_RING_DESC_MIN)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc < TXGBE_RING_DESC_MIN'
#195: FILE: drivers/net/txgbe/txgbe_rxtx.c:207:
+ if (nb_desc % TXGBE_TXD_ALIGN != 0 ||
+ (nb_desc > TXGBE_RING_DESC_MAX) ||
+ (nb_desc < TXGBE_RING_DESC_MIN)) {
CHECK:SPACING: No space is necessary after a cast
#279: FILE: drivers/net/txgbe/txgbe_rxtx.c:291:
+ txq->tx_ring = (struct txgbe_tx_desc *) TMZ_VADDR(tz);
CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#289: FILE: drivers/net/txgbe/txgbe_rxtx.c:301:
+ PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%"PRIx64,
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#289: FILE: drivers/net/txgbe/txgbe_rxtx.c:301:
+ PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%"PRIx64,
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc > TXGBE_RING_DESC_MAX'
#385: FILE: drivers/net/txgbe/txgbe_rxtx.c:501:
+ if (nb_desc % TXGBE_RXD_ALIGN != 0 ||
+ (nb_desc > TXGBE_RING_DESC_MAX) ||
+ (nb_desc < TXGBE_RING_DESC_MIN)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc < TXGBE_RING_DESC_MIN'
#385: FILE: drivers/net/txgbe/txgbe_rxtx.c:501:
+ if (nb_desc % TXGBE_RXD_ALIGN != 0 ||
+ (nb_desc > TXGBE_RING_DESC_MAX) ||
+ (nb_desc < TXGBE_RING_DESC_MIN)) {
CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#506: FILE: drivers/net/txgbe/txgbe_rxtx.c:622:
+ "dma_addr=0x%"PRIx64,
total: 0 errors, 1 warnings, 8 checks, 518 lines checked
parent reply other threads:[~2020-09-08 23:27 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200901115113.1529675-21-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908232753.1D22A1BEAC@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).