From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E6A6CA04B1
	for <public@inbox.dpdk.org>; Wed,  9 Sep 2020 01:27:53 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id E0F901BEB1;
	Wed,  9 Sep 2020 01:27:53 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 1D22A1BEAC; Wed,  9 Sep 2020 01:27:53 +0200 (CEST)
In-Reply-To: <20200901115113.1529675-21-jiawenwu@trustnetic.com>
References: <20200901115113.1529675-21-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20200908232753.1D22A1BEAC@dpdk.org>
Date: Wed,  9 Sep 2020 01:27:53 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw76224 [PATCH v1 21/42] net/txgbe:
	add RX and TX queues setup
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76224

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#133: FILE: drivers/net/txgbe/txgbe_rxtx.c:116:
+	unsigned i;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc > TXGBE_RING_DESC_MAX'
#195: FILE: drivers/net/txgbe/txgbe_rxtx.c:207:
+	if (nb_desc % TXGBE_TXD_ALIGN != 0 ||
+	    (nb_desc > TXGBE_RING_DESC_MAX) ||
+	    (nb_desc < TXGBE_RING_DESC_MIN)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc < TXGBE_RING_DESC_MIN'
#195: FILE: drivers/net/txgbe/txgbe_rxtx.c:207:
+	if (nb_desc % TXGBE_TXD_ALIGN != 0 ||
+	    (nb_desc > TXGBE_RING_DESC_MAX) ||
+	    (nb_desc < TXGBE_RING_DESC_MIN)) {

CHECK:SPACING: No space is necessary after a cast
#279: FILE: drivers/net/txgbe/txgbe_rxtx.c:291:
+	txq->tx_ring = (struct txgbe_tx_desc *) TMZ_VADDR(tz);

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#289: FILE: drivers/net/txgbe/txgbe_rxtx.c:301:
+	PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%"PRIx64,

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#289: FILE: drivers/net/txgbe/txgbe_rxtx.c:301:
+	PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%"PRIx64,

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc > TXGBE_RING_DESC_MAX'
#385: FILE: drivers/net/txgbe/txgbe_rxtx.c:501:
+	if (nb_desc % TXGBE_RXD_ALIGN != 0 ||
+			(nb_desc > TXGBE_RING_DESC_MAX) ||
+			(nb_desc < TXGBE_RING_DESC_MIN)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc < TXGBE_RING_DESC_MIN'
#385: FILE: drivers/net/txgbe/txgbe_rxtx.c:501:
+	if (nb_desc % TXGBE_RXD_ALIGN != 0 ||
+			(nb_desc > TXGBE_RING_DESC_MAX) ||
+			(nb_desc < TXGBE_RING_DESC_MIN)) {

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#506: FILE: drivers/net/txgbe/txgbe_rxtx.c:622:
+			    "dma_addr=0x%"PRIx64,

total: 0 errors, 1 warnings, 8 checks, 518 lines checked