From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw76237 [PATCH v1 34/42] net/txgbe: add remaining RX and TX queue operations
Date: Wed, 9 Sep 2020 01:28:48 +0200 (CEST) [thread overview]
Message-ID: <20200908232848.BC9841BEAC@dpdk.org> (raw)
In-Reply-To: <20200901115113.1529675-34-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76237
_coding style issues_
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#378: FILE: drivers/net/txgbe/txgbe_rxtx.c:1987:
+ txq->tx_free_thresh >= RTE_PMD_TXGBE_TX_MAX_BURST) {
+
WARNING:BRACES: braces {} are not necessary for single statement blocks
#401: FILE: drivers/net/txgbe/txgbe_rxtx.c:2027:
+ for (i = 0; i < txq->nb_tx_desc; i++) {
+ txq->tx_ring[i] = zeroed_desc;
+ }
CHECK:SPACING: No space is necessary after a cast
#406: FILE: drivers/net/txgbe/txgbe_rxtx.c:2032:
+ prev = (uint16_t) (txq->nb_tx_desc - 1);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around rxq->rx_ring[rxq->rx_tail]
#451: FILE: drivers/net/txgbe/txgbe_rxtx.c:2634:
+ rxdp = &(rxq->rx_ring[rxq->rx_tail]);
total: 0 errors, 1 warnings, 3 checks, 490 lines checked
parent reply other threads:[~2020-09-08 23:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200901115113.1529675-34-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908232848.BC9841BEAC@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).