* [dpdk-test-report] |WARNING| pw76238 [PATCH v1 35/42] net/txgbe: add VLAN handle support
[not found] <20200901115113.1529675-35-jiawenwu@trustnetic.com>
@ 2020-09-08 23:28 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-09-08 23:28 UTC (permalink / raw)
To: test-report; +Cc: Jiawen Wu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/76238
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#83: FILE: drivers/net/txgbe/txgbe_ethdev.c:58:
+#define TXGBE_SET_HWSTRIP(h, q) do {\
+ uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+ uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+ (h)->bitmap[idx] |= 1 << bit;\
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#89: FILE: drivers/net/txgbe/txgbe_ethdev.c:64:
+#define TXGBE_CLEAR_HWSTRIP(h, q) do {\
+ uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+ uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+ (h)->bitmap[idx] &= ~(1 << bit);\
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#95: FILE: drivers/net/txgbe/txgbe_ethdev.c:70:
+#define TXGBE_GET_HWSTRIP(h, q, r) do {\
+ uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+ uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+ (r) = (h)->bitmap[idx] >> bit & 1;\
+ } while (0)
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#393: FILE: drivers/net/txgbe/txgbe_ethdev.c:914:
+ if (rxq->offloads & DEV_RX_OFFLOAD_VLAN_STRIP) {
[...]
+ } else {
[...]
WARNING:BRACES: braces {} are not necessary for single statement blocks
#429: FILE: drivers/net/txgbe/txgbe_ethdev.c:950:
+ if (mask & ETH_VLAN_STRIP_MASK) {
+ txgbe_vlan_hw_strip_config(dev);
+ }
total: 0 errors, 2 warnings, 3 checks, 480 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-09-08 23:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200901115113.1529675-35-jiawenwu@trustnetic.com>
2020-09-08 23:28 ` [dpdk-test-report] |WARNING| pw76238 [PATCH v1 35/42] net/txgbe: add VLAN handle support checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).