From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C304AA04B1 for ; Wed, 9 Sep 2020 01:32:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAF9F1BE85; Wed, 9 Sep 2020 01:32:05 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id CB6AF1BE85; Wed, 9 Sep 2020 01:32:03 +0200 (CEST) In-Reply-To: <20200901185654.76346-1-dliu@iol.unh.edu> References: <20200901185654.76346-1-dliu@iol.unh.edu> To: test-report@dpdk.org Cc: David Liu Message-Id: <20200908233203.CB6AF1BE85@dpdk.org> Date: Wed, 9 Sep 2020 01:32:03 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw76274 [PATCH V1] testpmd: add eeprom/module eeprom display X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/76274 _coding style issues_ WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #95: FILE: app/test-pmd/cmdline.c:169: + "show port (port_id) eeprom " WARNING:TYPO_SPELLING: 'infomation' may be misspelled - perhaps 'information'? #96: FILE: app/test-pmd/cmdline.c:170: + " Display the EEPROM infomation for port x. " WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #98: FILE: app/test-pmd/cmdline.c:172: + "show port (port_id) module_eeprom " WARNING:TYPO_SPELLING: 'moudle' may be misspelled - perhaps 'module'? #99: FILE: app/test-pmd/cmdline.c:173: + " Display the port moudle EEPROM infomation for port x. " WARNING:TYPO_SPELLING: 'infomation' may be misspelled - perhaps 'information'? #99: FILE: app/test-pmd/cmdline.c:173: + " Display the port moudle EEPROM infomation for port x. " WARNING:LEADING_SPACE: please, no spaces at the start of a line #111: FILE: app/test-pmd/cmdline.c:7606: + cmdline_fixed_string_t show;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #112: FILE: app/test-pmd/cmdline.c:7607: + cmdline_fixed_string_t port;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #113: FILE: app/test-pmd/cmdline.c:7608: + cmdline_fixed_string_t type;$ ERROR:CODE_INDENT: code indent should use tabs where possible #114: FILE: app/test-pmd/cmdline.c:7609: + uint16_t portnum;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #114: FILE: app/test-pmd/cmdline.c:7609: + uint16_t portnum;$ ERROR:CODE_INDENT: code indent should use tabs where possible #118: FILE: app/test-pmd/cmdline.c:7613: + __rte_unused struct cmdline *cl,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #118: FILE: app/test-pmd/cmdline.c:7613: + __rte_unused struct cmdline *cl,$ ERROR:CODE_INDENT: code indent should use tabs where possible #119: FILE: app/test-pmd/cmdline.c:7614: + __rte_unused void *data)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #119: FILE: app/test-pmd/cmdline.c:7614: + __rte_unused void *data)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #121: FILE: app/test-pmd/cmdline.c:7616: + struct cmd_showeeprom_result *res = parsed_result;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #123: FILE: app/test-pmd/cmdline.c:7618: + port_eeprom_display(res->portnum);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #127: FILE: app/test-pmd/cmdline.c:7622: + TOKEN_STRING_INITIALIZER(struct cmd_showeeprom_result, show, "show");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #129: FILE: app/test-pmd/cmdline.c:7624: + TOKEN_STRING_INITIALIZER(struct cmd_showeeprom_result, port, "port");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #131: FILE: app/test-pmd/cmdline.c:7626: + TOKEN_NUM_INITIALIZER(struct cmd_showeeprom_result, portnum, UINT16);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #133: FILE: app/test-pmd/cmdline.c:7628: + TOKEN_STRING_INITIALIZER(struct cmd_showeeprom_result, type, "eeprom");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #136: FILE: app/test-pmd/cmdline.c:7631: + .f = cmd_showeeprom_parsed,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #137: FILE: app/test-pmd/cmdline.c:7632: + .data = NULL,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #138: FILE: app/test-pmd/cmdline.c:7633: + .help_str = "show port eeprom",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #139: FILE: app/test-pmd/cmdline.c:7634: + .tokens = {$ ERROR:CODE_INDENT: code indent should use tabs where possible #140: FILE: app/test-pmd/cmdline.c:7635: + (void *)&cmd_showeeprom_show,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #140: FILE: app/test-pmd/cmdline.c:7635: + (void *)&cmd_showeeprom_show,$ ERROR:CODE_INDENT: code indent should use tabs where possible #141: FILE: app/test-pmd/cmdline.c:7636: + (void *)&cmd_showeeprom_port,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #141: FILE: app/test-pmd/cmdline.c:7636: + (void *)&cmd_showeeprom_port,$ ERROR:CODE_INDENT: code indent should use tabs where possible #142: FILE: app/test-pmd/cmdline.c:7637: + (void *)&cmd_showeeprom_portnum,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #142: FILE: app/test-pmd/cmdline.c:7637: + (void *)&cmd_showeeprom_portnum,$ ERROR:CODE_INDENT: code indent should use tabs where possible #143: FILE: app/test-pmd/cmdline.c:7638: + (void *)&cmd_showeeprom_type,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #143: FILE: app/test-pmd/cmdline.c:7638: + (void *)&cmd_showeeprom_type,$ ERROR:CODE_INDENT: code indent should use tabs where possible #144: FILE: app/test-pmd/cmdline.c:7639: + NULL,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #144: FILE: app/test-pmd/cmdline.c:7639: + NULL,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #145: FILE: app/test-pmd/cmdline.c:7640: + },$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #150: FILE: app/test-pmd/cmdline.c:7645: + cmdline_fixed_string_t show;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #151: FILE: app/test-pmd/cmdline.c:7646: + cmdline_fixed_string_t port;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #152: FILE: app/test-pmd/cmdline.c:7647: + cmdline_fixed_string_t type;$ ERROR:CODE_INDENT: code indent should use tabs where possible #153: FILE: app/test-pmd/cmdline.c:7648: + uint16_t portnum;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #153: FILE: app/test-pmd/cmdline.c:7648: + uint16_t portnum;$ ERROR:CODE_INDENT: code indent should use tabs where possible #157: FILE: app/test-pmd/cmdline.c:7652: + __rte_unused struct cmdline *cl,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #157: FILE: app/test-pmd/cmdline.c:7652: + __rte_unused struct cmdline *cl,$ ERROR:CODE_INDENT: code indent should use tabs where possible #158: FILE: app/test-pmd/cmdline.c:7653: + __rte_unused void *data)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #158: FILE: app/test-pmd/cmdline.c:7653: + __rte_unused void *data)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #160: FILE: app/test-pmd/cmdline.c:7655: + struct cmd_showmoduleeeprom_result *res = parsed_result;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #162: FILE: app/test-pmd/cmdline.c:7657: + port_module_eeprom_display(res->portnum);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #166: FILE: app/test-pmd/cmdline.c:7661: + TOKEN_STRING_INITIALIZER(struct cmd_showmoduleeeprom_result, show, "show");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #168: FILE: app/test-pmd/cmdline.c:7663: + TOKEN_STRING_INITIALIZER(struct cmd_showmoduleeeprom_result, port, "port");$ ERROR:CODE_INDENT: code indent should use tabs where possible #194: FILE: app/test-pmd/cmdline.c:19413: + (cmdline_parse_inst_t *)&cmd_showeeprom,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #194: FILE: app/test-pmd/cmdline.c:19413: + (cmdline_parse_inst_t *)&cmd_showeeprom,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #218: FILE: app/test-pmd/config.c:717: + struct rte_dev_eeprom_info einfo;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #219: FILE: app/test-pmd/config.c:718: + int ret;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #221: FILE: app/test-pmd/config.c:720: + if (port_id_is_invalid(port_id, ENABLED_WARN)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #221: FILE: app/test-pmd/config.c:720: + if (port_id_is_invalid(port_id, ENABLED_WARN)) { + print_valid_ports(); ERROR:CODE_INDENT: code indent should use tabs where possible #222: FILE: app/test-pmd/config.c:721: + print_valid_ports();$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #222: FILE: app/test-pmd/config.c:721: + print_valid_ports();$ ERROR:CODE_INDENT: code indent should use tabs where possible #223: FILE: app/test-pmd/config.c:722: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #223: FILE: app/test-pmd/config.c:722: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #224: FILE: app/test-pmd/config.c:723: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #226: FILE: app/test-pmd/config.c:725: + int len_eeprom = rte_eth_dev_get_eeprom_length(port_id);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #228: FILE: app/test-pmd/config.c:727: + if(len_eeprom < 0) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #228: FILE: app/test-pmd/config.c:727: + if(len_eeprom < 0) { + switch (len_eeprom) { ERROR:SPACING: space required before the open parenthesis '(' #228: FILE: app/test-pmd/config.c:727: + if(len_eeprom < 0) { ERROR:CODE_INDENT: code indent should use tabs where possible #229: FILE: app/test-pmd/config.c:728: + switch (len_eeprom) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #229: FILE: app/test-pmd/config.c:728: + switch (len_eeprom) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #230: FILE: app/test-pmd/config.c:729: + case -ENODEV:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #230: FILE: app/test-pmd/config.c:729: + case -ENODEV:$ WARNING:TABSTOP: Statements should start on a tabstop #232: FILE: app/test-pmd/config.c:731: + break; WARNING:TABSTOP: Statements should start on a tabstop #233: FILE: app/test-pmd/config.c:732: + case -ENOTSUP: ERROR:CODE_INDENT: code indent should use tabs where possible #234: FILE: app/test-pmd/config.c:733: + printf("operation not supported by device ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #234: FILE: app/test-pmd/config.c:733: + printf("operation not supported by device ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #235: FILE: app/test-pmd/config.c:734: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #235: FILE: app/test-pmd/config.c:734: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #236: FILE: app/test-pmd/config.c:735: + case -EIO:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #236: FILE: app/test-pmd/config.c:735: + case -EIO:$ WARNING:TABSTOP: Statements should start on a tabstop #238: FILE: app/test-pmd/config.c:737: + break; ERROR:CODE_INDENT: code indent should use tabs where possible #239: FILE: app/test-pmd/config.c:738: + default:$ ERROR:CODE_INDENT: code indent should use tabs where possible #240: FILE: app/test-pmd/config.c:739: + printf("Unable to get module EEPROM: %d ", ret);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #240: FILE: app/test-pmd/config.c:739: + printf("Unable to get module EEPROM: %d ", ret);$ ERROR:CODE_INDENT: code indent should use tabs where possible #241: FILE: app/test-pmd/config.c:740: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #241: FILE: app/test-pmd/config.c:740: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #242: FILE: app/test-pmd/config.c:741: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #242: FILE: app/test-pmd/config.c:741: + }$ WARNING:TABSTOP: Statements should start on a tabstop #243: FILE: app/test-pmd/config.c:742: + return; WARNING:LEADING_SPACE: please, no spaces at the start of a line #244: FILE: app/test-pmd/config.c:743: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #246: FILE: app/test-pmd/config.c:745: + char buf[len_eeprom];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #247: FILE: app/test-pmd/config.c:746: + printf(" Port: %d Module EEPROM: ", port_id);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #249: FILE: app/test-pmd/config.c:748: + einfo.offset = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #250: FILE: app/test-pmd/config.c:749: + einfo.length = len_eeprom;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #251: FILE: app/test-pmd/config.c:750: + einfo.data = buf;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #253: FILE: app/test-pmd/config.c:752: + ret = rte_eth_dev_get_eeprom(port_id, &einfo);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #254: FILE: app/test-pmd/config.c:753: + if (ret != 0) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #254: FILE: app/test-pmd/config.c:753: + if (ret != 0) { + switch (ret) { ERROR:CODE_INDENT: code indent should use tabs where possible #255: FILE: app/test-pmd/config.c:754: + switch (ret) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #255: FILE: app/test-pmd/config.c:754: + switch (ret) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #256: FILE: app/test-pmd/config.c:755: + case -ENODEV:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #256: FILE: app/test-pmd/config.c:755: + case -ENODEV:$ WARNING:TABSTOP: Statements should start on a tabstop #258: FILE: app/test-pmd/config.c:757: + break; ERROR:CODE_INDENT: code indent should use tabs where possible #259: FILE: app/test-pmd/config.c:758: + case -ENOTSUP:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #259: FILE: app/test-pmd/config.c:758: + case -ENOTSUP:$ ERROR:CODE_INDENT: code indent should use tabs where possible #260: FILE: app/test-pmd/config.c:759: + printf("operation not supported by device ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #260: FILE: app/test-pmd/config.c:759: + printf("operation not supported by device ");$ WARNING:TABSTOP: Statements should start on a tabstop #261: FILE: app/test-pmd/config.c:760: + break; ERROR:CODE_INDENT: code indent should use tabs where possible #262: FILE: app/test-pmd/config.c:761: + case -EIO:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #262: FILE: app/test-pmd/config.c:761: + case -EIO:$ WARNING:TABSTOP: Statements should start on a tabstop #264: FILE: app/test-pmd/config.c:763: + break; WARNING:TABSTOP: Statements should start on a tabstop #265: FILE: app/test-pmd/config.c:764: + default: WARNING:TABSTOP: Statements should start on a tabstop #267: FILE: app/test-pmd/config.c:766: + break; WARNING:TABSTOP: Statements should start on a tabstop #268: FILE: app/test-pmd/config.c:767: + } WARNING:TABSTOP: Statements should start on a tabstop #269: FILE: app/test-pmd/config.c:768: + return; WARNING:LEADING_SPACE: please, no spaces at the start of a line #270: FILE: app/test-pmd/config.c:769: + }$ ERROR:TRAILING_WHITESPACE: trailing whitespace #271: FILE: app/test-pmd/config.c:770: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #271: FILE: app/test-pmd/config.c:770: + $ WARNING:LEADING_SPACE: please, no spaces at the start of a line #272: FILE: app/test-pmd/config.c:771: + rte_hexdump(stdout, "hexdump", einfo.data, einfo.length);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #273: FILE: app/test-pmd/config.c:772: + printf("Finish -- Total EEPROM length: %i bytes ", len_eeprom);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #279: FILE: app/test-pmd/config.c:778: + struct rte_eth_dev_module_info minfo;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #280: FILE: app/test-pmd/config.c:779: + struct rte_dev_eeprom_info einfo;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #281: FILE: app/test-pmd/config.c:780: + int ret;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #283: FILE: app/test-pmd/config.c:782: + if (port_id_is_invalid(port_id, ENABLED_WARN)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #283: FILE: app/test-pmd/config.c:782: + if (port_id_is_invalid(port_id, ENABLED_WARN)) { + print_valid_ports(); ERROR:CODE_INDENT: code indent should use tabs where possible #284: FILE: app/test-pmd/config.c:783: + print_valid_ports();$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #284: FILE: app/test-pmd/config.c:783: + print_valid_ports();$ ERROR:CODE_INDENT: code indent should use tabs where possible #285: FILE: app/test-pmd/config.c:784: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #285: FILE: app/test-pmd/config.c:784: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #286: FILE: app/test-pmd/config.c:785: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #288: FILE: app/test-pmd/config.c:787: + ret = rte_eth_dev_get_module_info(port_id, &minfo);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #289: FILE: app/test-pmd/config.c:788: + if (ret != 0) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #289: FILE: app/test-pmd/config.c:788: + if (ret != 0) { + switch (ret) { ERROR:CODE_INDENT: code indent should use tabs where possible #290: FILE: app/test-pmd/config.c:789: + switch (ret) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #290: FILE: app/test-pmd/config.c:789: + switch (ret) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #291: FILE: app/test-pmd/config.c:790: + case -ENODEV:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #291: FILE: app/test-pmd/config.c:790: + case -ENODEV:$ ERROR:CODE_INDENT: code indent should use tabs where possible #292: FILE: app/test-pmd/config.c:791: + printf("port index %d invalid ", port_id);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #292: FILE: app/test-pmd/config.c:791: + printf("port index %d invalid ", port_id);$ ERROR:CODE_INDENT: code indent should use tabs where possible #293: FILE: app/test-pmd/config.c:792: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #293: FILE: app/test-pmd/config.c:792: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #294: FILE: app/test-pmd/config.c:793: + case -ENOTSUP:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #294: FILE: app/test-pmd/config.c:793: + case -ENOTSUP:$ ERROR:CODE_INDENT: code indent should use tabs where possible #295: FILE: app/test-pmd/config.c:794: + printf("operation not supported by device ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #295: FILE: app/test-pmd/config.c:794: + printf("operation not supported by device ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #296: FILE: app/test-pmd/config.c:795: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #296: FILE: app/test-pmd/config.c:795: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #297: FILE: app/test-pmd/config.c:796: + case -EIO:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #297: FILE: app/test-pmd/config.c:796: + case -EIO:$ ERROR:CODE_INDENT: code indent should use tabs where possible #298: FILE: app/test-pmd/config.c:797: + printf("device Iis removed ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #298: FILE: app/test-pmd/config.c:797: + printf("device Iis removed ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #299: FILE: app/test-pmd/config.c:798: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #299: FILE: app/test-pmd/config.c:798: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #300: FILE: app/test-pmd/config.c:799: + default:$ ERROR:CODE_INDENT: code indent should use tabs where possible #301: FILE: app/test-pmd/config.c:800: + printf("Unable to get module info: %d ", ret);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #301: FILE: app/test-pmd/config.c:800: + printf("Unable to get module info: %d ", ret);$ ERROR:CODE_INDENT: code indent should use tabs where possible #302: FILE: app/test-pmd/config.c:801: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #302: FILE: app/test-pmd/config.c:801: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #303: FILE: app/test-pmd/config.c:802: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #303: FILE: app/test-pmd/config.c:802: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #304: FILE: app/test-pmd/config.c:803: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #304: FILE: app/test-pmd/config.c:803: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #305: FILE: app/test-pmd/config.c:804: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #307: FILE: app/test-pmd/config.c:806: + if (minfo.eeprom_len < 0){$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #307: FILE: app/test-pmd/config.c:806: + if (minfo.eeprom_len < 0){ + printf("invalid module eeprom length"); ERROR:SPACING: space required before the open brace '{' #307: FILE: app/test-pmd/config.c:806: + if (minfo.eeprom_len < 0){ ERROR:CODE_INDENT: code indent should use tabs where possible #308: FILE: app/test-pmd/config.c:807: + printf("invalid module eeprom length");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #308: FILE: app/test-pmd/config.c:807: + printf("invalid module eeprom length");$ ERROR:CODE_INDENT: code indent should use tabs where possible #309: FILE: app/test-pmd/config.c:808: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #309: FILE: app/test-pmd/config.c:808: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #310: FILE: app/test-pmd/config.c:809: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #312: FILE: app/test-pmd/config.c:811: + char buf[minfo.eeprom_len];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #313: FILE: app/test-pmd/config.c:812: + einfo.offset = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #314: FILE: app/test-pmd/config.c:813: + einfo.length = minfo.eeprom_len;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #315: FILE: app/test-pmd/config.c:814: + einfo.data = buf;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #317: FILE: app/test-pmd/config.c:816: + ret = rte_eth_dev_get_module_eeprom(port_id, &einfo);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #318: FILE: app/test-pmd/config.c:817: + if (ret != 0) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #318: FILE: app/test-pmd/config.c:817: + if (ret != 0) { + switch (ret) { ERROR:CODE_INDENT: code indent should use tabs where possible #319: FILE: app/test-pmd/config.c:818: + switch (ret) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #319: FILE: app/test-pmd/config.c:818: + switch (ret) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #320: FILE: app/test-pmd/config.c:819: + case -ENODEV:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #320: FILE: app/test-pmd/config.c:819: + case -ENODEV:$ ERROR:CODE_INDENT: code indent should use tabs where possible #321: FILE: app/test-pmd/config.c:820: + printf("port index %d invalid ", port_id);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #321: FILE: app/test-pmd/config.c:820: + printf("port index %d invalid ", port_id);$ ERROR:CODE_INDENT: code indent should use tabs where possible #322: FILE: app/test-pmd/config.c:821: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #322: FILE: app/test-pmd/config.c:821: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #323: FILE: app/test-pmd/config.c:822: + case -ENOTSUP:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #323: FILE: app/test-pmd/config.c:822: + case -ENOTSUP:$ ERROR:CODE_INDENT: code indent should use tabs where possible #324: FILE: app/test-pmd/config.c:823: + printf("operation not supported by device ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #324: FILE: app/test-pmd/config.c:823: + printf("operation not supported by device ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #325: FILE: app/test-pmd/config.c:824: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #325: FILE: app/test-pmd/config.c:824: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #326: FILE: app/test-pmd/config.c:825: + case -EIO:$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #326: FILE: app/test-pmd/config.c:825: + case -EIO:$ ERROR:CODE_INDENT: code indent should use tabs where possible #327: FILE: app/test-pmd/config.c:826: + printf("device Iis removed ");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #327: FILE: app/test-pmd/config.c:826: + printf("device Iis removed ");$ ERROR:CODE_INDENT: code indent should use tabs where possible #328: FILE: app/test-pmd/config.c:827: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #328: FILE: app/test-pmd/config.c:827: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #329: FILE: app/test-pmd/config.c:828: + default:$ ERROR:CODE_INDENT: code indent should use tabs where possible #330: FILE: app/test-pmd/config.c:829: + printf("Unable to get module EEPROM: %d ", ret);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #330: FILE: app/test-pmd/config.c:829: + printf("Unable to get module EEPROM: %d ", ret);$ ERROR:CODE_INDENT: code indent should use tabs where possible #331: FILE: app/test-pmd/config.c:830: + break;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #331: FILE: app/test-pmd/config.c:830: + break;$ ERROR:CODE_INDENT: code indent should use tabs where possible #332: FILE: app/test-pmd/config.c:831: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #332: FILE: app/test-pmd/config.c:831: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #333: FILE: app/test-pmd/config.c:832: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #333: FILE: app/test-pmd/config.c:832: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #334: FILE: app/test-pmd/config.c:833: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #336: FILE: app/test-pmd/config.c:835: + printf(" Port: %d EEPROM: ", port_id);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #337: FILE: app/test-pmd/config.c:836: + rte_hexdump(stdout, "hexdump", einfo.data, einfo.length);$ total: 65 errors, 140 warnings, 271 lines checked