From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Lance Richardson <lance.richardson@broadcom.com>
Subject: [dpdk-test-report] |WARNING| pw77075 [PATCH 11/12] net/bnxt: handle multiple packets per loop in vector PMD
Date: Wed, 9 Sep 2020 17:57:58 +0200 (CEST) [thread overview]
Message-ID: <20200909155758.73E921C0DA@dpdk.org> (raw)
In-Reply-To: <20200909155717.29099-1-lance.richardson@broadcom.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/77075
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pi' - possible side-effects?
#217: FILE: drivers/net/bnxt/bnxt_rxtx_vec_neon.c:25:
+#define GET_OL_FLAGS(rss_flags, ol_idx, errors, pi, ol_flags) \
+{ \
+ uint32_t tmp, of; \
+ \
+ of = vgetq_lane_u32((rss_flags), (pi)) | \
+ bnxt_ol_flags_table[vgetq_lane_u32((ol_idx), (pi))]; \
+ \
+ tmp = vgetq_lane_u32((errors), (pi)); \
+ if (tmp) \
+ of |= bnxt_ol_flags_err_table[tmp]; \
+ (ol_flags) = of; \
+}
WARNING:TYPO_SPELLING: 'curent' may be misspelled - perhaps 'current'?
#488: FILE: drivers/net/bnxt/bnxt_rxtx_vec_neon.c:257:
+ * Load the four curent descriptors into SSE registers in
WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#536: FILE: drivers/net/bnxt/bnxt_rxtx_vec_neon.c:305:
+ /* FALLTHROUGH */
WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#539: FILE: drivers/net/bnxt/bnxt_rxtx_vec_neon.c:308:
+ /* FALLTHROUGH */
WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#542: FILE: drivers/net/bnxt/bnxt_rxtx_vec_neon.c:311:
+ /* FALLTHROUGH */
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pi' - possible side-effects?
#650: FILE: drivers/net/bnxt/bnxt_rxtx_vec_sse.c:25:
+#define GET_OL_FLAGS(rss_flags, ol_index, errors, pi, ol_flags) \
+{ \
+ uint32_t tmp, of; \
+ \
+ of = _mm_extract_epi32((rss_flags), (pi)) | \
+ bnxt_ol_flags_table[_mm_extract_epi32((ol_index), (pi))]; \
+ \
+ tmp = _mm_extract_epi32((errors), (pi)); \
+ if (tmp) \
+ of |= bnxt_ol_flags_err_table[tmp]; \
+ (ol_flags) = of; \
+}
WARNING:TYPO_SPELLING: 'curent' may be misspelled - perhaps 'current'?
#897: FILE: drivers/net/bnxt/bnxt_rxtx_vec_sse.c:237:
+ * Load the four curent descriptors into SSE registers in
WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#956: FILE: drivers/net/bnxt/bnxt_rxtx_vec_sse.c:276:
+ /* FALLTHROUGH */
WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#959: FILE: drivers/net/bnxt/bnxt_rxtx_vec_sse.c:279:
+ /* FALLTHROUGH */
WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#962: FILE: drivers/net/bnxt/bnxt_rxtx_vec_sse.c:282:
+ /* FALLTHROUGH */
total: 0 errors, 8 warnings, 2 checks, 857 lines checked
parent reply other threads:[~2020-09-09 15:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200909155717.29099-1-lance.richardson@broadcom.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909155758.73E921C0DA@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=lance.richardson@broadcom.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).