From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Simei Su <simei.su@intel.com>
Subject: [dpdk-test-report] |WARNING| pw77127 [PATCH v1 3/3] net/ice: support ACL filter in DCF
Date: Thu, 10 Sep 2020 09:43:10 +0200 (CEST) [thread overview]
Message-ID: <20200910074310.AD22E1BEB3@dpdk.org> (raw)
In-Reply-To: <1599723455-353059-4-git-send-email-simei.su@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/77127
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_mask->hdr.src_addr == UINT32_MAX'
#891: FILE: drivers/net/ice/ice_acl_filter.c:810:
+ if ((ipv4_mask->hdr.src_addr == UINT32_MAX) ||
+ (ipv4_mask->hdr.dst_addr == UINT32_MAX)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_mask->hdr.dst_addr == UINT32_MAX'
#891: FILE: drivers/net/ice/ice_acl_filter.c:810:
+ if ((ipv4_mask->hdr.src_addr == UINT32_MAX) ||
+ (ipv4_mask->hdr.dst_addr == UINT32_MAX)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_spec->hdr.src_addr != 0'
#900: FILE: drivers/net/ice/ice_acl_filter.c:819:
+ if ((ipv4_spec->hdr.src_addr != 0) &&
+ (ipv4_mask->hdr.src_addr != 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_mask->hdr.src_addr != 0'
#900: FILE: drivers/net/ice/ice_acl_filter.c:819:
+ if ((ipv4_spec->hdr.src_addr != 0) &&
+ (ipv4_mask->hdr.src_addr != 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_spec->hdr.dst_addr != 0'
#910: FILE: drivers/net/ice/ice_acl_filter.c:829:
+ if ((ipv4_spec->hdr.dst_addr != 0) &&
+ (ipv4_mask->hdr.dst_addr != 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ipv4_mask->hdr.dst_addr != 0'
#910: FILE: drivers/net/ice/ice_acl_filter.c:829:
+ if ((ipv4_spec->hdr.dst_addr != 0) &&
+ (ipv4_mask->hdr.dst_addr != 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_mask->hdr.src_port == UINT16_MAX'
#943: FILE: drivers/net/ice/ice_acl_filter.c:862:
+ if ((tcp_mask->hdr.src_port == UINT16_MAX) ||
+ (tcp_mask->hdr.dst_port == UINT16_MAX)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_mask->hdr.dst_port == UINT16_MAX'
#943: FILE: drivers/net/ice/ice_acl_filter.c:862:
+ if ((tcp_mask->hdr.src_port == UINT16_MAX) ||
+ (tcp_mask->hdr.dst_port == UINT16_MAX)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_mask->hdr.src_port == UINT16_MAX'
#952: FILE: drivers/net/ice/ice_acl_filter.c:871:
+ if ((tcp_mask->hdr.src_port == UINT16_MAX) ||
+ (tcp_mask->hdr.dst_port == UINT16_MAX)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_mask->hdr.dst_port == UINT16_MAX'
#952: FILE: drivers/net/ice/ice_acl_filter.c:871:
+ if ((tcp_mask->hdr.src_port == UINT16_MAX) ||
+ (tcp_mask->hdr.dst_port == UINT16_MAX)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#961: FILE: drivers/net/ice/ice_acl_filter.c:880:
+ if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+ (tcp_spec->hdr.src_port != 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_spec->hdr.src_port != 0'
#961: FILE: drivers/net/ice/ice_acl_filter.c:880:
+ if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+ (tcp_spec->hdr.src_port != 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#970: FILE: drivers/net/ice/ice_acl_filter.c:889:
+ if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+ (tcp_spec->hdr.dst_port != 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tcp_spec->hdr.dst_port != 0'
#970: FILE: drivers/net/ice/ice_acl_filter.c:889:
+ if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+ (tcp_spec->hdr.dst_port != 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'udp_mask->hdr.src_port == UINT16_MAX'
#999: FILE: drivers/net/ice/ice_acl_filter.c:918:
+ if ((udp_mask->hdr.src_port == UINT16_MAX) ||
+ (udp_mask->hdr.dst_port == UINT16_MAX)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'udp_mask->hdr.dst_port == UINT16_MAX'
#999: FILE: drivers/net/ice/ice_acl_filter.c:918:
+ if ((udp_mask->hdr.src_port == UINT16_MAX) ||
+ (udp_mask->hdr.dst_port == UINT16_MAX)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#1009: FILE: drivers/net/ice/ice_acl_filter.c:928:
+ if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+ (udp_spec->hdr.src_port != 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'udp_spec->hdr.src_port != 0'
#1009: FILE: drivers/net/ice/ice_acl_filter.c:928:
+ if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+ (udp_spec->hdr.src_port != 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'l3 == RTE_FLOW_ITEM_TYPE_IPV4'
#1018: FILE: drivers/net/ice/ice_acl_filter.c:937:
+ if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+ (udp_spec->hdr.dst_port != 0)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'udp_spec->hdr.dst_port != 0'
#1018: FILE: drivers/net/ice/ice_acl_filter.c:937:
+ if ((l3 == RTE_FLOW_ITEM_TYPE_IPV4) &&
+ (udp_spec->hdr.dst_port != 0)) {
total: 0 errors, 0 warnings, 20 checks, 1119 lines checked
next parent reply other threads:[~2020-09-10 7:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1599723455-353059-4-git-send-email-simei.su@intel.com>
2020-09-10 7:43 ` checkpatch [this message]
2020-09-10 9:57 ` [dpdk-test-report] |SUCCESS| pw77127 " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910074310.AD22E1BEB3@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=simei.su@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).