[dpdk-test-report] |WARNING| pw77604 [PATCH] pci: support both PIO and MMIO bar for legacy virtio on x86

[checkpatch@dpdk.org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2925 bytes --]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/77604

_coding style issues_


ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#224: FILE: drivers/bus/pci/linux/pci.c:686:
rte_pci_device *device,

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#301: FILE: drivers/bus/pci/linux/pci.c:699:
          if (pci_vfio_is_enabled())
+            ret = pci_uio_ioport_map(dev, bar, p);

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#347: FILE: drivers/bus/pci/linux/pci_uio.c:375:
+    FILE *f;
             ^

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#367: FILE: drivers/bus/pci/linux/pci_uio.c:390:
+    if (f == NULL) {
+        RTE_LOG(ERR, EAL, "Cannot open sysfs resource: %s
",

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#372: FILE: drivers/bus/pci/linux/pci_uio.c:395:
+    for (i = 0; i < bar + 1; i++) {
+        if (fgets(buf, sizeof(buf), f) == NULL) {

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#373: FILE: drivers/bus/pci/linux/pci_uio.c:396:
+        if (fgets(buf, sizeof(buf), f) == NULL) {
+            RTE_LOG(ERR, EAL, "Cannot read sysfs resource
");

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#378: FILE: drivers/bus/pci/linux/pci_uio.c:401:
+    if (pci_parse_one_sysfs_resource(buf, sizeof(buf), &phys_addr,
[...]
+        goto error;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#385: FILE: drivers/bus/pci/linux/pci_uio.c:405:
+    if (flags & IORESOURCE_IO) {
+        iobar = 1;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#389: FILE: drivers/bus/pci/linux/pci_uio.c:409:
+    } else if (flags & IORESOURCE_MEM) {
+        iobar = 0;

ERROR:TRAILING_WHITESPACE: trailing whitespace
#392: FILE: drivers/bus/pci/linux/pci_uio.c:412:
+        RTE_LOG(INFO, EAL, "%s(): membar %08lx detected
", __func__, $

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#394: FILE: drivers/bus/pci/linux/pci_uio.c:413:
+    } else {
+        RTE_LOG(ERR, EAL, "%s(): unknown bar type
", __func__);

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#405: FILE: drivers/bus/pci/linux/pci_uio.c:418:
+    if (iobar && rte_eal_iopl_init() != 0) {
+        RTE_LOG(ERR, EAL, "%s(): insufficient ioport permissions for 

ERROR:TRAILING_WHITESPACE: trailing whitespace
#406: FILE: drivers/bus/pci/linux/pci_uio.c:419:
+        RTE_LOG(ERR, EAL, "%s(): insufficient ioport permissions for $

WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author ''

total: 4 errors, 10 warnings, 321 lines checked