* [dpdk-test-report] |WARNING| pw77608 [PATCH] pci: support both PIO and MMIO bar for legacy virtio on x86
[not found] <7558efff-25ff-836b-12e1-140f34869ba5@alibaba-inc.com>
@ 2020-09-14 13:13 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-09-14 13:13 UTC (permalink / raw)
To: test-report
Cc: 谢华伟(此时此刻）
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 3078 bytes --]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/77608
_coding style issues_
WARNING:TYPO_SPELLING: 'diffrent' may be misspelled - perhaps 'different'?
#66:
we unify the way to get both PIO and MMIO address for diffrent driver
ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#225: FILE: drivers/bus/pci/linux/pci.c:686:
rte_pci_device *device,
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#302: FILE: drivers/bus/pci/linux/pci.c:699:
if (pci_vfio_is_enabled())
+ ret = pci_uio_ioport_map(dev, bar, p);
ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#348: FILE: drivers/bus/pci/linux/pci_uio.c:375:
+ FILE *f;
^
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#368: FILE: drivers/bus/pci/linux/pci_uio.c:390:
+ if (f == NULL) {
+ RTE_LOG(ERR, EAL, "Cannot open sysfs resource: %s
",
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#373: FILE: drivers/bus/pci/linux/pci_uio.c:395:
+ for (i = 0; i < bar + 1; i++) {
+ if (fgets(buf, sizeof(buf), f) == NULL) {
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#374: FILE: drivers/bus/pci/linux/pci_uio.c:396:
+ if (fgets(buf, sizeof(buf), f) == NULL) {
+ RTE_LOG(ERR, EAL, "Cannot read sysfs resource
");
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#379: FILE: drivers/bus/pci/linux/pci_uio.c:401:
+ if (pci_parse_one_sysfs_resource(buf, sizeof(buf), &phys_addr,
[...]
+ goto error;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#386: FILE: drivers/bus/pci/linux/pci_uio.c:405:
+ if (flags & IORESOURCE_IO) {
+ iobar = 1;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#390: FILE: drivers/bus/pci/linux/pci_uio.c:409:
+ } else if (flags & IORESOURCE_MEM) {
+ iobar = 0;
ERROR:TRAILING_WHITESPACE: trailing whitespace
#393: FILE: drivers/bus/pci/linux/pci_uio.c:412:
+ RTE_LOG(INFO, EAL, "%s(): membar %08lx detected
", __func__, $
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#395: FILE: drivers/bus/pci/linux/pci_uio.c:413:
+ } else {
+ RTE_LOG(ERR, EAL, "%s(): unknown bar type
", __func__);
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#406: FILE: drivers/bus/pci/linux/pci_uio.c:418:
+ if (iobar && rte_eal_iopl_init() != 0) {
+ RTE_LOG(ERR, EAL, "%s(): insufficient ioport permissions for
ERROR:TRAILING_WHITESPACE: trailing whitespace
#407: FILE: drivers/bus/pci/linux/pci_uio.c:419:
+ RTE_LOG(ERR, EAL, "%s(): insufficient ioport permissions for $
WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author ''
total: 4 errors, 11 warnings, 321 lines checked
^ permalink raw reply [flat|nested] only message in thread