From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-test-report] |WARNING| pw77641 [PATCH v2 03/17] eal: rename lcore word choices
Date: Mon, 14 Sep 2020 20:22:03 +0200 (CEST) [thread overview]
Message-ID: <20200914182203.BD6C61C0D4@dpdk.org> (raw)
In-Reply-To: <20200914182002.6750-4-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/77641
_coding style issues_
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#79:
Replace master lcore with main lcore and
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#80:
replace slave lcore with worker lcore.
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#85:
The "--master-lcore" command line option is also deprecated
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#153: FILE: doc/guides/rel_notes/release_20_11.rst:100:
+* eal: Changed the function ``rte_get_master_lcore()`` is
WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#157: FILE: doc/guides/rel_notes/release_20_11.rst:104:
+ ``RTE_LCORE_FOREACH_SLAVE`` will be replaced with
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#160: FILE: doc/guides/rel_notes/release_20_11.rst:107:
+ The ``master-lcore`` argument to testpmd will be replaced
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#161: FILE: doc/guides/rel_notes/release_20_11.rst:108:
+ with ``main-lcore``. The old ``master-lcore`` argument
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#205: FILE: lib/librte_eal/common/eal_common_launch.c:24:
+rte_eal_wait_lcore(unsigned worker_id)
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#408: FILE: lib/librte_eal/common/eal_common_options.c:1598:
+ "option --" OPT_MASTER_LCORE
WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#410: FILE: lib/librte_eal/common/eal_common_options.c:1600:
+ /* fallthrough */
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#611: FILE: lib/librte_eal/freebsd/eal_thread.c:34:
+rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned worker_id)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#774: FILE: lib/librte_eal/include/rte_launch.h:65:
+int rte_eal_remote_launch(lcore_function_t *f, void *arg, unsigned worker_id);
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#790: FILE: lib/librte_eal/include/rte_launch.h:77:
+#define SKIP_MASTER RTE_DEPRECATED(SKIP_MASTER) SKIP_MAIN
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#790: FILE: lib/librte_eal/include/rte_launch.h:77:
+#define SKIP_MASTER RTE_DEPRECATED(SKIP_MASTER) SKIP_MAIN
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#790: FILE: lib/librte_eal/include/rte_launch.h:77:
+#define SKIP_MASTER ^IRTE_DEPRECATED(SKIP_MASTER) SKIP_MAIN$
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#790: FILE: lib/librte_eal/include/rte_launch.h:77:
+#define SKIP_MASTER RTE_DEPRECATED(SKIP_MASTER) SKIP_MAIN
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#791: FILE: lib/librte_eal/include/rte_launch.h:78:
+#define CALL_MASTER RTE_DEPRECATED(CALL_MASTER) CALL_MAIN
WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'?
#791: FILE: lib/librte_eal/include/rte_launch.h:78:
+#define CALL_MASTER RTE_DEPRECATED(CALL_MASTER) CALL_MAIN
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#791: FILE: lib/librte_eal/include/rte_launch.h:78:
+#define CALL_MASTER ^IRTE_DEPRECATED(CALL_MASTER) CALL_MAIN$
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#791: FILE: lib/librte_eal/include/rte_launch.h:78:
+#define CALL_MASTER RTE_DEPRECATED(CALL_MASTER) CALL_MAIN
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#836: FILE: lib/librte_eal/include/rte_launch.h:114:
+enum rte_lcore_state_t rte_eal_get_lcore_state(unsigned worker_id);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#862: FILE: lib/librte_eal/include/rte_launch.h:134:
+int rte_eal_wait_lcore(unsigned worker_id);
WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#903: FILE: lib/librte_eal/include/rte_lcore.h:95:
+static inline unsigned int rte_get_master_lcore(void)
WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#947: FILE: lib/librte_eal/include/rte_lcore.h:244:
+#define RTE_LCORE_FOREACH_SLAVE(l) \
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#947: FILE: lib/librte_eal/include/rte_lcore.h:244:
+#define RTE_LCORE_FOREACH_SLAVE(l) \
+ RTE_DEPRECATED(RTE_LCORE_FOREACH_SLAVE) RTE_LCORE_FOREACH_WORKER(l)
WARNING:TYPO_SPELLING: 'SLAVE' may be misspelled - perhaps 'SECONDARY'?
#948: FILE: lib/librte_eal/include/rte_lcore.h:245:
+ RTE_DEPRECATED(RTE_LCORE_FOREACH_SLAVE) RTE_LCORE_FOREACH_WORKER(l)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1072: FILE: lib/librte_eal/linux/eal_thread.c:34:
+rte_eal_remote_launch(int (*f)(void *), void *arg, unsigned worker_id)
total: 3 errors, 24 warnings, 1052 lines checked
ERROR: symbol rte_get_main_lcore is added in the DPDK_21 section, but is expected to be added in the EXPERIMENTAL section of the version map
INFO: symbol rte_get_master_lcore is being removed, ensure that it has gone through the deprecation process
parent reply other threads:[~2020-09-14 18:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20200914182002.6750-4-stephen@networkplumber.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914182203.BD6C61C0D4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).