From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C2C0A04C8 for ; Sat, 19 Sep 2020 04:54:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8EEDE1D993; Sat, 19 Sep 2020 04:54:13 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 364551D99F; Sat, 19 Sep 2020 04:54:12 +0200 (CEST) In-Reply-To: <1600483953-28579-1-git-send-email-navasile@linux.microsoft.com> References: <1600483953-28579-1-git-send-email-navasile@linux.microsoft.com> To: test-report@dpdk.org Cc: Narcisa Ana Maria Vasile Message-Id: <20200919025412.364551D99F@dpdk.org> Date: Sat, 19 Sep 2020 04:54:12 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw78114 [PATCH v4] windows/netuio: add Windows NetUIO kernel driver X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/78114 _coding style issues_ WARNING:SPACING: space prohibited between function name and open parenthesis '(' #522: FILE: windows/netuio/netuio_dev.c:12: +#pragma alloc_text (PAGE, netuio_create_device) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #523: FILE: windows/netuio/netuio_dev.c:13: +#pragma alloc_text (PAGE, netuio_map_hw_resources) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #524: FILE: windows/netuio/netuio_dev.c:14: +#pragma alloc_text (PAGE, netuio_free_hw_resources) WARNING:LEADING_SPACE: please, no spaces at the start of a line #530: FILE: windows/netuio/netuio_dev.c:20: + NTSTATUS status = STATUS_UNSUCCESSFUL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #532: FILE: windows/netuio/netuio_dev.c:22: + PNETUIO_CONTEXT_DATA ctx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #533: FILE: windows/netuio/netuio_dev.c:23: + ctx = netuio_get_context_data(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #535: FILE: windows/netuio/netuio_dev.c:25: + ctx->wdf_device = device; // Store for later use$ ERROR:C99_COMMENTS: do not use C99 // comments #535: FILE: windows/netuio/netuio_dev.c:25: + ctx->wdf_device = device; // Store for later use WARNING:LEADING_SPACE: please, no spaces at the start of a line #537: FILE: windows/netuio/netuio_dev.c:27: + // Obtain the BUS_INTERFACE_STANDARD interface from the Bus Driver$ ERROR:C99_COMMENTS: do not use C99 // comments #537: FILE: windows/netuio/netuio_dev.c:27: + // Obtain the BUS_INTERFACE_STANDARD interface from the Bus Driver WARNING:LEADING_SPACE: please, no spaces at the start of a line #538: FILE: windows/netuio/netuio_dev.c:28: + status = WdfFdoQueryForInterface(device,$ ERROR:CODE_INDENT: code indent should use tabs where possible #539: FILE: windows/netuio/netuio_dev.c:29: + &GUID_BUS_INTERFACE_STANDARD,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #539: FILE: windows/netuio/netuio_dev.c:29: + &GUID_BUS_INTERFACE_STANDARD,$ ERROR:CODE_INDENT: code indent should use tabs where possible #540: FILE: windows/netuio/netuio_dev.c:30: + (PINTERFACE)&ctx->bus_interface,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #540: FILE: windows/netuio/netuio_dev.c:30: + (PINTERFACE)&ctx->bus_interface,$ ERROR:CODE_INDENT: code indent should use tabs where possible #541: FILE: windows/netuio/netuio_dev.c:31: + sizeof(BUS_INTERFACE_STANDARD),$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #541: FILE: windows/netuio/netuio_dev.c:31: + sizeof(BUS_INTERFACE_STANDARD),$ ERROR:CODE_INDENT: code indent should use tabs where possible #542: FILE: windows/netuio/netuio_dev.c:32: + 1,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #542: FILE: windows/netuio/netuio_dev.c:32: + 1,$ ERROR:CODE_INDENT: code indent should use tabs where possible #543: FILE: windows/netuio/netuio_dev.c:33: + NULL);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #543: FILE: windows/netuio/netuio_dev.c:33: + NULL);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #544: FILE: windows/netuio/netuio_dev.c:34: + if (!NT_SUCCESS(status))$ ERROR:CODE_INDENT: code indent should use tabs where possible #545: FILE: windows/netuio/netuio_dev.c:35: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #545: FILE: windows/netuio/netuio_dev.c:35: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #547: FILE: windows/netuio/netuio_dev.c:37: + // Retrieve the B:D:F details of our device$ ERROR:C99_COMMENTS: do not use C99 // comments #547: FILE: windows/netuio/netuio_dev.c:37: + // Retrieve the B:D:F details of our device WARNING:LEADING_SPACE: please, no spaces at the start of a line #548: FILE: windows/netuio/netuio_dev.c:38: + PDEVICE_OBJECT pdo = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #549: FILE: windows/netuio/netuio_dev.c:39: + pdo = WdfDeviceWdmGetPhysicalDevice(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #550: FILE: windows/netuio/netuio_dev.c:40: + if (pdo) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #551: FILE: windows/netuio/netuio_dev.c:41: + ULONG prop = 0, length = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #551: FILE: windows/netuio/netuio_dev.c:41: + ULONG prop = 0, length = 0;$ WARNING:LONG_LINE: line over 100 characters #552: FILE: windows/netuio/netuio_dev.c:42: + status = IoGetDeviceProperty(pdo, DevicePropertyBusNumber, sizeof(ULONG), (PVOID)&ctx->addr.bus_num, &length); ERROR:CODE_INDENT: code indent should use tabs where possible #552: FILE: windows/netuio/netuio_dev.c:42: + status = IoGetDeviceProperty(pdo, DevicePropertyBusNumber, sizeof(ULONG), (PVOID)&ctx->addr.bus_num, &length);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #552: FILE: windows/netuio/netuio_dev.c:42: + status = IoGetDeviceProperty(pdo, DevicePropertyBusNumber, sizeof(ULONG), (PVOID)&ctx->addr.bus_num, &length);$ ERROR:CODE_INDENT: code indent should use tabs where possible #553: FILE: windows/netuio/netuio_dev.c:43: + if (!NT_SUCCESS(status)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #553: FILE: windows/netuio/netuio_dev.c:43: + if (!NT_SUCCESS(status)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #553: FILE: windows/netuio/netuio_dev.c:43: + if (!NT_SUCCESS(status)) { + return status; WARNING:BRACES: braces {} are not necessary for single statement blocks #553: FILE: windows/netuio/netuio_dev.c:43: + if (!NT_SUCCESS(status)) { + return status; + } ERROR:CODE_INDENT: code indent should use tabs where possible #554: FILE: windows/netuio/netuio_dev.c:44: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #554: FILE: windows/netuio/netuio_dev.c:44: + return status;$ ERROR:CODE_INDENT: code indent should use tabs where possible #555: FILE: windows/netuio/netuio_dev.c:45: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #555: FILE: windows/netuio/netuio_dev.c:45: + }$ WARNING:LONG_LINE: line over 100 characters #557: FILE: windows/netuio/netuio_dev.c:47: + status = IoGetDeviceProperty(pdo, DevicePropertyAddress, sizeof(ULONG), (PVOID)&prop, &length); ERROR:CODE_INDENT: code indent should use tabs where possible #557: FILE: windows/netuio/netuio_dev.c:47: + status = IoGetDeviceProperty(pdo, DevicePropertyAddress, sizeof(ULONG), (PVOID)&prop, &length);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #557: FILE: windows/netuio/netuio_dev.c:47: + status = IoGetDeviceProperty(pdo, DevicePropertyAddress, sizeof(ULONG), (PVOID)&prop, &length);$ ERROR:CODE_INDENT: code indent should use tabs where possible #558: FILE: windows/netuio/netuio_dev.c:48: + if (!NT_SUCCESS(status)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #558: FILE: windows/netuio/netuio_dev.c:48: + if (!NT_SUCCESS(status)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #558: FILE: windows/netuio/netuio_dev.c:48: + if (!NT_SUCCESS(status)) { + return status; WARNING:BRACES: braces {} are not necessary for single statement blocks #558: FILE: windows/netuio/netuio_dev.c:48: + if (!NT_SUCCESS(status)) { + return status; + } ERROR:CODE_INDENT: code indent should use tabs where possible #559: FILE: windows/netuio/netuio_dev.c:49: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #559: FILE: windows/netuio/netuio_dev.c:49: + return status;$ ERROR:CODE_INDENT: code indent should use tabs where possible #560: FILE: windows/netuio/netuio_dev.c:50: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #560: FILE: windows/netuio/netuio_dev.c:50: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #562: FILE: windows/netuio/netuio_dev.c:52: + ctx->addr.func_num = prop & 0x0000FFFF;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #562: FILE: windows/netuio/netuio_dev.c:52: + ctx->addr.func_num = prop & 0x0000FFFF;$ ERROR:CODE_INDENT: code indent should use tabs where possible #563: FILE: windows/netuio/netuio_dev.c:53: + ctx->addr.dev_num = ((prop >> 16) & 0x0000FFFF);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #563: FILE: windows/netuio/netuio_dev.c:53: + ctx->addr.dev_num = ((prop >> 16) & 0x0000FFFF);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #564: FILE: windows/netuio/netuio_dev.c:54: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #566: FILE: windows/netuio/netuio_dev.c:56: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #572: FILE: windows/netuio/netuio_dev.c:62: + DECLARE_UNICODE_STRING_SIZE(symbolic_link, NETUIO_MAX_SYMLINK_LEN);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #574: FILE: windows/netuio/netuio_dev.c:64: + PNETUIO_CONTEXT_DATA ctx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #575: FILE: windows/netuio/netuio_dev.c:65: + ctx = netuio_get_context_data(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #577: FILE: windows/netuio/netuio_dev.c:67: + // Build symbolic link name as _BDF (bus/device/func)$ ERROR:C99_COMMENTS: do not use C99 // comments #577: FILE: windows/netuio/netuio_dev.c:67: + // Build symbolic link name as _BDF (bus/device/func) WARNING:LEADING_SPACE: please, no spaces at the start of a line #578: FILE: windows/netuio/netuio_dev.c:68: + RtlUnicodeStringPrintf(&symbolic_link,$ ERROR:CODE_INDENT: code indent should use tabs where possible #579: FILE: windows/netuio/netuio_dev.c:69: + L"%s_%04x%02x%02x",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #579: FILE: windows/netuio/netuio_dev.c:69: + L"%s_%04x%02x%02x",$ ERROR:CODE_INDENT: code indent should use tabs where possible #580: FILE: windows/netuio/netuio_dev.c:70: + NETUIO_DEVICE_SYMBOLIC_LINK_UNICODE,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #580: FILE: windows/netuio/netuio_dev.c:70: + NETUIO_DEVICE_SYMBOLIC_LINK_UNICODE,$ ERROR:CODE_INDENT: code indent should use tabs where possible #581: FILE: windows/netuio/netuio_dev.c:71: + ctx->addr.bus_num,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #581: FILE: windows/netuio/netuio_dev.c:71: + ctx->addr.bus_num,$ ERROR:CODE_INDENT: code indent should use tabs where possible #582: FILE: windows/netuio/netuio_dev.c:72: + ctx->addr.dev_num,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #582: FILE: windows/netuio/netuio_dev.c:72: + ctx->addr.dev_num,$ ERROR:CODE_INDENT: code indent should use tabs where possible #583: FILE: windows/netuio/netuio_dev.c:73: + ctx->addr.func_num);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #583: FILE: windows/netuio/netuio_dev.c:73: + ctx->addr.func_num);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #585: FILE: windows/netuio/netuio_dev.c:75: + return WdfDeviceCreateSymbolicLink(device, &symbolic_link);$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #589: FILE: windows/netuio/netuio_dev.c:79: +/* +Routine Description: WARNING:LEADING_SPACE: please, no spaces at the start of a line #599: FILE: windows/netuio/netuio_dev.c:89: + NTSTATUS status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #600: FILE: windows/netuio/netuio_dev.c:90: + WDFDEVICE device = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #602: FILE: windows/netuio/netuio_dev.c:92: + WDF_OBJECT_ATTRIBUTES deviceAttributes;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #603: FILE: windows/netuio/netuio_dev.c:93: + WDF_PNPPOWER_EVENT_CALLBACKS pnpPowerCallbacks;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #604: FILE: windows/netuio/netuio_dev.c:94: + WDF_FILEOBJECT_CONFIG fileConfig;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #605: FILE: windows/netuio/netuio_dev.c:95: + WDF_OBJECT_ATTRIBUTES fileAttributes;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #607: FILE: windows/netuio/netuio_dev.c:97: + PAGED_CODE();$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #609: FILE: windows/netuio/netuio_dev.c:99: + // Register PnP power management callbacks$ ERROR:C99_COMMENTS: do not use C99 // comments #609: FILE: windows/netuio/netuio_dev.c:99: + // Register PnP power management callbacks WARNING:LEADING_SPACE: please, no spaces at the start of a line #610: FILE: windows/netuio/netuio_dev.c:100: + WDF_PNPPOWER_EVENT_CALLBACKS_INIT(&pnpPowerCallbacks);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #611: FILE: windows/netuio/netuio_dev.c:101: + pnpPowerCallbacks.EvtDevicePrepareHardware = netuio_evt_prepare_hw;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #612: FILE: windows/netuio/netuio_dev.c:102: + pnpPowerCallbacks.EvtDeviceReleaseHardware = netuio_evt_release_hw;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #613: FILE: windows/netuio/netuio_dev.c:103: + WdfDeviceInitSetPnpPowerEventCallbacks(DeviceInit, &pnpPowerCallbacks);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #615: FILE: windows/netuio/netuio_dev.c:105: + // Register callbacks for when a HANDLE is opened or closed.$ ERROR:C99_COMMENTS: do not use C99 // comments #615: FILE: windows/netuio/netuio_dev.c:105: + // Register callbacks for when a HANDLE is opened or closed. WARNING:LEADING_SPACE: please, no spaces at the start of a line #616: FILE: windows/netuio/netuio_dev.c:106: + WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&fileAttributes, NETUIO_FILE_CONTEXT_DATA);$ WARNING:LONG_LINE: line over 100 characters #617: FILE: windows/netuio/netuio_dev.c:107: + WDF_FILEOBJECT_CONFIG_INIT(&fileConfig, WDF_NO_EVENT_CALLBACK, WDF_NO_EVENT_CALLBACK, netuio_evt_file_cleanup); WARNING:LEADING_SPACE: please, no spaces at the start of a line #617: FILE: windows/netuio/netuio_dev.c:107: + WDF_FILEOBJECT_CONFIG_INIT(&fileConfig, WDF_NO_EVENT_CALLBACK, WDF_NO_EVENT_CALLBACK, netuio_evt_file_cleanup);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #618: FILE: windows/netuio/netuio_dev.c:108: + WdfDeviceInitSetFileObjectConfig(DeviceInit, &fileConfig, &fileAttributes);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #620: FILE: windows/netuio/netuio_dev.c:110: + WDF_OBJECT_ATTRIBUTES_INIT_CONTEXT_TYPE(&deviceAttributes, NETUIO_CONTEXT_DATA);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #621: FILE: windows/netuio/netuio_dev.c:111: + WdfDeviceInitSetIoInCallerContextCallback(DeviceInit, netuio_evt_IO_in_caller_context);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #623: FILE: windows/netuio/netuio_dev.c:113: + status = WdfDeviceCreate(&DeviceInit, &deviceAttributes, &device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #625: FILE: windows/netuio/netuio_dev.c:115: + if (NT_SUCCESS(status)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #626: FILE: windows/netuio/netuio_dev.c:116: + // Create a device interface so that applications can find and talk to us.$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #626: FILE: windows/netuio/netuio_dev.c:116: + // Create a device interface so that applications can find and talk to us.$ ERROR:C99_COMMENTS: do not use C99 // comments #626: FILE: windows/netuio/netuio_dev.c:116: + // Create a device interface so that applications can find and talk to us. ERROR:CODE_INDENT: code indent should use tabs where possible #627: FILE: windows/netuio/netuio_dev.c:117: + status = WdfDeviceCreateDeviceInterface(device, &GUID_DEVINTERFACE_netUIO, NULL);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #627: FILE: windows/netuio/netuio_dev.c:117: + status = WdfDeviceCreateDeviceInterface(device, &GUID_DEVINTERFACE_netUIO, NULL);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #628: FILE: windows/netuio/netuio_dev.c:118: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #630: FILE: windows/netuio/netuio_dev.c:120: + if (NT_SUCCESS(status)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #631: FILE: windows/netuio/netuio_dev.c:121: + // Retrieve and store PCI information$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #631: FILE: windows/netuio/netuio_dev.c:121: + // Retrieve and store PCI information$ ERROR:C99_COMMENTS: do not use C99 // comments #631: FILE: windows/netuio/netuio_dev.c:121: + // Retrieve and store PCI information ERROR:CODE_INDENT: code indent should use tabs where possible #632: FILE: windows/netuio/netuio_dev.c:122: + status = get_pci_device_info(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #632: FILE: windows/netuio/netuio_dev.c:122: + status = get_pci_device_info(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #633: FILE: windows/netuio/netuio_dev.c:123: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #635: FILE: windows/netuio/netuio_dev.c:125: + if (NT_SUCCESS(status)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #636: FILE: windows/netuio/netuio_dev.c:126: + // Create a symbolic link name for user-space access$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #636: FILE: windows/netuio/netuio_dev.c:126: + // Create a symbolic link name for user-space access$ ERROR:C99_COMMENTS: do not use C99 // comments #636: FILE: windows/netuio/netuio_dev.c:126: + // Create a symbolic link name for user-space access ERROR:CODE_INDENT: code indent should use tabs where possible #637: FILE: windows/netuio/netuio_dev.c:127: + status = create_device_specific_symbolic_link(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #637: FILE: windows/netuio/netuio_dev.c:127: + status = create_device_specific_symbolic_link(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #638: FILE: windows/netuio/netuio_dev.c:128: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #640: FILE: windows/netuio/netuio_dev.c:130: + if (NT_SUCCESS(status)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #641: FILE: windows/netuio/netuio_dev.c:131: + // Initialize the I/O Package and any Queues$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #641: FILE: windows/netuio/netuio_dev.c:131: + // Initialize the I/O Package and any Queues$ ERROR:C99_COMMENTS: do not use C99 // comments #641: FILE: windows/netuio/netuio_dev.c:131: + // Initialize the I/O Package and any Queues ERROR:CODE_INDENT: code indent should use tabs where possible #642: FILE: windows/netuio/netuio_dev.c:132: + status = netuio_queue_initialize(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #642: FILE: windows/netuio/netuio_dev.c:132: + status = netuio_queue_initialize(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #643: FILE: windows/netuio/netuio_dev.c:133: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #645: FILE: windows/netuio/netuio_dev.c:135: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #652: FILE: windows/netuio/netuio_dev.c:142: + UNREFERENCED_PARAMETER(Resources);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #654: FILE: windows/netuio/netuio_dev.c:144: + NTSTATUS status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #656: FILE: windows/netuio/netuio_dev.c:146: + PNETUIO_CONTEXT_DATA ctx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #657: FILE: windows/netuio/netuio_dev.c:147: + ctx = netuio_get_context_data(Device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #659: FILE: windows/netuio/netuio_dev.c:149: + PCI_COMMON_HEADER pci_config = {0};$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #660: FILE: windows/netuio/netuio_dev.c:150: + ULONG bytes_returned;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #662: FILE: windows/netuio/netuio_dev.c:152: + // Read PCI configuration space$ ERROR:C99_COMMENTS: do not use C99 // comments #662: FILE: windows/netuio/netuio_dev.c:152: + // Read PCI configuration space WARNING:LEADING_SPACE: please, no spaces at the start of a line #663: FILE: windows/netuio/netuio_dev.c:153: + bytes_returned = ctx->bus_interface.GetBusData($ ERROR:CODE_INDENT: code indent should use tabs where possible #664: FILE: windows/netuio/netuio_dev.c:154: + ctx->bus_interface.Context,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #664: FILE: windows/netuio/netuio_dev.c:154: + ctx->bus_interface.Context,$ ERROR:CODE_INDENT: code indent should use tabs where possible #665: FILE: windows/netuio/netuio_dev.c:155: + PCI_WHICHSPACE_CONFIG,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #665: FILE: windows/netuio/netuio_dev.c:155: + PCI_WHICHSPACE_CONFIG,$ ERROR:CODE_INDENT: code indent should use tabs where possible #666: FILE: windows/netuio/netuio_dev.c:156: + &pci_config,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #666: FILE: windows/netuio/netuio_dev.c:156: + &pci_config,$ ERROR:CODE_INDENT: code indent should use tabs where possible #667: FILE: windows/netuio/netuio_dev.c:157: + 0,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #667: FILE: windows/netuio/netuio_dev.c:157: + 0,$ ERROR:CODE_INDENT: code indent should use tabs where possible #668: FILE: windows/netuio/netuio_dev.c:158: + sizeof(pci_config));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #668: FILE: windows/netuio/netuio_dev.c:158: + sizeof(pci_config));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #670: FILE: windows/netuio/netuio_dev.c:160: + if (bytes_returned != sizeof(pci_config)) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #671: FILE: windows/netuio/netuio_dev.c:161: + status = STATUS_NOT_SUPPORTED;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #671: FILE: windows/netuio/netuio_dev.c:161: + status = STATUS_NOT_SUPPORTED;$ ERROR:CODE_INDENT: code indent should use tabs where possible #672: FILE: windows/netuio/netuio_dev.c:162: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #672: FILE: windows/netuio/netuio_dev.c:162: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #673: FILE: windows/netuio/netuio_dev.c:163: + }$ WARNING:TYPO_SPELLING: 'implictly' may be misspelled - perhaps 'implicitly'? #675: FILE: windows/netuio/netuio_dev.c:165: + // Device type is implictly enforced by .inf WARNING:LEADING_SPACE: please, no spaces at the start of a line #675: FILE: windows/netuio/netuio_dev.c:165: + // Device type is implictly enforced by .inf$ ERROR:C99_COMMENTS: do not use C99 // comments #675: FILE: windows/netuio/netuio_dev.c:165: + // Device type is implictly enforced by .inf WARNING:LEADING_SPACE: please, no spaces at the start of a line #676: FILE: windows/netuio/netuio_dev.c:166: + ASSERT(PCI_CONFIGURATION_TYPE(&pci_config) == PCI_DEVICE_TYPE);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #678: FILE: windows/netuio/netuio_dev.c:168: + RtlZeroMemory(ctx->bar, sizeof(ctx->bar));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #679: FILE: windows/netuio/netuio_dev.c:169: + RtlZeroMemory(ctx->dpdk_hw, sizeof(ctx->dpdk_hw));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #681: FILE: windows/netuio/netuio_dev.c:171: + PCM_PARTIAL_RESOURCE_DESCRIPTOR descriptor;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #682: FILE: windows/netuio/netuio_dev.c:172: + ULONG next_descriptor = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #683: FILE: windows/netuio/netuio_dev.c:173: + ULONG curr_bar = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #684: FILE: windows/netuio/netuio_dev.c:174: + ULONG prev_bar = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #707: FILE: windows/netuio/netuio_dev.c:197: + for (INT bar_index = 0; bar_index < PCI_MAX_BAR; bar_index++) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #708: FILE: windows/netuio/netuio_dev.c:198: + prev_bar = curr_bar;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #708: FILE: windows/netuio/netuio_dev.c:198: + prev_bar = curr_bar;$ ERROR:CODE_INDENT: code indent should use tabs where possible #709: FILE: windows/netuio/netuio_dev.c:199: + curr_bar = pci_config.u.type0.BaseAddresses[bar_index];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #709: FILE: windows/netuio/netuio_dev.c:199: + curr_bar = pci_config.u.type0.BaseAddresses[bar_index];$ ERROR:CODE_INDENT: code indent should use tabs where possible #710: FILE: windows/netuio/netuio_dev.c:200: + if (curr_bar == 0 || (prev_bar & PCI_TYPE_64BIT)) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #710: FILE: windows/netuio/netuio_dev.c:200: + if (curr_bar == 0 || (prev_bar & PCI_TYPE_64BIT)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #710: FILE: windows/netuio/netuio_dev.c:200: + if (curr_bar == 0 || (prev_bar & PCI_TYPE_64BIT)) { + continue; WARNING:BRACES: braces {} are not necessary for single statement blocks #710: FILE: windows/netuio/netuio_dev.c:200: + if (curr_bar == 0 || (prev_bar & PCI_TYPE_64BIT)) { + continue; + } ERROR:CODE_INDENT: code indent should use tabs where possible #711: FILE: windows/netuio/netuio_dev.c:201: + continue;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #711: FILE: windows/netuio/netuio_dev.c:201: + continue;$ ERROR:CODE_INDENT: code indent should use tabs where possible #712: FILE: windows/netuio/netuio_dev.c:202: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #712: FILE: windows/netuio/netuio_dev.c:202: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #714: FILE: windows/netuio/netuio_dev.c:204: + // Find next CmResourceTypeMemory$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #714: FILE: windows/netuio/netuio_dev.c:204: + // Find next CmResourceTypeMemory$ ERROR:C99_COMMENTS: do not use C99 // comments #714: FILE: windows/netuio/netuio_dev.c:204: + // Find next CmResourceTypeMemory ERROR:CODE_INDENT: code indent should use tabs where possible #715: FILE: windows/netuio/netuio_dev.c:205: + do {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #715: FILE: windows/netuio/netuio_dev.c:205: + do {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #715: FILE: windows/netuio/netuio_dev.c:205: + do { + descriptor = WdfCmResourceListGetDescriptor(ResourcesTranslated, next_descriptor); ERROR:CODE_INDENT: code indent should use tabs where possible #716: FILE: windows/netuio/netuio_dev.c:206: + descriptor = WdfCmResourceListGetDescriptor(ResourcesTranslated, next_descriptor);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #716: FILE: windows/netuio/netuio_dev.c:206: + descriptor = WdfCmResourceListGetDescriptor(ResourcesTranslated, next_descriptor);$ ERROR:CODE_INDENT: code indent should use tabs where possible #717: FILE: windows/netuio/netuio_dev.c:207: + next_descriptor++;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #717: FILE: windows/netuio/netuio_dev.c:207: + next_descriptor++;$ ERROR:CODE_INDENT: code indent should use tabs where possible #719: FILE: windows/netuio/netuio_dev.c:209: + if (descriptor == NULL) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #719: FILE: windows/netuio/netuio_dev.c:209: + if (descriptor == NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #720: FILE: windows/netuio/netuio_dev.c:210: + status = STATUS_DEVICE_CONFIGURATION_ERROR;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #720: FILE: windows/netuio/netuio_dev.c:210: + status = STATUS_DEVICE_CONFIGURATION_ERROR;$ ERROR:CODE_INDENT: code indent should use tabs where possible #721: FILE: windows/netuio/netuio_dev.c:211: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #721: FILE: windows/netuio/netuio_dev.c:211: + goto end;$ ERROR:CODE_INDENT: code indent should use tabs where possible #722: FILE: windows/netuio/netuio_dev.c:212: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #722: FILE: windows/netuio/netuio_dev.c:212: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #723: FILE: windows/netuio/netuio_dev.c:213: + } while ((descriptor->Type != CmResourceTypeMemory) ||$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #723: FILE: windows/netuio/netuio_dev.c:213: + } while ((descriptor->Type != CmResourceTypeMemory) ||$ ERROR:CODE_INDENT: code indent should use tabs where possible #724: FILE: windows/netuio/netuio_dev.c:214: + !(descriptor->Flags & CM_RESOURCE_MEMORY_BAR));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #724: FILE: windows/netuio/netuio_dev.c:214: + !(descriptor->Flags & CM_RESOURCE_MEMORY_BAR));$ ERROR:CODE_INDENT: code indent should use tabs where possible #726: FILE: windows/netuio/netuio_dev.c:216: + // Retrieve and map the BARs$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #726: FILE: windows/netuio/netuio_dev.c:216: + // Retrieve and map the BARs$ ERROR:C99_COMMENTS: do not use C99 // comments #726: FILE: windows/netuio/netuio_dev.c:216: + // Retrieve and map the BARs ERROR:CODE_INDENT: code indent should use tabs where possible #727: FILE: windows/netuio/netuio_dev.c:217: + ctx->bar[bar_index].base_addr.QuadPart = descriptor->u.Memory.Start.QuadPart;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #727: FILE: windows/netuio/netuio_dev.c:217: + ctx->bar[bar_index].base_addr.QuadPart = descriptor->u.Memory.Start.QuadPart;$ ERROR:CODE_INDENT: code indent should use tabs where possible #728: FILE: windows/netuio/netuio_dev.c:218: + ctx->bar[bar_index].size = descriptor->u.Memory.Length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #728: FILE: windows/netuio/netuio_dev.c:218: + ctx->bar[bar_index].size = descriptor->u.Memory.Length;$ ERROR:CODE_INDENT: code indent should use tabs where possible #729: FILE: windows/netuio/netuio_dev.c:219: + ctx->bar[bar_index].virt_addr = MmMapIoSpace(descriptor->u.Memory.Start,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #729: FILE: windows/netuio/netuio_dev.c:219: + ctx->bar[bar_index].virt_addr = MmMapIoSpace(descriptor->u.Memory.Start,$ ERROR:CODE_INDENT: code indent should use tabs where possible #730: FILE: windows/netuio/netuio_dev.c:220: + descriptor->u.Memory.Length,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #730: FILE: windows/netuio/netuio_dev.c:220: + descriptor->u.Memory.Length,$ ERROR:CODE_INDENT: code indent should use tabs where possible #731: FILE: windows/netuio/netuio_dev.c:221: + MmNonCached);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #731: FILE: windows/netuio/netuio_dev.c:221: + MmNonCached);$ ERROR:CODE_INDENT: code indent should use tabs where possible #732: FILE: windows/netuio/netuio_dev.c:222: + if (ctx->bar[bar_index].virt_addr == NULL) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #732: FILE: windows/netuio/netuio_dev.c:222: + if (ctx->bar[bar_index].virt_addr == NULL) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #732: FILE: windows/netuio/netuio_dev.c:222: + if (ctx->bar[bar_index].virt_addr == NULL) { + status = STATUS_INSUFFICIENT_RESOURCES; ERROR:CODE_INDENT: code indent should use tabs where possible #733: FILE: windows/netuio/netuio_dev.c:223: + status = STATUS_INSUFFICIENT_RESOURCES;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #733: FILE: windows/netuio/netuio_dev.c:223: + status = STATUS_INSUFFICIENT_RESOURCES;$ ERROR:CODE_INDENT: code indent should use tabs where possible #734: FILE: windows/netuio/netuio_dev.c:224: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #734: FILE: windows/netuio/netuio_dev.c:224: + goto end;$ ERROR:CODE_INDENT: code indent should use tabs where possible #735: FILE: windows/netuio/netuio_dev.c:225: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #735: FILE: windows/netuio/netuio_dev.c:225: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #737: FILE: windows/netuio/netuio_dev.c:227: + // Allocate an MDL for the device BAR, so we can map it to the user's process context later.$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #737: FILE: windows/netuio/netuio_dev.c:227: + // Allocate an MDL for the device BAR, so we can map it to the user's process context later.$ ERROR:C99_COMMENTS: do not use C99 // comments #737: FILE: windows/netuio/netuio_dev.c:227: + // Allocate an MDL for the device BAR, so we can map it to the user's process context later. ERROR:CODE_INDENT: code indent should use tabs where possible #738: FILE: windows/netuio/netuio_dev.c:228: + ctx->dpdk_hw[bar_index].mdl = IoAllocateMdl(ctx->bar[bar_index].virt_addr,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #738: FILE: windows/netuio/netuio_dev.c:228: + ctx->dpdk_hw[bar_index].mdl = IoAllocateMdl(ctx->bar[bar_index].virt_addr,$ ERROR:CODE_INDENT: code indent should use tabs where possible #739: FILE: windows/netuio/netuio_dev.c:229: + (ULONG)ctx->bar[bar_index].size,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #739: FILE: windows/netuio/netuio_dev.c:229: + (ULONG)ctx->bar[bar_index].size,$ ERROR:CODE_INDENT: code indent should use tabs where possible #740: FILE: windows/netuio/netuio_dev.c:230: + FALSE,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #740: FILE: windows/netuio/netuio_dev.c:230: + FALSE,$ ERROR:CODE_INDENT: code indent should use tabs where possible #741: FILE: windows/netuio/netuio_dev.c:231: + FALSE,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #741: FILE: windows/netuio/netuio_dev.c:231: + FALSE,$ ERROR:CODE_INDENT: code indent should use tabs where possible #742: FILE: windows/netuio/netuio_dev.c:232: + NULL);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #742: FILE: windows/netuio/netuio_dev.c:232: + NULL);$ ERROR:CODE_INDENT: code indent should use tabs where possible #743: FILE: windows/netuio/netuio_dev.c:233: + if (!ctx->dpdk_hw[bar_index].mdl) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #743: FILE: windows/netuio/netuio_dev.c:233: + if (!ctx->dpdk_hw[bar_index].mdl) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #743: FILE: windows/netuio/netuio_dev.c:233: + if (!ctx->dpdk_hw[bar_index].mdl) { + status = STATUS_INSUFFICIENT_RESOURCES; ERROR:CODE_INDENT: code indent should use tabs where possible #744: FILE: windows/netuio/netuio_dev.c:234: + status = STATUS_INSUFFICIENT_RESOURCES;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #744: FILE: windows/netuio/netuio_dev.c:234: + status = STATUS_INSUFFICIENT_RESOURCES;$ ERROR:CODE_INDENT: code indent should use tabs where possible #745: FILE: windows/netuio/netuio_dev.c:235: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #745: FILE: windows/netuio/netuio_dev.c:235: + goto end;$ ERROR:CODE_INDENT: code indent should use tabs where possible #746: FILE: windows/netuio/netuio_dev.c:236: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #746: FILE: windows/netuio/netuio_dev.c:236: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #748: FILE: windows/netuio/netuio_dev.c:238: + ctx->dpdk_hw[bar_index].mem.size = ctx->bar[bar_index].size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #748: FILE: windows/netuio/netuio_dev.c:238: + ctx->dpdk_hw[bar_index].mem.size = ctx->bar[bar_index].size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #749: FILE: windows/netuio/netuio_dev.c:239: + } // for bar_index$ ERROR:C99_COMMENTS: do not use C99 // comments #749: FILE: windows/netuio/netuio_dev.c:239: + } // for bar_index WARNING:LEADING_SPACE: please, no spaces at the start of a line #751: FILE: windows/netuio/netuio_dev.c:241: + status = STATUS_SUCCESS;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #754: FILE: windows/netuio/netuio_dev.c:244: + if (status != STATUS_SUCCESS) {$ WARNING:BRACES: braces {} are not necessary for single statement blocks #754: FILE: windows/netuio/netuio_dev.c:244: + if (status != STATUS_SUCCESS) { + netuio_free_hw_resources(Device); + } ERROR:CODE_INDENT: code indent should use tabs where possible #755: FILE: windows/netuio/netuio_dev.c:245: + netuio_free_hw_resources(Device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #755: FILE: windows/netuio/netuio_dev.c:245: + netuio_free_hw_resources(Device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #756: FILE: windows/netuio/netuio_dev.c:246: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #758: FILE: windows/netuio/netuio_dev.c:248: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #765: FILE: windows/netuio/netuio_dev.c:255: + PNETUIO_CONTEXT_DATA ctx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #766: FILE: windows/netuio/netuio_dev.c:256: + ctx = netuio_get_context_data(Device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #768: FILE: windows/netuio/netuio_dev.c:258: + for (UINT8 bar_index = 0; bar_index < PCI_MAX_BAR; bar_index++) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #770: FILE: windows/netuio/netuio_dev.c:260: + // Free the allocated MDLs$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #770: FILE: windows/netuio/netuio_dev.c:260: + // Free the allocated MDLs$ ERROR:C99_COMMENTS: do not use C99 // comments #770: FILE: windows/netuio/netuio_dev.c:260: + // Free the allocated MDLs ERROR:CODE_INDENT: code indent should use tabs where possible #771: FILE: windows/netuio/netuio_dev.c:261: + if (ctx->dpdk_hw[bar_index].mdl) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #771: FILE: windows/netuio/netuio_dev.c:261: + if (ctx->dpdk_hw[bar_index].mdl) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #771: FILE: windows/netuio/netuio_dev.c:261: + if (ctx->dpdk_hw[bar_index].mdl) { + IoFreeMdl(ctx->dpdk_hw[bar_index].mdl); WARNING:BRACES: braces {} are not necessary for single statement blocks #771: FILE: windows/netuio/netuio_dev.c:261: + if (ctx->dpdk_hw[bar_index].mdl) { + IoFreeMdl(ctx->dpdk_hw[bar_index].mdl); + } ERROR:CODE_INDENT: code indent should use tabs where possible #772: FILE: windows/netuio/netuio_dev.c:262: + IoFreeMdl(ctx->dpdk_hw[bar_index].mdl);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #772: FILE: windows/netuio/netuio_dev.c:262: + IoFreeMdl(ctx->dpdk_hw[bar_index].mdl);$ ERROR:CODE_INDENT: code indent should use tabs where possible #773: FILE: windows/netuio/netuio_dev.c:263: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #773: FILE: windows/netuio/netuio_dev.c:263: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #775: FILE: windows/netuio/netuio_dev.c:265: + // Unmap all the BAR regions previously mapped$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #775: FILE: windows/netuio/netuio_dev.c:265: + // Unmap all the BAR regions previously mapped$ ERROR:C99_COMMENTS: do not use C99 // comments #775: FILE: windows/netuio/netuio_dev.c:265: + // Unmap all the BAR regions previously mapped ERROR:CODE_INDENT: code indent should use tabs where possible #776: FILE: windows/netuio/netuio_dev.c:266: + if (ctx->bar[bar_index].virt_addr) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #776: FILE: windows/netuio/netuio_dev.c:266: + if (ctx->bar[bar_index].virt_addr) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #776: FILE: windows/netuio/netuio_dev.c:266: + if (ctx->bar[bar_index].virt_addr) { + MmUnmapIoSpace(ctx->bar[bar_index].virt_addr, ctx->bar[bar_index].size); WARNING:BRACES: braces {} are not necessary for single statement blocks #776: FILE: windows/netuio/netuio_dev.c:266: + if (ctx->bar[bar_index].virt_addr) { + MmUnmapIoSpace(ctx->bar[bar_index].virt_addr, ctx->bar[bar_index].size); + } ERROR:CODE_INDENT: code indent should use tabs where possible #777: FILE: windows/netuio/netuio_dev.c:267: + MmUnmapIoSpace(ctx->bar[bar_index].virt_addr, ctx->bar[bar_index].size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #777: FILE: windows/netuio/netuio_dev.c:267: + MmUnmapIoSpace(ctx->bar[bar_index].virt_addr, ctx->bar[bar_index].size);$ ERROR:CODE_INDENT: code indent should use tabs where possible #778: FILE: windows/netuio/netuio_dev.c:268: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #778: FILE: windows/netuio/netuio_dev.c:268: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #779: FILE: windows/netuio/netuio_dev.c:269: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #781: FILE: windows/netuio/netuio_dev.c:271: + RtlZeroMemory(ctx->dpdk_hw, sizeof(ctx->dpdk_hw));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #782: FILE: windows/netuio/netuio_dev.c:272: + RtlZeroMemory(ctx->bar, sizeof(ctx->bar));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #800: FILE: windows/netuio/netuio_dev.h:11: + PHYSICAL_ADDRESS base_addr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #801: FILE: windows/netuio/netuio_dev.h:12: + PVOID virt_addr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #802: FILE: windows/netuio/netuio_dev.h:13: + UINT64 size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #806: FILE: windows/netuio/netuio_dev.h:17: + PMDL mdl; /**< MDL describing the memory region */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #807: FILE: windows/netuio/netuio_dev.h:18: + struct mem_region mem; /**< Memory region details */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #811: FILE: windows/netuio/netuio_dev.h:22: + ULONG bus_num;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #812: FILE: windows/netuio/netuio_dev.h:23: + USHORT dev_num;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #813: FILE: windows/netuio/netuio_dev.h:24: + USHORT func_num;$ ERROR:OPEN_BRACE: open brace '{' following struct go on the same line #820: FILE: windows/netuio/netuio_dev.h:31: +typedef struct _NETUIO_CONTEXT_DATA +{ WARNING:LEADING_SPACE: please, no spaces at the start of a line #821: FILE: windows/netuio/netuio_dev.h:32: + WDFDEVICE wdf_device; /**< WDF device handle to the FDO */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #822: FILE: windows/netuio/netuio_dev.h:33: + BUS_INTERFACE_STANDARD bus_interface; /**< Bus interface for config space access */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #823: FILE: windows/netuio/netuio_dev.h:34: + struct pci_bar bar[PCI_MAX_BAR]; /**< device BARs */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #824: FILE: windows/netuio/netuio_dev.h:35: + struct dev_addr addr; /**< B:D:F details of device */$ WARNING:LONG_LINE_COMMENT: line over 100 characters #825: FILE: windows/netuio/netuio_dev.h:36: + struct mem_map_region dpdk_hw[PCI_MAX_BAR]; /**< mapped region for the device's register space */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #825: FILE: windows/netuio/netuio_dev.h:36: + struct mem_map_region dpdk_hw[PCI_MAX_BAR]; /**< mapped region for the device's register space */$ ERROR:OPEN_BRACE: open brace '{' following struct go on the same line #837: FILE: windows/netuio/netuio_dev.h:48: +typedef struct +{ WARNING:LONG_LINE_COMMENT: line over 100 characters #838: FILE: windows/netuio/netuio_dev.h:49: + BOOLEAN bMapped; /**< value is set to TRUE if the User-mode mapping was done for this file object. */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #838: FILE: windows/netuio/netuio_dev.h:49: + BOOLEAN bMapped; /**< value is set to TRUE if the User-mode mapping was done for this file object. */$ ERROR:SPACING: space prohibited after that '*' (ctx:WxW) #839: FILE: windows/netuio/netuio_dev.h:50: +} NETUIO_FILE_CONTEXT_DATA, * PNETUIO_FILE_CONTEXT_DATA; ^ WARNING:TYPO_SPELLING: 'Inout' may be misspelled - perhaps 'Input'? #851: FILE: windows/netuio/netuio_dev.h:62: +NTSTATUS netuio_create_device(_Inout_ PWDFDEVICE_INIT DeviceInit); WARNING:LONG_LINE: line over 100 characters #852: FILE: windows/netuio/netuio_dev.h:63: +NTSTATUS netuio_map_hw_resources(_In_ WDFDEVICE Device, _In_ WDFCMRESLIST Resources, _In_ WDFCMRESLIST ResourcesTranslated); ERROR:C99_COMMENTS: do not use C99 // comments #855: FILE: windows/netuio/netuio_dev.h:66: +#endif // NETUIO_DEV_H WARNING:SPACING: space prohibited between function name and open parenthesis '(' #869: FILE: windows/netuio/netuio_drv.c:8: +#pragma alloc_text (INIT, DriverEntry) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #870: FILE: windows/netuio/netuio_drv.c:9: +#pragma alloc_text (PAGE, netuio_evt_device_add) WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #874: FILE: windows/netuio/netuio_drv.c:13: +/* +Routine Description: WARNING:LEADING_SPACE: please, no spaces at the start of a line #886: FILE: windows/netuio/netuio_drv.c:25: + WDF_DRIVER_CONFIG config;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #887: FILE: windows/netuio/netuio_drv.c:26: + NTSTATUS status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #888: FILE: windows/netuio/netuio_drv.c:27: + WDF_OBJECT_ATTRIBUTES attributes;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #890: FILE: windows/netuio/netuio_drv.c:29: + WDF_OBJECT_ATTRIBUTES_INIT(&attributes);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #891: FILE: windows/netuio/netuio_drv.c:30: + WDF_DRIVER_CONFIG_INIT(&config, netuio_evt_device_add);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #893: FILE: windows/netuio/netuio_drv.c:32: + status = WdfDriverCreate(DriverObject, RegistryPath,$ ERROR:CODE_INDENT: code indent should use tabs where possible #894: FILE: windows/netuio/netuio_drv.c:33: + &attributes, &config,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #894: FILE: windows/netuio/netuio_drv.c:33: + &attributes, &config,$ ERROR:CODE_INDENT: code indent should use tabs where possible #895: FILE: windows/netuio/netuio_drv.c:34: + WDF_NO_HANDLE);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #895: FILE: windows/netuio/netuio_drv.c:34: + WDF_NO_HANDLE);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #897: FILE: windows/netuio/netuio_drv.c:36: + if (!NT_SUCCESS(status)) {$ WARNING:BRACES: braces {} are not necessary for single statement blocks #897: FILE: windows/netuio/netuio_drv.c:36: + if (!NT_SUCCESS(status)) { + return status; + } ERROR:CODE_INDENT: code indent should use tabs where possible #898: FILE: windows/netuio/netuio_drv.c:37: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #898: FILE: windows/netuio/netuio_drv.c:37: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #899: FILE: windows/netuio/netuio_drv.c:38: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #901: FILE: windows/netuio/netuio_drv.c:40: + return status;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #905: FILE: windows/netuio/netuio_drv.c:44: +/* +Routine Description: WARNING:LEADING_SPACE: please, no spaces at the start of a line #917: FILE: windows/netuio/netuio_drv.c:56: + UNREFERENCED_PARAMETER(Driver);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #918: FILE: windows/netuio/netuio_drv.c:57: + return netuio_create_device(DeviceInit);$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #922: FILE: windows/netuio/netuio_drv.c:61: +/* +Routine Description : WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #928: FILE: windows/netuio/netuio_drv.c:67: +-*/ WARNING:LEADING_SPACE: please, no spaces at the start of a line #933: FILE: windows/netuio/netuio_drv.c:72: + NTSTATUS status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #935: FILE: windows/netuio/netuio_drv.c:74: + status = netuio_map_hw_resources(Device, Resources, ResourcesTranslated);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #936: FILE: windows/netuio/netuio_drv.c:75: + if (!NT_SUCCESS(status)) {$ WARNING:BRACES: braces {} are not necessary for single statement blocks #936: FILE: windows/netuio/netuio_drv.c:75: + if (!NT_SUCCESS(status)) { + return status; + } ERROR:CODE_INDENT: code indent should use tabs where possible #937: FILE: windows/netuio/netuio_drv.c:76: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #937: FILE: windows/netuio/netuio_drv.c:76: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #938: FILE: windows/netuio/netuio_drv.c:77: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #940: FILE: windows/netuio/netuio_drv.c:79: + PNETUIO_CONTEXT_DATA ctx = netuio_get_context_data(Device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #941: FILE: windows/netuio/netuio_drv.c:80: + DbgPrintEx(DPFLTR_IHVNETWORK_ID, DPFLTR_NETUIO_INFO_LEVEL, "netUIO Driver loaded...on device (B:D:F) %04d:%02d:%02d ",$ ERROR:CODE_INDENT: code indent should use tabs where possible #942: FILE: windows/netuio/netuio_drv.c:81: + ctx->addr.bus_num, ctx->addr.dev_num, ctx->addr.func_num);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #942: FILE: windows/netuio/netuio_drv.c:81: + ctx->addr.bus_num, ctx->addr.dev_num, ctx->addr.func_num);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #944: FILE: windows/netuio/netuio_drv.c:83: + return status;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #948: FILE: windows/netuio/netuio_drv.c:87: +/* +Routine Description : WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #953: FILE: windows/netuio/netuio_drv.c:92: +-*/ WARNING:LEADING_SPACE: please, no spaces at the start of a line #958: FILE: windows/netuio/netuio_drv.c:97: + UNREFERENCED_PARAMETER(ResourcesTranslated);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #960: FILE: windows/netuio/netuio_drv.c:99: + netuio_free_hw_resources(Device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #962: FILE: windows/netuio/netuio_drv.c:101: + return STATUS_SUCCESS;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #966: FILE: windows/netuio/netuio_drv.c:105: +/* +Routine Description : WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #973: FILE: windows/netuio/netuio_drv.c:112: +-*/ WARNING:LEADING_SPACE: please, no spaces at the start of a line #978: FILE: windows/netuio/netuio_drv.c:117: + PNETUIO_FILE_CONTEXT_DATA file_ctx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #980: FILE: windows/netuio/netuio_drv.c:119: + file_ctx = netuio_get_file_object_context_data(FileObject);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #982: FILE: windows/netuio/netuio_drv.c:121: + if (file_ctx->bMapped == TRUE)$ ERROR:OPEN_BRACE: that open brace { should be on the previous line #982: FILE: windows/netuio/netuio_drv.c:121: + if (file_ctx->bMapped == TRUE) + { WARNING:LEADING_SPACE: please, no spaces at the start of a line #983: FILE: windows/netuio/netuio_drv.c:122: + {$ ERROR:CODE_INDENT: code indent should use tabs where possible #984: FILE: windows/netuio/netuio_drv.c:123: + WDFDEVICE device;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #984: FILE: windows/netuio/netuio_drv.c:123: + WDFDEVICE device;$ ERROR:CODE_INDENT: code indent should use tabs where possible #985: FILE: windows/netuio/netuio_drv.c:124: + PNETUIO_CONTEXT_DATA ctx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #985: FILE: windows/netuio/netuio_drv.c:124: + PNETUIO_CONTEXT_DATA ctx;$ ERROR:CODE_INDENT: code indent should use tabs where possible #987: FILE: windows/netuio/netuio_drv.c:126: + device = WdfFileObjectGetDevice(FileObject);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #987: FILE: windows/netuio/netuio_drv.c:126: + device = WdfFileObjectGetDevice(FileObject);$ ERROR:CODE_INDENT: code indent should use tabs where possible #988: FILE: windows/netuio/netuio_drv.c:127: + ctx = netuio_get_context_data(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #988: FILE: windows/netuio/netuio_drv.c:127: + ctx = netuio_get_context_data(device);$ ERROR:CODE_INDENT: code indent should use tabs where possible #989: FILE: windows/netuio/netuio_drv.c:128: + netuio_unmap_address_from_user_process(ctx);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #989: FILE: windows/netuio/netuio_drv.c:128: + netuio_unmap_address_from_user_process(ctx);$ ERROR:CODE_INDENT: code indent should use tabs where possible #990: FILE: windows/netuio/netuio_drv.c:129: + file_ctx->bMapped = FALSE;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #990: FILE: windows/netuio/netuio_drv.c:129: + file_ctx->bMapped = FALSE;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #991: FILE: windows/netuio/netuio_drv.c:130: + }$ ERROR:C99_COMMENTS: do not use C99 // comments #1028: FILE: windows/netuio/netuio_drv.h:30: +#endif // NETUIO_DRV_H WARNING:LONG_LINE: line over 100 characters #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ERROR:C99_COMMENTS: do not use C99 // comments #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ERROR:SPACING: space required after that ',' (ctx:VxV) #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ ERROR:SPACING: space required after that ',' (ctx:VxV) #1055: FILE: windows/netuio/netuio_interface.h:21: +DEFINE_GUID (GUID_DEVINTERFACE_netUIO, 0x08336f60,0x0679,0x4c6c,0x85,0xd2,0xae,0x7c,0xed,0x65,0xff,0xf7); // {08336f60-0679-4c6c-85d2-ae7ced65fff7} ^ WARNING:LONG_LINE: line over 100 characters #1068: FILE: windows/netuio/netuio_interface.h:34: +#define IOCTL_NETUIO_MAP_HW_INTO_USERMODE CTL_CODE(FILE_DEVICE_NETWORK, 51, METHOD_BUFFERED, FILE_READ_ACCESS | FILE_WRITE_ACCESS) WARNING:LONG_LINE: line over 100 characters #1085: FILE: windows/netuio/netuio_interface.h:51: +#define IOCTL_NETUIO_PCI_CONFIG_IO CTL_CODE(FILE_DEVICE_NETWORK, 52, METHOD_BUFFERED, FILE_READ_ACCESS | FILE_WRITE_ACCESS) WARNING:LEADING_SPACE: please, no spaces at the start of a line #1088: FILE: windows/netuio/netuio_interface.h:54: + UINT64 size; /**< memory region size */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1089: FILE: windows/netuio/netuio_interface.h:55: + LARGE_INTEGER phys_addr; /**< physical address of the memory region */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1090: FILE: windows/netuio/netuio_interface.h:56: + PVOID virt_addr; /**< virtual address of the memory region */$ WARNING:LONG_LINE_COMMENT: line over 100 characters #1091: FILE: windows/netuio/netuio_interface.h:57: + PVOID user_mapped_virt_addr; /**< virtual address of the region mapped into user process context */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1091: FILE: windows/netuio/netuio_interface.h:57: + PVOID user_mapped_virt_addr; /**< virtual address of the region mapped into user process context */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1095: FILE: windows/netuio/netuio_interface.h:61: + PCI_IO_READ = 0,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1096: FILE: windows/netuio/netuio_interface.h:62: + PCI_IO_WRITE = 1$ ERROR:OPEN_BRACE: open brace '{' following struct go on the same line #1102: FILE: windows/netuio/netuio_interface.h:68: +struct device_info +{ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1103: FILE: windows/netuio/netuio_interface.h:69: + struct mem_region hw[PCI_MAX_BAR];$ ERROR:OPEN_BRACE: open brace '{' following struct go on the same line #1107: FILE: windows/netuio/netuio_interface.h:73: +struct dpdk_pci_config_io +{ WARNING:LONG_LINE_COMMENT: line over 100 characters #1108: FILE: windows/netuio/netuio_interface.h:74: + UINT32 offset; /**< offset into the device config space where the reading/writing starts */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1108: FILE: windows/netuio/netuio_interface.h:74: + UINT32 offset; /**< offset into the device config space where the reading/writing starts */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1109: FILE: windows/netuio/netuio_interface.h:75: + UINT8 op; /**< operation type: read or write */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1110: FILE: windows/netuio/netuio_interface.h:76: + UINT32 access_size; /**< 1, 2, 4, or 8 bytes */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1112: FILE: windows/netuio/netuio_interface.h:78: + union dpdk_pci_config_io_data {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1113: FILE: windows/netuio/netuio_interface.h:79: + UINT8^I^I^Iu8;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1113: FILE: windows/netuio/netuio_interface.h:79: + UINT8^I^I^Iu8;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1114: FILE: windows/netuio/netuio_interface.h:80: + UINT16^I^I^Iu16;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1114: FILE: windows/netuio/netuio_interface.h:80: + UINT16^I^I^Iu16;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1115: FILE: windows/netuio/netuio_interface.h:81: + UINT32^I^I^Iu32;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1115: FILE: windows/netuio/netuio_interface.h:81: + UINT32^I^I^Iu32;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1116: FILE: windows/netuio/netuio_interface.h:82: + UINT64^I^I^Iu64;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1116: FILE: windows/netuio/netuio_interface.h:82: + UINT64^I^I^Iu64;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1117: FILE: windows/netuio/netuio_interface.h:83: + } data; /**< Data to be written, in case of write operations */$ ERROR:C99_COMMENTS: do not use C99 // comments #1122: FILE: windows/netuio/netuio_interface.h:88: +#endif // NETUIO_INTERFACE_H WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1136: FILE: windows/netuio/netuio_queue.c:8: +#pragma alloc_text (PAGE, netuio_queue_initialize) WARNING:LEADING_SPACE: please, no spaces at the start of a line #1143: FILE: windows/netuio/netuio_queue.c:15: + WDFFILEOBJECT file_object;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1145: FILE: windows/netuio/netuio_queue.c:17: + file_object = WdfRequestGetFileObject(Request);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1146: FILE: windows/netuio/netuio_queue.c:18: + if (file_object == NULL)$ ERROR:OPEN_BRACE: that open brace { should be on the previous line #1146: FILE: windows/netuio/netuio_queue.c:18: + if (file_object == NULL) + { WARNING:LEADING_SPACE: please, no spaces at the start of a line #1147: FILE: windows/netuio/netuio_queue.c:19: + {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1148: FILE: windows/netuio/netuio_queue.c:20: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1148: FILE: windows/netuio/netuio_queue.c:20: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1149: FILE: windows/netuio/netuio_queue.c:21: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1151: FILE: windows/netuio/netuio_queue.c:23: + PNETUIO_FILE_CONTEXT_DATA file_ctx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1153: FILE: windows/netuio/netuio_queue.c:25: + file_ctx = netuio_get_file_object_context_data(file_object);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1154: FILE: windows/netuio/netuio_queue.c:26: + if (file_ctx->bMapped)$ ERROR:OPEN_BRACE: that open brace { should be on the previous line #1154: FILE: windows/netuio/netuio_queue.c:26: + if (file_ctx->bMapped) + { WARNING:LEADING_SPACE: please, no spaces at the start of a line #1155: FILE: windows/netuio/netuio_queue.c:27: + {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1156: FILE: windows/netuio/netuio_queue.c:28: + return TRUE;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1156: FILE: windows/netuio/netuio_queue.c:28: + return TRUE;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1157: FILE: windows/netuio/netuio_queue.c:29: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1160: FILE: windows/netuio/netuio_queue.c:32: + return FALSE;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1167: FILE: windows/netuio/netuio_queue.c:39: + WDFFILEOBJECT file_object;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1169: FILE: windows/netuio/netuio_queue.c:41: + file_object = WdfRequestGetFileObject(Request);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1170: FILE: windows/netuio/netuio_queue.c:42: + if (file_object == NULL)$ ERROR:OPEN_BRACE: that open brace { should be on the previous line #1170: FILE: windows/netuio/netuio_queue.c:42: + if (file_object == NULL) + { WARNING:LEADING_SPACE: please, no spaces at the start of a line #1171: FILE: windows/netuio/netuio_queue.c:43: + {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1172: FILE: windows/netuio/netuio_queue.c:44: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1172: FILE: windows/netuio/netuio_queue.c:44: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1173: FILE: windows/netuio/netuio_queue.c:45: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1175: FILE: windows/netuio/netuio_queue.c:47: + PNETUIO_FILE_CONTEXT_DATA file_ctx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1177: FILE: windows/netuio/netuio_queue.c:49: + file_ctx = netuio_get_file_object_context_data(file_object);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1179: FILE: windows/netuio/netuio_queue.c:51: + file_ctx->bMapped = TRUE;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1184: FILE: windows/netuio/netuio_queue.c:56: + _In_ PVOID outputBuf, _In_ size_t outputBufSize)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1184: FILE: windows/netuio/netuio_queue.c:56: + _In_ PVOID outputBuf, _In_ size_t outputBufSize)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1186: FILE: windows/netuio/netuio_queue.c:58: + ASSERT(outputBufSize == sizeof(struct device_info));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1188: FILE: windows/netuio/netuio_queue.c:60: + struct device_info *dpdk_pvt_info = (struct device_info *)outputBuf;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1189: FILE: windows/netuio/netuio_queue.c:61: + RtlZeroMemory(dpdk_pvt_info, outputBufSize);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1191: FILE: windows/netuio/netuio_queue.c:63: + for (ULONG idx = 0; idx < PCI_MAX_BAR; idx++) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1192: FILE: windows/netuio/netuio_queue.c:64: + dpdk_pvt_info->hw[idx].phys_addr.QuadPart = ctx->bar[idx].base_addr.QuadPart;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1192: FILE: windows/netuio/netuio_queue.c:64: + dpdk_pvt_info->hw[idx].phys_addr.QuadPart = ctx->bar[idx].base_addr.QuadPart;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1193: FILE: windows/netuio/netuio_queue.c:65: + dpdk_pvt_info->hw[idx].user_mapped_virt_addr = ctx->dpdk_hw[idx].mem.user_mapped_virt_addr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1193: FILE: windows/netuio/netuio_queue.c:65: + dpdk_pvt_info->hw[idx].user_mapped_virt_addr = ctx->dpdk_hw[idx].mem.user_mapped_virt_addr;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1194: FILE: windows/netuio/netuio_queue.c:66: + dpdk_pvt_info->hw[idx].size = ctx->bar[idx].size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1194: FILE: windows/netuio/netuio_queue.c:66: + dpdk_pvt_info->hw[idx].size = ctx->bar[idx].size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1195: FILE: windows/netuio/netuio_queue.c:67: + }$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #1199: FILE: windows/netuio/netuio_queue.c:71: +/* +Routine Description: WARNING:TYPO_SPELLING: 'process'' may be misspelled - perhaps 'process's'? #1200: FILE: windows/netuio/netuio_queue.c:72: + Maps address ranges into the usermode process's address space. The following ERROR:CODE_INDENT: code indent should use tabs where possible #1203: FILE: windows/netuio/netuio_queue.c:75: + * Any PCI BARs that our device was assigned$ ERROR:CODE_INDENT: code indent should use tabs where possible #1204: FILE: windows/netuio/netuio_queue.c:76: + * The scratch buffer of contiguous pages$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1212: FILE: windows/netuio/netuio_queue.c:84: + NTSTATUS status = STATUS_SUCCESS;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1214: FILE: windows/netuio/netuio_queue.c:86: + if (netuio_get_usermode_mapping_flag(Request))$ ERROR:OPEN_BRACE: that open brace { should be on the previous line #1214: FILE: windows/netuio/netuio_queue.c:86: + if (netuio_get_usermode_mapping_flag(Request)) + { WARNING:LEADING_SPACE: please, no spaces at the start of a line #1215: FILE: windows/netuio/netuio_queue.c:87: + {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1216: FILE: windows/netuio/netuio_queue.c:88: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1216: FILE: windows/netuio/netuio_queue.c:88: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1217: FILE: windows/netuio/netuio_queue.c:89: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1219: FILE: windows/netuio/netuio_queue.c:91: + // Map any device BAR(s) to the user's process context$ ERROR:C99_COMMENTS: do not use C99 // comments #1219: FILE: windows/netuio/netuio_queue.c:91: + // Map any device BAR(s) to the user's process context WARNING:LEADING_SPACE: please, no spaces at the start of a line #1220: FILE: windows/netuio/netuio_queue.c:92: + for (INT idx = 0; idx < PCI_MAX_BAR; idx++) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1221: FILE: windows/netuio/netuio_queue.c:93: + if (ctx->dpdk_hw[idx].mdl == NULL) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1221: FILE: windows/netuio/netuio_queue.c:93: + if (ctx->dpdk_hw[idx].mdl == NULL) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1221: FILE: windows/netuio/netuio_queue.c:93: + if (ctx->dpdk_hw[idx].mdl == NULL) { + continue; WARNING:BRACES: braces {} are not necessary for single statement blocks #1221: FILE: windows/netuio/netuio_queue.c:93: + if (ctx->dpdk_hw[idx].mdl == NULL) { + continue; + } ERROR:CODE_INDENT: code indent should use tabs where possible #1222: FILE: windows/netuio/netuio_queue.c:94: + continue;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1222: FILE: windows/netuio/netuio_queue.c:94: + continue;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1223: FILE: windows/netuio/netuio_queue.c:95: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1223: FILE: windows/netuio/netuio_queue.c:95: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1225: FILE: windows/netuio/netuio_queue.c:97: + MmBuildMdlForNonPagedPool(ctx->dpdk_hw[idx].mdl);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1225: FILE: windows/netuio/netuio_queue.c:97: + MmBuildMdlForNonPagedPool(ctx->dpdk_hw[idx].mdl);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1226: FILE: windows/netuio/netuio_queue.c:98: + __try {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1226: FILE: windows/netuio/netuio_queue.c:98: + __try {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1227: FILE: windows/netuio/netuio_queue.c:99: + ctx->dpdk_hw[idx].mem.user_mapped_virt_addr =$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1227: FILE: windows/netuio/netuio_queue.c:99: + ctx->dpdk_hw[idx].mem.user_mapped_virt_addr =$ ERROR:CODE_INDENT: code indent should use tabs where possible #1228: FILE: windows/netuio/netuio_queue.c:100: + MmMapLockedPagesSpecifyCache(ctx->dpdk_hw[idx].mdl, UserMode,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1228: FILE: windows/netuio/netuio_queue.c:100: + MmMapLockedPagesSpecifyCache(ctx->dpdk_hw[idx].mdl, UserMode,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1229: FILE: windows/netuio/netuio_queue.c:101: + MmCached, NULL, FALSE, NormalPagePriority);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1229: FILE: windows/netuio/netuio_queue.c:101: + MmCached, NULL, FALSE, NormalPagePriority);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1231: FILE: windows/netuio/netuio_queue.c:103: + if (ctx->dpdk_hw[idx].mem.user_mapped_virt_addr == NULL) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1231: FILE: windows/netuio/netuio_queue.c:103: + if (ctx->dpdk_hw[idx].mem.user_mapped_virt_addr == NULL) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1232: FILE: windows/netuio/netuio_queue.c:104: + status = STATUS_INSUFFICIENT_RESOURCES;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1232: FILE: windows/netuio/netuio_queue.c:104: + status = STATUS_INSUFFICIENT_RESOURCES;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1233: FILE: windows/netuio/netuio_queue.c:105: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1233: FILE: windows/netuio/netuio_queue.c:105: + goto end;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1234: FILE: windows/netuio/netuio_queue.c:106: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1234: FILE: windows/netuio/netuio_queue.c:106: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1235: FILE: windows/netuio/netuio_queue.c:107: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1235: FILE: windows/netuio/netuio_queue.c:107: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1236: FILE: windows/netuio/netuio_queue.c:108: + __except (EXCEPTION_EXECUTE_HANDLER) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1236: FILE: windows/netuio/netuio_queue.c:108: + __except (EXCEPTION_EXECUTE_HANDLER) {$ WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1236: FILE: windows/netuio/netuio_queue.c:108: + __except (EXCEPTION_EXECUTE_HANDLER) { ERROR:CODE_INDENT: code indent should use tabs where possible #1237: FILE: windows/netuio/netuio_queue.c:109: + status = GetExceptionCode();$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1237: FILE: windows/netuio/netuio_queue.c:109: + status = GetExceptionCode();$ ERROR:CODE_INDENT: code indent should use tabs where possible #1238: FILE: windows/netuio/netuio_queue.c:110: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1238: FILE: windows/netuio/netuio_queue.c:110: + goto end;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1239: FILE: windows/netuio/netuio_queue.c:111: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1239: FILE: windows/netuio/netuio_queue.c:111: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1240: FILE: windows/netuio/netuio_queue.c:112: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1243: FILE: windows/netuio/netuio_queue.c:115: + if (status != STATUS_SUCCESS) {$ WARNING:BRACES: braces {} are not necessary for single statement blocks #1243: FILE: windows/netuio/netuio_queue.c:115: + if (status != STATUS_SUCCESS) { + netuio_unmap_address_from_user_process(ctx); + } ERROR:CODE_INDENT: code indent should use tabs where possible #1244: FILE: windows/netuio/netuio_queue.c:116: + netuio_unmap_address_from_user_process(ctx);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1244: FILE: windows/netuio/netuio_queue.c:116: + netuio_unmap_address_from_user_process(ctx);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1245: FILE: windows/netuio/netuio_queue.c:117: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1247: FILE: windows/netuio/netuio_queue.c:119: + return status;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #1251: FILE: windows/netuio/netuio_queue.c:123: +/* +Routine Description: WARNING:LEADING_SPACE: please, no spaces at the start of a line #1263: FILE: windows/netuio/netuio_queue.c:135: + for (INT idx = 0; idx < PCI_MAX_BAR; idx++) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1264: FILE: windows/netuio/netuio_queue.c:136: + if (ctx->dpdk_hw[idx].mem.user_mapped_virt_addr != NULL) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1264: FILE: windows/netuio/netuio_queue.c:136: + if (ctx->dpdk_hw[idx].mem.user_mapped_virt_addr != NULL) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1264: FILE: windows/netuio/netuio_queue.c:136: + if (ctx->dpdk_hw[idx].mem.user_mapped_virt_addr != NULL) { + MmUnmapLockedPages(ctx->dpdk_hw[idx].mem.user_mapped_virt_addr, ERROR:CODE_INDENT: code indent should use tabs where possible #1265: FILE: windows/netuio/netuio_queue.c:137: + MmUnmapLockedPages(ctx->dpdk_hw[idx].mem.user_mapped_virt_addr,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1265: FILE: windows/netuio/netuio_queue.c:137: + MmUnmapLockedPages(ctx->dpdk_hw[idx].mem.user_mapped_virt_addr,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1266: FILE: windows/netuio/netuio_queue.c:138: + ctx->dpdk_hw[idx].mdl);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1266: FILE: windows/netuio/netuio_queue.c:138: + ctx->dpdk_hw[idx].mdl);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1268: FILE: windows/netuio/netuio_queue.c:140: + ctx->dpdk_hw[idx].mem.user_mapped_virt_addr = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1268: FILE: windows/netuio/netuio_queue.c:140: + ctx->dpdk_hw[idx].mem.user_mapped_virt_addr = NULL;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1269: FILE: windows/netuio/netuio_queue.c:141: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1269: FILE: windows/netuio/netuio_queue.c:141: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1270: FILE: windows/netuio/netuio_queue.c:142: + }$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #1274: FILE: windows/netuio/netuio_queue.c:146: +/* +Routine Description: WARNING:LEADING_SPACE: please, no spaces at the start of a line #1286: FILE: windows/netuio/netuio_queue.c:158: + WDFQUEUE queue;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1287: FILE: windows/netuio/netuio_queue.c:159: + NTSTATUS status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1288: FILE: windows/netuio/netuio_queue.c:160: + WDF_IO_QUEUE_CONFIG queueConfig;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1290: FILE: windows/netuio/netuio_queue.c:162: + PAGED_CODE();$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1292: FILE: windows/netuio/netuio_queue.c:164: + // Configure a default queue so that requests that are not$ ERROR:C99_COMMENTS: do not use C99 // comments #1292: FILE: windows/netuio/netuio_queue.c:164: + // Configure a default queue so that requests that are not WARNING:TYPO_SPELLING: 'fowarded' may be misspelled - perhaps 'forwarded'? #1293: FILE: windows/netuio/netuio_queue.c:165: + // configure-fowarded using WdfDeviceConfigureRequestDispatching to goto WARNING:LEADING_SPACE: please, no spaces at the start of a line #1293: FILE: windows/netuio/netuio_queue.c:165: + // configure-fowarded using WdfDeviceConfigureRequestDispatching to goto$ ERROR:C99_COMMENTS: do not use C99 // comments #1293: FILE: windows/netuio/netuio_queue.c:165: + // configure-fowarded using WdfDeviceConfigureRequestDispatching to goto WARNING:LEADING_SPACE: please, no spaces at the start of a line #1294: FILE: windows/netuio/netuio_queue.c:166: + // other queues get dispatched here.$ ERROR:C99_COMMENTS: do not use C99 // comments #1294: FILE: windows/netuio/netuio_queue.c:166: + // other queues get dispatched here. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1295: FILE: windows/netuio/netuio_queue.c:167: + WDF_IO_QUEUE_CONFIG_INIT_DEFAULT_QUEUE(&queueConfig, WdfIoQueueDispatchParallel);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1297: FILE: windows/netuio/netuio_queue.c:169: + queueConfig.EvtIoDeviceControl = netuio_evt_IO_device_control;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1299: FILE: windows/netuio/netuio_queue.c:171: + status = WdfIoQueueCreate(Device,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1300: FILE: windows/netuio/netuio_queue.c:172: + &queueConfig,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1300: FILE: windows/netuio/netuio_queue.c:172: + &queueConfig,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1301: FILE: windows/netuio/netuio_queue.c:173: + WDF_NO_OBJECT_ATTRIBUTES,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1301: FILE: windows/netuio/netuio_queue.c:173: + WDF_NO_OBJECT_ATTRIBUTES,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1302: FILE: windows/netuio/netuio_queue.c:174: + &queue);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1302: FILE: windows/netuio/netuio_queue.c:174: + &queue);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1304: FILE: windows/netuio/netuio_queue.c:176: + if( !NT_SUCCESS(status) ) {$ ERROR:SPACING: space prohibited after that open parenthesis '(' #1304: FILE: windows/netuio/netuio_queue.c:176: + if( !NT_SUCCESS(status) ) { ERROR:SPACING: space prohibited before that close parenthesis ')' #1304: FILE: windows/netuio/netuio_queue.c:176: + if( !NT_SUCCESS(status) ) { ERROR:SPACING: space required before the open parenthesis '(' #1304: FILE: windows/netuio/netuio_queue.c:176: + if( !NT_SUCCESS(status) ) { WARNING:BRACES: braces {} are not necessary for single statement blocks #1304: FILE: windows/netuio/netuio_queue.c:176: + if( !NT_SUCCESS(status) ) { + return status; + } ERROR:CODE_INDENT: code indent should use tabs where possible #1305: FILE: windows/netuio/netuio_queue.c:177: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1305: FILE: windows/netuio/netuio_queue.c:177: + return status;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1306: FILE: windows/netuio/netuio_queue.c:178: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1308: FILE: windows/netuio/netuio_queue.c:180: + return status;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #1312: FILE: windows/netuio/netuio_queue.c:184: +/* +Routine Description: ERROR:CODE_INDENT: code indent should use tabs where possible #1322: FILE: windows/netuio/netuio_queue.c:194: + WDFREQUEST Request)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1322: FILE: windows/netuio/netuio_queue.c:194: + WDFREQUEST Request)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1324: FILE: windows/netuio/netuio_queue.c:196: + WDF_REQUEST_PARAMETERS params = { 0 };$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1325: FILE: windows/netuio/netuio_queue.c:197: + NTSTATUS status = STATUS_SUCCESS;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1326: FILE: windows/netuio/netuio_queue.c:198: + PVOID output_buf = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1327: FILE: windows/netuio/netuio_queue.c:199: + size_t output_buf_size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1328: FILE: windows/netuio/netuio_queue.c:200: + size_t bytes_returned = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1329: FILE: windows/netuio/netuio_queue.c:201: + PNETUIO_CONTEXT_DATA ctx = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1331: FILE: windows/netuio/netuio_queue.c:203: + ctx = netuio_get_context_data(Device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1333: FILE: windows/netuio/netuio_queue.c:205: + WDF_REQUEST_PARAMETERS_INIT(¶ms);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1334: FILE: windows/netuio/netuio_queue.c:206: + WdfRequestGetParameters(Request, ¶ms);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1336: FILE: windows/netuio/netuio_queue.c:208: + if (params.Type != WdfRequestTypeDeviceControl)$ ERROR:OPEN_BRACE: that open brace { should be on the previous line #1336: FILE: windows/netuio/netuio_queue.c:208: + if (params.Type != WdfRequestTypeDeviceControl) + { WARNING:LEADING_SPACE: please, no spaces at the start of a line #1337: FILE: windows/netuio/netuio_queue.c:209: + {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1338: FILE: windows/netuio/netuio_queue.c:210: + status = STATUS_INVALID_DEVICE_REQUEST;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1338: FILE: windows/netuio/netuio_queue.c:210: + status = STATUS_INVALID_DEVICE_REQUEST;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1339: FILE: windows/netuio/netuio_queue.c:211: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1339: FILE: windows/netuio/netuio_queue.c:211: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1340: FILE: windows/netuio/netuio_queue.c:212: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1342: FILE: windows/netuio/netuio_queue.c:214: + // We only need to be in the context of the process that initiated the request$ ERROR:C99_COMMENTS: do not use C99 // comments #1342: FILE: windows/netuio/netuio_queue.c:214: + // We only need to be in the context of the process that initiated the request WARNING:LEADING_SPACE: please, no spaces at the start of a line #1343: FILE: windows/netuio/netuio_queue.c:215: + //when we need to map memory to userspace. Otherwise, send the request back to framework.$ ERROR:C99_COMMENTS: do not use C99 // comments #1343: FILE: windows/netuio/netuio_queue.c:215: + //when we need to map memory to userspace. Otherwise, send the request back to framework. WARNING:LEADING_SPACE: please, no spaces at the start of a line #1344: FILE: windows/netuio/netuio_queue.c:216: + if (params.Parameters.DeviceIoControl.IoControlCode != IOCTL_NETUIO_MAP_HW_INTO_USERMODE)$ ERROR:OPEN_BRACE: that open brace { should be on the previous line #1344: FILE: windows/netuio/netuio_queue.c:216: + if (params.Parameters.DeviceIoControl.IoControlCode != IOCTL_NETUIO_MAP_HW_INTO_USERMODE) + { WARNING:LEADING_SPACE: please, no spaces at the start of a line #1345: FILE: windows/netuio/netuio_queue.c:217: + {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1346: FILE: windows/netuio/netuio_queue.c:218: + status = WdfDeviceEnqueueRequest(Device, Request);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1346: FILE: windows/netuio/netuio_queue.c:218: + status = WdfDeviceEnqueueRequest(Device, Request);$ ERROR:CODE_INDENT: code indent should use tabs where possible #1347: FILE: windows/netuio/netuio_queue.c:219: + if (!NT_SUCCESS(status))$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1347: FILE: windows/netuio/netuio_queue.c:219: + if (!NT_SUCCESS(status))$ ERROR:OPEN_BRACE: that open brace { should be on the previous line #1347: FILE: windows/netuio/netuio_queue.c:219: + if (!NT_SUCCESS(status)) + { WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #1347: FILE: windows/netuio/netuio_queue.c:219: + if (!NT_SUCCESS(status)) + { ERROR:CODE_INDENT: code indent should use tabs where possible #1348: FILE: windows/netuio/netuio_queue.c:220: + {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1348: FILE: windows/netuio/netuio_queue.c:220: + {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1349: FILE: windows/netuio/netuio_queue.c:221: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1349: FILE: windows/netuio/netuio_queue.c:221: + goto end;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1350: FILE: windows/netuio/netuio_queue.c:222: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1350: FILE: windows/netuio/netuio_queue.c:222: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #1351: FILE: windows/netuio/netuio_queue.c:223: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1351: FILE: windows/netuio/netuio_queue.c:223: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1352: FILE: windows/netuio/netuio_queue.c:224: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1354: FILE: windows/netuio/netuio_queue.c:226: + // Return relevant data to the caller$ ERROR:C99_COMMENTS: do not use C99 // comments #1354: FILE: windows/netuio/netuio_queue.c:226: + // Return relevant data to the caller WARNING:LONG_LINE: line over 100 characters #1355: FILE: windows/netuio/netuio_queue.c:227: + status = WdfRequestRetrieveOutputBuffer(Request, sizeof(struct device_info), &output_buf, &output_buf_size); WARNING:LEADING_SPACE: please, no spaces at the start of a line #1355: FILE: windows/netuio/netuio_queue.c:227: + status = WdfRequestRetrieveOutputBuffer(Request, sizeof(struct device_info), &output_buf, &output_buf_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1356: FILE: windows/netuio/netuio_queue.c:228: + if (!NT_SUCCESS(status)) {$ WARNING:BRACES: braces {} are not necessary for single statement blocks #1356: FILE: windows/netuio/netuio_queue.c:228: + if (!NT_SUCCESS(status)) { + goto end; + } ERROR:CODE_INDENT: code indent should use tabs where possible #1357: FILE: windows/netuio/netuio_queue.c:229: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1357: FILE: windows/netuio/netuio_queue.c:229: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1358: FILE: windows/netuio/netuio_queue.c:230: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1360: FILE: windows/netuio/netuio_queue.c:232: + status = netuio_map_address_into_user_process(ctx, Request);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1361: FILE: windows/netuio/netuio_queue.c:233: + if (!NT_SUCCESS(status)) {$ WARNING:BRACES: braces {} are not necessary for single statement blocks #1361: FILE: windows/netuio/netuio_queue.c:233: + if (!NT_SUCCESS(status)) { + goto end; + } ERROR:CODE_INDENT: code indent should use tabs where possible #1362: FILE: windows/netuio/netuio_queue.c:234: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1362: FILE: windows/netuio/netuio_queue.c:234: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1363: FILE: windows/netuio/netuio_queue.c:235: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1365: FILE: windows/netuio/netuio_queue.c:237: + netuio_set_usermode_mapping_flag(Request);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1367: FILE: windows/netuio/netuio_queue.c:239: + netuio_handle_get_hw_data_request(ctx, output_buf, output_buf_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1368: FILE: windows/netuio/netuio_queue.c:240: + bytes_returned = output_buf_size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1371: FILE: windows/netuio/netuio_queue.c:243: + WdfRequestCompleteWithInformation(Request, status, bytes_returned);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1373: FILE: windows/netuio/netuio_queue.c:245: + return;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #1377: FILE: windows/netuio/netuio_queue.c:249: +/* +Routine Description: ERROR:CODE_INDENT: code indent should use tabs where possible #1386: FILE: windows/netuio/netuio_queue.c:258: + size_t OutputBufferLength, size_t InputBufferLength,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1386: FILE: windows/netuio/netuio_queue.c:258: + size_t OutputBufferLength, size_t InputBufferLength,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1387: FILE: windows/netuio/netuio_queue.c:259: + ULONG IoControlCode)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1387: FILE: windows/netuio/netuio_queue.c:259: + ULONG IoControlCode)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1389: FILE: windows/netuio/netuio_queue.c:261: + UNREFERENCED_PARAMETER(OutputBufferLength);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1390: FILE: windows/netuio/netuio_queue.c:262: + UNREFERENCED_PARAMETER(InputBufferLength);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1392: FILE: windows/netuio/netuio_queue.c:264: + NTSTATUS status = STATUS_SUCCESS;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1393: FILE: windows/netuio/netuio_queue.c:265: + PVOID input_buf = NULL, output_buf = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1394: FILE: windows/netuio/netuio_queue.c:266: + size_t input_buf_size, output_buf_size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1395: FILE: windows/netuio/netuio_queue.c:267: + size_t bytes_returned = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1397: FILE: windows/netuio/netuio_queue.c:269: + WDFDEVICE device = WdfIoQueueGetDevice(Queue);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1399: FILE: windows/netuio/netuio_queue.c:271: + PNETUIO_CONTEXT_DATA ctx;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1400: FILE: windows/netuio/netuio_queue.c:272: + ctx = netuio_get_context_data(device);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1402: FILE: windows/netuio/netuio_queue.c:274: + if (IoControlCode != IOCTL_NETUIO_PCI_CONFIG_IO)$ ERROR:OPEN_BRACE: that open brace { should be on the previous line #1402: FILE: windows/netuio/netuio_queue.c:274: + if (IoControlCode != IOCTL_NETUIO_PCI_CONFIG_IO) + { WARNING:LEADING_SPACE: please, no spaces at the start of a line #1403: FILE: windows/netuio/netuio_queue.c:275: + {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1404: FILE: windows/netuio/netuio_queue.c:276: + status = STATUS_INVALID_DEVICE_REQUEST;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1404: FILE: windows/netuio/netuio_queue.c:276: + status = STATUS_INVALID_DEVICE_REQUEST;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1405: FILE: windows/netuio/netuio_queue.c:277: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1405: FILE: windows/netuio/netuio_queue.c:277: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1406: FILE: windows/netuio/netuio_queue.c:278: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1408: FILE: windows/netuio/netuio_queue.c:280: + // First retrieve the input buffer and see if it matches our device$ ERROR:C99_COMMENTS: do not use C99 // comments #1408: FILE: windows/netuio/netuio_queue.c:280: + // First retrieve the input buffer and see if it matches our device WARNING:LONG_LINE: line over 100 characters #1409: FILE: windows/netuio/netuio_queue.c:281: + status = WdfRequestRetrieveInputBuffer(Request, sizeof(struct dpdk_pci_config_io), &input_buf, &input_buf_size); WARNING:LEADING_SPACE: please, no spaces at the start of a line #1409: FILE: windows/netuio/netuio_queue.c:281: + status = WdfRequestRetrieveInputBuffer(Request, sizeof(struct dpdk_pci_config_io), &input_buf, &input_buf_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1410: FILE: windows/netuio/netuio_queue.c:282: + if (!NT_SUCCESS(status)) {$ WARNING:BRACES: braces {} are not necessary for single statement blocks #1410: FILE: windows/netuio/netuio_queue.c:282: + if (!NT_SUCCESS(status)) { + goto end; + } ERROR:CODE_INDENT: code indent should use tabs where possible #1411: FILE: windows/netuio/netuio_queue.c:283: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1411: FILE: windows/netuio/netuio_queue.c:283: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1412: FILE: windows/netuio/netuio_queue.c:284: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1414: FILE: windows/netuio/netuio_queue.c:286: + struct dpdk_pci_config_io *dpdk_pci_io_input = (struct dpdk_pci_config_io *)input_buf;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1416: FILE: windows/netuio/netuio_queue.c:288: + if (dpdk_pci_io_input->access_size != 1 &&$ ERROR:CODE_INDENT: code indent should use tabs where possible #1417: FILE: windows/netuio/netuio_queue.c:289: + dpdk_pci_io_input->access_size != 2 &&$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1417: FILE: windows/netuio/netuio_queue.c:289: + dpdk_pci_io_input->access_size != 2 &&$ ERROR:CODE_INDENT: code indent should use tabs where possible #1418: FILE: windows/netuio/netuio_queue.c:290: + dpdk_pci_io_input->access_size != 4 &&$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1418: FILE: windows/netuio/netuio_queue.c:290: + dpdk_pci_io_input->access_size != 4 &&$ ERROR:CODE_INDENT: code indent should use tabs where possible #1419: FILE: windows/netuio/netuio_queue.c:291: + dpdk_pci_io_input->access_size != 8) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1419: FILE: windows/netuio/netuio_queue.c:291: + dpdk_pci_io_input->access_size != 8) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1420: FILE: windows/netuio/netuio_queue.c:292: + status = STATUS_INVALID_PARAMETER;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1420: FILE: windows/netuio/netuio_queue.c:292: + status = STATUS_INVALID_PARAMETER;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1421: FILE: windows/netuio/netuio_queue.c:293: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1421: FILE: windows/netuio/netuio_queue.c:293: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1422: FILE: windows/netuio/netuio_queue.c:294: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1424: FILE: windows/netuio/netuio_queue.c:296: + // Retrieve output buffer$ ERROR:C99_COMMENTS: do not use C99 // comments #1424: FILE: windows/netuio/netuio_queue.c:296: + // Retrieve output buffer WARNING:LEADING_SPACE: please, no spaces at the start of a line #1425: FILE: windows/netuio/netuio_queue.c:297: + status = WdfRequestRetrieveOutputBuffer(Request, sizeof(UINT64), &output_buf, &output_buf_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1426: FILE: windows/netuio/netuio_queue.c:298: + if (!NT_SUCCESS(status)) {$ WARNING:BRACES: braces {} are not necessary for single statement blocks #1426: FILE: windows/netuio/netuio_queue.c:298: + if (!NT_SUCCESS(status)) { + goto end; + } ERROR:CODE_INDENT: code indent should use tabs where possible #1427: FILE: windows/netuio/netuio_queue.c:299: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1427: FILE: windows/netuio/netuio_queue.c:299: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1428: FILE: windows/netuio/netuio_queue.c:300: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1429: FILE: windows/netuio/netuio_queue.c:301: + ASSERT(output_buf_size == OutputBufferLength);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1431: FILE: windows/netuio/netuio_queue.c:303: + if (dpdk_pci_io_input->op == PCI_IO_READ) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #1432: FILE: windows/netuio/netuio_queue.c:304: + *(UINT64 *)output_buf = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1432: FILE: windows/netuio/netuio_queue.c:304: + *(UINT64 *)output_buf = 0;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1433: FILE: windows/netuio/netuio_queue.c:305: + bytes_returned = ctx->bus_interface.GetBusData($ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1433: FILE: windows/netuio/netuio_queue.c:305: + bytes_returned = ctx->bus_interface.GetBusData($ ERROR:CODE_INDENT: code indent should use tabs where possible #1434: FILE: windows/netuio/netuio_queue.c:306: + ctx->bus_interface.Context,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1434: FILE: windows/netuio/netuio_queue.c:306: + ctx->bus_interface.Context,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1435: FILE: windows/netuio/netuio_queue.c:307: + PCI_WHICHSPACE_CONFIG,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1435: FILE: windows/netuio/netuio_queue.c:307: + PCI_WHICHSPACE_CONFIG,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1436: FILE: windows/netuio/netuio_queue.c:308: + output_buf,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1436: FILE: windows/netuio/netuio_queue.c:308: + output_buf,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1437: FILE: windows/netuio/netuio_queue.c:309: + dpdk_pci_io_input->offset,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1437: FILE: windows/netuio/netuio_queue.c:309: + dpdk_pci_io_input->offset,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1438: FILE: windows/netuio/netuio_queue.c:310: + dpdk_pci_io_input->access_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1438: FILE: windows/netuio/netuio_queue.c:310: + dpdk_pci_io_input->access_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1439: FILE: windows/netuio/netuio_queue.c:311: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1440: FILE: windows/netuio/netuio_queue.c:312: + else if (dpdk_pci_io_input->op == PCI_IO_WRITE) {$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #1440: FILE: windows/netuio/netuio_queue.c:312: + } + else if (dpdk_pci_io_input->op == PCI_IO_WRITE) { ERROR:CODE_INDENT: code indent should use tabs where possible #1441: FILE: windows/netuio/netuio_queue.c:313: + // returns bytes written$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1441: FILE: windows/netuio/netuio_queue.c:313: + // returns bytes written$ ERROR:C99_COMMENTS: do not use C99 // comments #1441: FILE: windows/netuio/netuio_queue.c:313: + // returns bytes written ERROR:CODE_INDENT: code indent should use tabs where possible #1442: FILE: windows/netuio/netuio_queue.c:314: + bytes_returned = ctx->bus_interface.SetBusData($ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1442: FILE: windows/netuio/netuio_queue.c:314: + bytes_returned = ctx->bus_interface.SetBusData($ ERROR:CODE_INDENT: code indent should use tabs where possible #1443: FILE: windows/netuio/netuio_queue.c:315: + ctx->bus_interface.Context,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1443: FILE: windows/netuio/netuio_queue.c:315: + ctx->bus_interface.Context,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1444: FILE: windows/netuio/netuio_queue.c:316: + PCI_WHICHSPACE_CONFIG,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1444: FILE: windows/netuio/netuio_queue.c:316: + PCI_WHICHSPACE_CONFIG,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1445: FILE: windows/netuio/netuio_queue.c:317: + (PVOID)&dpdk_pci_io_input->data,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1445: FILE: windows/netuio/netuio_queue.c:317: + (PVOID)&dpdk_pci_io_input->data,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1446: FILE: windows/netuio/netuio_queue.c:318: + dpdk_pci_io_input->offset,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1446: FILE: windows/netuio/netuio_queue.c:318: + dpdk_pci_io_input->offset,$ ERROR:CODE_INDENT: code indent should use tabs where possible #1447: FILE: windows/netuio/netuio_queue.c:319: + dpdk_pci_io_input->access_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1447: FILE: windows/netuio/netuio_queue.c:319: + dpdk_pci_io_input->access_size);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1448: FILE: windows/netuio/netuio_queue.c:320: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1449: FILE: windows/netuio/netuio_queue.c:321: + else {$ ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #1449: FILE: windows/netuio/netuio_queue.c:321: + } + else { ERROR:CODE_INDENT: code indent should use tabs where possible #1450: FILE: windows/netuio/netuio_queue.c:322: + status = STATUS_INVALID_PARAMETER;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1450: FILE: windows/netuio/netuio_queue.c:322: + status = STATUS_INVALID_PARAMETER;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1451: FILE: windows/netuio/netuio_queue.c:323: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1451: FILE: windows/netuio/netuio_queue.c:323: + goto end;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1452: FILE: windows/netuio/netuio_queue.c:324: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1454: FILE: windows/netuio/netuio_queue.c:326: + if (bytes_returned != dpdk_pci_io_input->access_size) {$ WARNING:BRACES: braces {} are not necessary for single statement blocks #1454: FILE: windows/netuio/netuio_queue.c:326: + if (bytes_returned != dpdk_pci_io_input->access_size) { + status = STATUS_INVALID_PARAMETER; + } ERROR:CODE_INDENT: code indent should use tabs where possible #1455: FILE: windows/netuio/netuio_queue.c:327: + status = STATUS_INVALID_PARAMETER;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1455: FILE: windows/netuio/netuio_queue.c:327: + status = STATUS_INVALID_PARAMETER;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1456: FILE: windows/netuio/netuio_queue.c:328: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1459: FILE: windows/netuio/netuio_queue.c:331: + WdfRequestCompleteWithInformation(Request, status, bytes_returned);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1461: FILE: windows/netuio/netuio_queue.c:333: + return;$ ERROR:C99_COMMENTS: do not use C99 // comments #1489: FILE: windows/netuio/netuio_queue.h:21: +#endif // NETUIO_QUEUE_H total: 235 errors, 478 warnings, 1275 lines checked