automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: John Alexander <john.alexander@datapath.co.uk>
Subject: [dpdk-test-report] |WARNING| pw78673 [PATCH] eal/windows: Switched to an external pthreads library, pulled in as a meson subproject
Date: Thu, 24 Sep 2020 13:12:52 +0200 (CEST)	[thread overview]
Message-ID: <20200924111252.BB0AF1DDF6@dpdk.org> (raw)
In-Reply-To: <20200924111215.118-1-john.alexander@datapath.co.uk>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78673

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#139: 
The Windows EAL build now pulls in the pthreads4w project as an external subproject.  The pthreads4w subproject does not currently provide a meson build so the project has been patched with one.

WARNING:TYPO_SPELLING: 'auxillary' may be misspelled - perhaps 'auxiliary'?
#149: 
Added the source file librte_eal\windows\windows_eal_impl.c.  This source file serves as a location for the implementation of auxillary functionality provided by the Windows EAL that would otherwise be provided by the UNIX runtime.

ERROR:TRAILING_WHITESPACE: trailing whitespace
#236: FILE: lib/librte_eal/windows/eal.c:368:
+^I * real-time thread priority and real-time process class set.  $

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#516: FILE: lib/librte_eal/windows/include/rte_os.h:51:
+void RTE_CPU_ANDNOT(cpu_set_t * dst, cpu_set_t * src);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#516: FILE: lib/librte_eal/windows/include/rte_os.h:51:
+void RTE_CPU_ANDNOT(cpu_set_t * dst, cpu_set_t * src);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#517: FILE: lib/librte_eal/windows/include/rte_os.h:52:
+void RTE_CPU_COPY(cpu_set_t * from, cpu_set_t *to);

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#669: FILE: lib/librte_eal/windows/windows_eal_impl.c:23:
+	do
+	{

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#673: FILE: lib/librte_eal/windows/windows_eal_impl.c:27:
+		if ((masked_so_far + 8) > system_info.dwNumberOfProcessors)
+		{

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#690: FILE: lib/librte_eal/windows/windows_eal_impl.c:44:
+	for (set_index = 0;
+	     set_index < _countof(dst->cpuset);
+	     set_index++)
+	{

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 8 errors, 2 warnings, 333 lines checked
Warning in lib/librte_eal/windows/eal.c:
Using rte_panic/rte_exit

       reply	other threads:[~2020-09-24 11:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200924111215.118-1-john.alexander@datapath.co.uk>
2020-09-24 11:12 ` checkpatch [this message]
2020-09-24 13:58 ` [dpdk-test-report] |WARNING| pw78673 " 0-day Robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924111252.BB0AF1DDF6@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=john.alexander@datapath.co.uk \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).