From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DDA3AA04B1
	for <public@inbox.dpdk.org>; Thu, 24 Sep 2020 14:15:38 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id E2ACF1E887;
	Thu, 24 Sep 2020 14:15:24 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 90E6C1DE35; Thu, 24 Sep 2020 14:15:22 +0200 (CEST)
In-Reply-To: <1600949555-28043-12-git-send-email-arybchenko@solarflare.com>
References: <1600949555-28043-12-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20200924121522.90E6C1DE35@dpdk.org>
Date: Thu, 24 Sep 2020 14:15:22 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw78690 [PATCH v3 11/60]
	common/sfc_efx/base: factor out helper to get board config
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78690

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#177: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1875:
+	if ((rc = efx_mcdi_get_vector_cfg(enp, &base, &nvec, NULL)) != 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#194: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1892:
+	if ((rc = ef10_get_privilege_mask(enp, &mask)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#198: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1896:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#223: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1921:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#273: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1971:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#284: FILE: drivers/common/sfc_efx/base/ef10_nic.c:1982:
+	if ((rc = efx_mcdi_nic_board_cfg(enp)) != 0)

total: 6 errors, 0 warnings, 255 lines checked