automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw78698 [PATCH v3 23/60] common/sfc_efx/base: add event queue module for Riverhead
Date: Thu, 24 Sep 2020 14:17:23 +0200 (CEST)	[thread overview]
Message-ID: <20200924121723.EE4791DE90@dpdk.org> (raw)
In-Reply-To: <1600949555-28043-24-git-send-email-arybchenko@solarflare.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78698

_coding style issues_


ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#319: FILE: drivers/common/sfc_efx/base/rhead_ev.c:81:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#324: FILE: drivers/common/sfc_efx/base/rhead_ev.c:86:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#354: FILE: drivers/common/sfc_efx/base/rhead_ev.c:116:
+	return (0);

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#390: FILE: drivers/common/sfc_efx/base/rhead_ev.c:152:
+	__inout		unsigned int *countp,

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#411: FILE: drivers/common/sfc_efx/base/rhead_ev.c:173:
+		offset = (count & eep->ee_mask) * sizeof (efx_qword_t);

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#422: FILE: drivers/common/sfc_efx/base/rhead_ev.c:184:
+			offset += sizeof (efx_qword_t);

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#482: FILE: drivers/common/sfc_efx/base/rhead_ev.c:244:
+	return (ENOTSUP);

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#490: FILE: drivers/common/sfc_efx/base/rhead_ev.c:252:
+	__inout_ecount(EV_NQSTATS)	efsys_stat_t *stat)

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#571: FILE: drivers/common/sfc_efx/base/rhead_impl.h:153:
+	__inout		unsigned int *countp,

WARNING:TYPO_SPELLING: 'inout' may be misspelled - perhaps 'input'?
#587: FILE: drivers/common/sfc_efx/base/rhead_impl.h:169:
+	__inout_ecount(EV_NQSTATS)	efsys_stat_t *stat);

total: 3 errors, 7 warnings, 450 lines checked

           reply	other threads:[~2020-09-24 12:17 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1600949555-28043-24-git-send-email-arybchenko@solarflare.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200924121723.EE4791DE90@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=arybchenko@solarflare.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).