From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw78726 [PATCH v3 49/60] common/sfc_efx/base: introduce states for UDP tunnel entries
Date: Thu, 24 Sep 2020 14:21:57 +0200 (CEST) [thread overview]
Message-ID: <20200924122157.B87F41E4A4@dpdk.org> (raw)
In-Reply-To: <1600949555-28043-50-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/78726
_coding style issues_
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#230: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:90:
+ return (B_FALSE);
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#248: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:112:
+ if (etcp != NULL) {
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#249: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:113:
+ for (i = 0; i < etcp->etc_udp_entries_num; i++) {
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#250: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:114:
+ if (ef10_entry_staged(&etcp->etc_udp_entries[i]) !=
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#267: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:140:
+ while (ef10_entry_staged(&etcp->etc_udp_entries[i]) == B_FALSE)
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#296: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:349:
+ etcp->etc_udp_entries[etcp->etc_udp_entries_num].etue_state =
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#296: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:349:
+ etcp->etc_udp_entries[etcp->etc_udp_entries_num].etue_state =
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#311: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:380:
+ __in efx_tunnel_cfg_t *etcp,
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#314: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:383:
+ EFSYS_ASSERT3U(etcp->etc_udp_entries_num, >, 0);
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#315: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:384:
+ etcp->etc_udp_entries_num--;
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#317: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:386:
+ if (entry < etcp->etc_udp_entries_num) {
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#318: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:387:
+ memmove(&etcp->etc_udp_entries[entry],
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#319: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:388:
+ &etcp->etc_udp_entries[entry + 1],
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#320: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:389:
+ (etcp->etc_udp_entries_num - entry) *
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#321: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:390:
+ sizeof (etcp->etc_udp_entries[0]));
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#321: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:390:
+ sizeof (etcp->etc_udp_entries[0]));
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#324: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:393:
+ memset(&etcp->etc_udp_entries[etcp->etc_udp_entries_num], 0,
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#324: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:393:
+ memset(&etcp->etc_udp_entries[etcp->etc_udp_entries_num], 0,
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#325: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:394:
+ sizeof (etcp->etc_udp_entries[0]));
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#325: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:394:
+ sizeof (etcp->etc_udp_entries[0]));
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#327: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:396:
+ return (entry);
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#337: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:406:
+ __in efx_tunnel_cfg_t *etcp,
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#342: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:411:
+ switch (etcp->etc_udp_entries[entry].etue_state) {
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#344: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:413:
+ next = efx_tunnel_config_udp_do_remove(etcp, entry);
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#349: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:418:
+ etcp->etc_udp_entries[entry].etue_state =
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#369: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:448:
+ if (etcp->etc_udp_entries[entry].etue_busy != B_FALSE) {
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#382: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:453:
+ if (etcp->etc_udp_entries[entry].etue_protocol != protocol) {
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#389: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:458:
+ (void) efx_tunnel_config_udp_remove_prepare(etcp, entry);
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#408: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:479:
+ __in efx_tunnel_cfg_t *etcp)
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#412: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:483:
+ for (i = 0; i < etcp->etc_udp_entries_num; i++) {
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#413: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:484:
+ if (etcp->etc_udp_entries[i].etue_busy != B_FALSE)
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#435: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:504:
+ if (efx_tunnel_table_all_available(etcp) == B_FALSE) {
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#441: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:510:
+ while (i < etcp->etc_udp_entries_num)
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#442: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:511:
+ i = efx_tunnel_config_udp_remove_prepare(etcp, i);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#446: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:515:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#452: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:521:
+ return (rc);
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#460: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:529:
+ efx_tunnel_cfg_t *etcp = &enp->en_tunnel_cfg;
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#477: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:547:
+ if (efx_tunnel_table_all_available(etcp) == B_FALSE) {
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#483: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:552:
+ for (i = 0; i < etcp->etc_udp_entries_num; i++) {
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#484: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:553:
+ entry = &etcp->etc_udp_entries[i];
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#509: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:578:
+ while (i < etcp->etc_udp_entries_num) {
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#512: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:581:
+ entry = &etcp->etc_udp_entries[i];
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#524: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:593:
+ next = efx_tunnel_config_udp_do_remove(etcp, i);
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#546: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:615:
+ for (i = 0; i < etcp->etc_udp_entries_num; i++)
WARNING:TYPO_SPELLING: 'etcp' may be misspelled - perhaps 'etc'?
#547: FILE: drivers/common/sfc_efx/base/efx_tunnel.c:616:
+ etcp->etc_udp_entries[i].etue_busy = B_FALSE;
total: 4 errors, 41 warnings, 421 lines checked
parent reply other threads:[~2020-09-24 12:22 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1600949555-28043-50-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200924122157.B87F41E4A4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).