automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79619 [PATCH v2 03/56] net/txgbe: add device init and uninit
Date: Mon,  5 Oct 2020 14:10:37 +0200 (CEST)	[thread overview]
Message-ID: <20201005121037.338181BEAD@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-4-jiawenwu@trustnetic.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79619

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#59: 
Add basic init and uninit function, and some macro definitions prepare for hardware infrastructure.

WARNING:MEMORY_BARRIER: memory barrier without comment
#226: FILE: drivers/net/txgbe/base/txgbe_osdep.h:151:
+#define mb()	rte_mb()

WARNING:MEMORY_BARRIER: memory barrier without comment
#227: FILE: drivers/net/txgbe/base/txgbe_osdep.h:152:
+#define wmb()	rte_wmb()

WARNING:MEMORY_BARRIER: memory barrier without comment
#228: FILE: drivers/net/txgbe/base/txgbe_osdep.h:153:
+#define rmb()	rte_rmb()

CHECK:CAMELCASE: Avoid CamelCase: <Address>
#248: FILE: drivers/net/txgbe/base/txgbe_osdep.h:173:
+#define TXGBE_IS_MULTICAST(Address) \

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'Address' - possible side-effects?
#252: FILE: drivers/net/txgbe/base/txgbe_osdep.h:177:
+#define TXGBE_IS_BROADCAST(Address) \
+		((((u8 *)(Address))[0] == ((u8)0xff)) && \
+		(((u8 *)(Address))[1] == ((u8)0xff)))

WARNING:BRACES: braces {} are not necessary for single statement blocks
#352: FILE: drivers/net/txgbe/txgbe_ethdev.c:54:
+	if (mz == NULL) {
+		return -ENOMEM;
+	}

total: 0 errors, 5 warnings, 2 checks, 363 lines checked
Warning in drivers/net/txgbe/base/txgbe_osdep.h:
Using rte_panic/rte_exit
Warning in drivers/net/txgbe/base/txgbe_osdep.h:
Using compiler attribute directly

           reply	other threads:[~2020-10-05 12:11 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20201005120910.189343-4-jiawenwu@trustnetic.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201005121037.338181BEAD@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).