automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw79619 [PATCH v2 03/56] net/txgbe: add device init and uninit
       [not found] <20201005120910.189343-4-jiawenwu@trustnetic.com>
@ 2020-10-05 12:10 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-10-05 12:10 UTC (permalink / raw)
  To: test-report; +Cc: Jiawen Wu

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79619

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#59: 
Add basic init and uninit function, and some macro definitions prepare for hardware infrastructure.

WARNING:MEMORY_BARRIER: memory barrier without comment
#226: FILE: drivers/net/txgbe/base/txgbe_osdep.h:151:
+#define mb()	rte_mb()

WARNING:MEMORY_BARRIER: memory barrier without comment
#227: FILE: drivers/net/txgbe/base/txgbe_osdep.h:152:
+#define wmb()	rte_wmb()

WARNING:MEMORY_BARRIER: memory barrier without comment
#228: FILE: drivers/net/txgbe/base/txgbe_osdep.h:153:
+#define rmb()	rte_rmb()

CHECK:CAMELCASE: Avoid CamelCase: <Address>
#248: FILE: drivers/net/txgbe/base/txgbe_osdep.h:173:
+#define TXGBE_IS_MULTICAST(Address) \

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'Address' - possible side-effects?
#252: FILE: drivers/net/txgbe/base/txgbe_osdep.h:177:
+#define TXGBE_IS_BROADCAST(Address) \
+		((((u8 *)(Address))[0] == ((u8)0xff)) && \
+		(((u8 *)(Address))[1] == ((u8)0xff)))

WARNING:BRACES: braces {} are not necessary for single statement blocks
#352: FILE: drivers/net/txgbe/txgbe_ethdev.c:54:
+	if (mz == NULL) {
+		return -ENOMEM;
+	}

total: 0 errors, 5 warnings, 2 checks, 363 lines checked
Warning in drivers/net/txgbe/base/txgbe_osdep.h:
Using rte_panic/rte_exit
Warning in drivers/net/txgbe/base/txgbe_osdep.h:
Using compiler attribute directly

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-10-05 12:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20201005120910.189343-4-jiawenwu@trustnetic.com>
2020-10-05 12:10 ` [dpdk-test-report] |WARNING| pw79619 [PATCH v2 03/56] net/txgbe: add device init and uninit checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).