From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3AD95A04BA
	for <public@inbox.dpdk.org>; Mon,  5 Oct 2020 14:11:09 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 085F31BF3B;
	Mon,  5 Oct 2020 14:10:39 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 338181BEAD; Mon,  5 Oct 2020 14:10:37 +0200 (CEST)
In-Reply-To: <20201005120910.189343-4-jiawenwu@trustnetic.com>
References: <20201005120910.189343-4-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20201005121037.338181BEAD@dpdk.org>
Date: Mon,  5 Oct 2020 14:10:37 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw79619 [PATCH v2 03/56] net/txgbe:
	add device init and uninit
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79619

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#59: 
Add basic init and uninit function, and some macro definitions prepare for hardware infrastructure.

WARNING:MEMORY_BARRIER: memory barrier without comment
#226: FILE: drivers/net/txgbe/base/txgbe_osdep.h:151:
+#define mb()	rte_mb()

WARNING:MEMORY_BARRIER: memory barrier without comment
#227: FILE: drivers/net/txgbe/base/txgbe_osdep.h:152:
+#define wmb()	rte_wmb()

WARNING:MEMORY_BARRIER: memory barrier without comment
#228: FILE: drivers/net/txgbe/base/txgbe_osdep.h:153:
+#define rmb()	rte_rmb()

CHECK:CAMELCASE: Avoid CamelCase: <Address>
#248: FILE: drivers/net/txgbe/base/txgbe_osdep.h:173:
+#define TXGBE_IS_MULTICAST(Address) \

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'Address' - possible side-effects?
#252: FILE: drivers/net/txgbe/base/txgbe_osdep.h:177:
+#define TXGBE_IS_BROADCAST(Address) \
+		((((u8 *)(Address))[0] == ((u8)0xff)) && \
+		(((u8 *)(Address))[1] == ((u8)0xff)))

WARNING:BRACES: braces {} are not necessary for single statement blocks
#352: FILE: drivers/net/txgbe/txgbe_ethdev.c:54:
+	if (mz == NULL) {
+		return -ENOMEM;
+	}

total: 0 errors, 5 warnings, 2 checks, 363 lines checked
Warning in drivers/net/txgbe/base/txgbe_osdep.h:
Using rte_panic/rte_exit
Warning in drivers/net/txgbe/base/txgbe_osdep.h:
Using compiler attribute directly