From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BE84A04B1 for ; Mon, 5 Oct 2020 14:11:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BADB1B80B; Mon, 5 Oct 2020 14:11:01 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id B3F601B7FA; Mon, 5 Oct 2020 14:10:59 +0200 (CEST) In-Reply-To: <20201005120910.189343-5-jiawenwu@trustnetic.com> References: <20201005120910.189343-5-jiawenwu@trustnetic.com> To: test-report@dpdk.org Cc: Jiawen Wu Message-Id: <20201005121059.B3F601B7FA@dpdk.org> Date: Mon, 5 Oct 2020 14:10:59 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw79620 [PATCH v2 04/56] net/txgbe: add error types and registers X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/79620 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects? #109: FILE: drivers/net/txgbe/base/txgbe_regs.h:35: +#define ROUND_UP(x, y) (((x) + (y) - 1) / (y) * (y)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'y' - possible side-effects? #110: FILE: drivers/net/txgbe/base/txgbe_regs.h:36: +#define ROUND_DOWN(x, y) ((x) / (y) * (y)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #111: FILE: drivers/net/txgbe/base/txgbe_regs.h:37: +#define ROUND_OVER(x, maxbits, unitbits) \ + ((x) >= 1 << (maxbits) ? 0 : (x) >> (unitbits)) CHECK:CAMELCASE: Avoid CamelCase: #129: FILE: drivers/net/txgbe/base/txgbe_regs.h:55: +#define TXGBE_AUTOC_LMS_10Gs LS64(3, 13, 0x7) CHECK:CAMELCASE: Avoid CamelCase: #156: FILE: drivers/net/txgbe/base/txgbe_regs.h:82: +#define TXGBE_AUTOC_10Gs_PMA_PMD_MASK MS64(48, 0x3) /* serial */ CHECK:CAMELCASE: Avoid CamelCase: #157: FILE: drivers/net/txgbe/base/txgbe_regs.h:83: +#define TXGBE_AUTOC_10Gs_KR LS64(0, 48, 0x3) CHECK:CAMELCASE: Avoid CamelCase: #158: FILE: drivers/net/txgbe/base/txgbe_regs.h:84: +#define TXGBE_AUTOC_10Gs_XFI LS64(1, 48, 0x3) CHECK:CAMELCASE: Avoid CamelCase: #159: FILE: drivers/net/txgbe/base/txgbe_regs.h:85: +#define TXGBE_AUTOC_10Gs_SFI LS64(2, 48, 0x3) CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #230: FILE: drivers/net/txgbe/base/txgbe_regs.h:156: +#define TXGBE_RST_LAN(i) MS(((i)+1), 0x1) ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #232: FILE: drivers/net/txgbe/base/txgbe_regs.h:158: +#define TXGBE_RST_ETH(i) MS(((i)+29), 0x1) ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #283: FILE: drivers/net/txgbe/base/txgbe_regs.h:209: +#define TXGBE_FLASH_LANRSTD(i) MS(((i)+9), 0x1) ^ CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #380: FILE: drivers/net/txgbe/base/txgbe_regs.h:306: +#define TXGBE_LEDCTL_OD(s) MS(((s)+16), 0x1) ^ WARNING:TYPO_SPELLING: 'QUE' may be misspelled - perhaps 'QUEUE'? #901: FILE: drivers/net/txgbe/base/txgbe_regs.h:827: +#define TXGBE_FCRSSTBL_QUE(v) LS(v, 0, 0x7F) CHECK:CAMELCASE: Avoid CamelCase: #1158: FILE: drivers/net/txgbe/base/txgbe_regs.h:1084: +#define TXGBE_MACRX1024toMAXL 0x001968 CHECK:CAMELCASE: Avoid CamelCase: #1159: FILE: drivers/net/txgbe/base/txgbe_regs.h:1085: +#define TXGBE_MACRX1024toMAXH 0x00196C CHECK:CAMELCASE: Avoid CamelCase: #1170: FILE: drivers/net/txgbe/base/txgbe_regs.h:1096: +#define TXGBE_MACTX1024toMAXL 0x00185C CHECK:CAMELCASE: Avoid CamelCase: #1171: FILE: drivers/net/txgbe/base/txgbe_regs.h:1097: +#define TXGBE_MACTX1024toMAXH 0x001860 CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects? #1331: FILE: drivers/net/txgbe/base/txgbe_regs.h:1257: +#define TXGBE_VFPBWRAP_WRAP(r, tc) ((0x7 << 4 * (tc) & (r)) >> 4 * (tc)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects? #1332: FILE: drivers/net/txgbe/base/txgbe_regs.h:1258: +#define TXGBE_VFPBWRAP_EMPT(r, tc) ((0x8 << 4 * (tc) & (r)) >> 4 * (tc)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects? #1532: FILE: drivers/net/txgbe/base/txgbe_regs.h:1458: +#define TXGBE_PBRXSTAT_WRAP(tc, r) ((7u << 4 * (tc) & (r)) >> 4 * (tc)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects? #1533: FILE: drivers/net/txgbe/base/txgbe_regs.h:1459: +#define TXGBE_PBRXSTAT_EMPT(tc, r) ((8u << 4 * (tc) & (r)) >> 4 * (tc)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tc' - possible side-effects? #1546: FILE: drivers/net/txgbe/base/txgbe_regs.h:1472: +#define TXGBE_PBTXSTAT_EMPT(tc, r) ((1 << (tc) & (r)) >> (tc)) WARNING:TYPO_SPELLING: 'sting' may be misspelled - perhaps 'string'? #1770: FILE: drivers/net/txgbe/base/txgbe_regs.h:1696: +#define NVM_VER_SIZE 32 /* version sting size */ WARNING:RETURN_VOID: void function return statements are not generally useful #1831: FILE: drivers/net/txgbe/base/txgbe_regs.h:1757: + return; +} WARNING:BRACES: braces {} are not necessary for single statement blocks #1896: FILE: drivers/net/txgbe/base/txgbe_regs.h:1822: + if (value == expect) { + break; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #1903: FILE: drivers/net/txgbe/base/txgbe_regs.h:1829: + if (actual) { + *actual = all; + } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #1918: FILE: drivers/net/txgbe/base/txgbe_regs.h:1844: +#define rd32w(hw, reg, mask, slice) do { \ + rd32((hw), reg); \ + po32m((hw), reg, mask, mask, NULL, 5, slice); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects? #1918: FILE: drivers/net/txgbe/base/txgbe_regs.h:1844: +#define rd32w(hw, reg, mask, slice) do { \ + rd32((hw), reg); \ + po32m((hw), reg, mask, mask, NULL, 5, slice); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects? #1918: FILE: drivers/net/txgbe/base/txgbe_regs.h:1844: +#define rd32w(hw, reg, mask, slice) do { \ + rd32((hw), reg); \ + po32m((hw), reg, mask, mask, NULL, 5, slice); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #1923: FILE: drivers/net/txgbe/base/txgbe_regs.h:1849: +#define wr32w(hw, reg, val, mask, slice) do { \ + wr32((hw), reg, val); \ + po32m((hw), reg, mask, mask, NULL, 5, slice); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'reg' - possible side-effects? #1923: FILE: drivers/net/txgbe/base/txgbe_regs.h:1849: +#define wr32w(hw, reg, val, mask, slice) do { \ + wr32((hw), reg, val); \ + po32m((hw), reg, mask, mask, NULL, 5, slice); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects? #1923: FILE: drivers/net/txgbe/base/txgbe_regs.h:1849: +#define wr32w(hw, reg, val, mask, slice) do { \ + wr32((hw), reg, val); \ + po32m((hw), reg, mask, mask, NULL, 5, slice); \ +} while (0) WARNING:TYPO_SPELLING: 'MASTER' may be misspelled - perhaps 'PRIMARY'? #2055: FILE: drivers/net/txgbe/base/txgbe_status.h:85: +#define TXGBE_ERR_MASTER_REQUESTS_PENDING -(TERR_BASE + 12) total: 0 errors, 6 warnings, 27 checks, 2012 lines checked