From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79621 [PATCH v2 05/56] net/txgbe: add mac type and bus lan id
Date: Mon, 5 Oct 2020 14:11:02 +0200 (CEST) [thread overview]
Message-ID: <20201005121102.E42041BD16@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-6-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79621
_coding style issues_
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#133: FILE: drivers/net/txgbe/base/txgbe_hw.c:29:
+ if (TXGBE_PWR_LANID_SWAP == TXGBE_PWR_LANID(reg))
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_set_mac_type', this function's name, in a string
#176: FILE: drivers/net/txgbe/base/txgbe_hw.c:72:
+ DEBUGFUNC("txgbe_set_mac_type
");
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_set_mac_type', this function's name, in a string
#213: FILE: drivers/net/txgbe/base/txgbe_hw.c:109:
+ DEBUGOUT("txgbe_set_mac_type found mac: %d media: %d, returns: %d
",
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#397: FILE: drivers/net/txgbe/base/txgbe_type.h:136:
+ s32 (*get_bus_info)(struct txgbe_hw *);
WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#398: FILE: drivers/net/txgbe/base/txgbe_type.h:137:
+ void (*set_lan_id)(struct txgbe_hw *);
CHECK:SPACING: No space is necessary after a cast
#497: FILE: drivers/net/txgbe/txgbe_ethdev.c:120:
+ (int)hw->mac.type, (int) hw->phy.type);
total: 0 errors, 5 warnings, 1 checks, 393 lines checked
parent reply other threads:[~2020-10-05 12:11 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-6-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005121102.E42041BD16@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).