From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E98D5A04B1
	for <public@inbox.dpdk.org>; Mon,  5 Oct 2020 14:11:35 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 3BF211BCE5;
	Mon,  5 Oct 2020 14:11:04 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id E42041BD16; Mon,  5 Oct 2020 14:11:02 +0200 (CEST)
In-Reply-To: <20201005120910.189343-6-jiawenwu@trustnetic.com>
References: <20201005120910.189343-6-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20201005121102.E42041BD16@dpdk.org>
Date: Mon,  5 Oct 2020 14:11:02 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw79621 [PATCH v2 05/56] net/txgbe:
	add mac type and bus lan id
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79621

_coding style issues_


WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#133: FILE: drivers/net/txgbe/base/txgbe_hw.c:29:
+	if (TXGBE_PWR_LANID_SWAP == TXGBE_PWR_LANID(reg))

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_set_mac_type', this function's name, in a string
#176: FILE: drivers/net/txgbe/base/txgbe_hw.c:72:
+	DEBUGFUNC("txgbe_set_mac_type
");

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_set_mac_type', this function's name, in a string
#213: FILE: drivers/net/txgbe/base/txgbe_hw.c:109:
+	DEBUGOUT("txgbe_set_mac_type found mac: %d media: %d, returns: %d
",

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#397: FILE: drivers/net/txgbe/base/txgbe_type.h:136:
+	s32 (*get_bus_info)(struct txgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct txgbe_hw *' should also have an identifier name
#398: FILE: drivers/net/txgbe/base/txgbe_type.h:137:
+	void (*set_lan_id)(struct txgbe_hw *);

CHECK:SPACING: No space is necessary after a cast
#497: FILE: drivers/net/txgbe/txgbe_ethdev.c:120:
+			     (int)hw->mac.type, (int) hw->phy.type);

total: 0 errors, 5 warnings, 1 checks, 393 lines checked