From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79622 [PATCH v2 02/56] net/txgbe: add ethdev probe and remove
Date: Mon, 5 Oct 2020 14:11:06 +0200 (CEST) [thread overview]
Message-ID: <20201005121106.2B18C1BDDC@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-3-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79622
_coding style issues_
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#228: FILE: drivers/net/txgbe/txgbe_ethdev.c:25:
+{
+
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#237: FILE: drivers/net/txgbe/txgbe_ethdev.c:34:
+{
+
CHECK:BRACES: braces {} should be used on all arms of this statement
#251: FILE: drivers/net/txgbe/txgbe_ethdev.c:48:
+ if (pci_dev->device.devargs) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#256: FILE: drivers/net/txgbe/txgbe_ethdev.c:53:
+ } else
WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#396: FILE: drivers/net/txgbe/txgbe_logs.h:60:
+#define wjmsg_line(fmt, ...) \
+ do { \
+ RTE_LOG(CRIT, PMD, "%s(%d): " fmt, \
+ __FUNCTION__, __LINE__, ## __VA_ARGS__); \
+ } while (0)
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#397: FILE: drivers/net/txgbe/txgbe_logs.h:61:
+ do { \$
WARNING:USE_FUNC: __func__ should be used instead of gcc specific __FUNCTION__
#399: FILE: drivers/net/txgbe/txgbe_logs.h:63:
+ __FUNCTION__, __LINE__, ## __VA_ARGS__); \
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#400: FILE: drivers/net/txgbe/txgbe_logs.h:64:
+ } while (0)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#402: FILE: drivers/net/txgbe/txgbe_logs.h:66:
+ do { \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#405: FILE: drivers/net/txgbe/txgbe_logs.h:69:
+ } while (0)$
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mb' - possible side-effects?
#408: FILE: drivers/net/txgbe/txgbe_logs.h:72:
+#define wjdump(mb) { \
+ int j; char buf[128] = ""; \
+ wjmsg("data_len=%d pkt_len=%d vlan_tci=%d " \
+ "packet_type=0x%08x ol_flags=0x%016lx " \
+ "hash.rss=0x%08x hash.fdir.hash=0x%04x hash.fdir.id=%d
", \
+ mb->data_len, mb->pkt_len, mb->vlan_tci, \
+ mb->packet_type, mb->ol_flags, \
+ mb->hash.rss, mb->hash.fdir.hash, mb->hash.fdir.id); \
+ for (j = 0; j < mb->data_len; j++) { \
+ sprintf(buf + strlen(buf), "%02x ", \
+ ((uint8_t *)(mb->buf_addr) + mb->data_off)[j]); \
+ if (j % 8 == 7) {\
+ wjmsg("%s
", buf); \
+ buf[0] = '
parent reply other threads:[~2020-10-05 12:11 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-3-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005121106.2B18C1BDDC@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).