From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79624 [PATCH v2 07/56] net/txgbe: add EEPROM functions
Date: Mon, 5 Oct 2020 14:13:00 +0200 (CEST) [thread overview]
Message-ID: <20201005121300.DA6A61B737@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-8-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79624
_coding style issues_
WARNING:BRACES: braces {} are not necessary for single statement blocks
#135: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:25:
+ if (eeprom->type != txgbe_eeprom_unknown) {
+ return 0;
+ }
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#141: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:31:
+ * tested value */
WARNING:BRACES: braces {} are not necessary for single statement blocks
#597: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:487:
+ for (j = 0; j < seg; j++) {
+ checksum += buffer[j];
+ }
CHECK:SPACING: No space is necessary after a cast
#817: FILE: drivers/net/txgbe/base/txgbe_mng.c:24:
+ return (u8) (0 - sum);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#932: FILE: drivers/net/txgbe/base/txgbe_mng.c:139:
+ for (bi = 0; bi < dword_len; bi++) {
+ buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#942: FILE: drivers/net/txgbe/base/txgbe_mng.c:149:
+ for (; bi < dword_len + 2; bi++) {
+ buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#964: FILE: drivers/net/txgbe/base/txgbe_mng.c:171:
+ for (; bi <= dword_len; bi++) {
+ buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1012: FILE: drivers/net/txgbe/base/txgbe_mng.c:219:
+ for (i <<= 2; i < len; i++) {
+ ((u8 *)buf)[i] = ((u8 *)&value)[j++];
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1050: FILE: drivers/net/txgbe/base/txgbe_mng.c:257:
+ for (i <<= 2; i < len; i++) {
+ ((u8 *)&value)[j++] = ((u8 *)buf)[i];
+ }
WARNING:LONG_LINE: line over 100 characters
#1369: FILE: drivers/net/txgbe/base/txgbe_mng.h:171:
+s32 txgbe_hic_set_drv_ver(struct txgbe_hw *hw, u8 maj, u8 min, u8 build, u8 ver, u16 len, const char *str);
total: 0 errors, 9 warnings, 1 checks, 1320 lines checked
parent reply other threads:[~2020-10-05 12:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-8-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005121300.DA6A61B737@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).