From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4B990A04B1
	for <public@inbox.dpdk.org>; Mon,  5 Oct 2020 14:13:07 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id AB5A81B7FA;
	Mon,  5 Oct 2020 14:13:01 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id DA6A61B737; Mon,  5 Oct 2020 14:13:00 +0200 (CEST)
In-Reply-To: <20201005120910.189343-8-jiawenwu@trustnetic.com>
References: <20201005120910.189343-8-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20201005121300.DA6A61B737@dpdk.org>
Date: Mon,  5 Oct 2020 14:13:00 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw79624 [PATCH v2 07/56] net/txgbe:
	add EEPROM functions
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79624

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#135: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:25:
+	if (eeprom->type != txgbe_eeprom_unknown) {
+		return 0;
+	}

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#141: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:31:
+	 * tested value */

WARNING:BRACES: braces {} are not necessary for single statement blocks
#597: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:487:
+		for (j = 0; j < seg; j++) {
+			checksum += buffer[j];
+		}

CHECK:SPACING: No space is necessary after a cast
#817: FILE: drivers/net/txgbe/base/txgbe_mng.c:24:
+	return (u8) (0 - sum);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#932: FILE: drivers/net/txgbe/base/txgbe_mng.c:139:
+	for (bi = 0; bi < dword_len; bi++) {
+		buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#942: FILE: drivers/net/txgbe/base/txgbe_mng.c:149:
+		for (; bi < dword_len + 2; bi++) {
+			buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi);
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#964: FILE: drivers/net/txgbe/base/txgbe_mng.c:171:
+	for (; bi <= dword_len; bi++) {
+		buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1012: FILE: drivers/net/txgbe/base/txgbe_mng.c:219:
+	for (i <<= 2; i < len; i++) {
+		((u8 *)buf)[i] = ((u8 *)&value)[j++];
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#1050: FILE: drivers/net/txgbe/base/txgbe_mng.c:257:
+	for (i <<= 2; i < len; i++) {
+		((u8 *)&value)[j++] = ((u8 *)buf)[i];
+	}

WARNING:LONG_LINE: line over 100 characters
#1369: FILE: drivers/net/txgbe/base/txgbe_mng.h:171:
+s32 txgbe_hic_set_drv_ver(struct txgbe_hw *hw, u8 maj, u8 min, u8 build, u8 ver, u16 len, const char *str);

total: 0 errors, 9 warnings, 1 checks, 1320 lines checked