* [dpdk-test-report] |WARNING| pw79624 [PATCH v2 07/56] net/txgbe: add EEPROM functions
[not found] <20201005120910.189343-8-jiawenwu@trustnetic.com>
@ 2020-10-05 12:13 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-10-05 12:13 UTC (permalink / raw)
To: test-report; +Cc: Jiawen Wu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79624
_coding style issues_
WARNING:BRACES: braces {} are not necessary for single statement blocks
#135: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:25:
+ if (eeprom->type != txgbe_eeprom_unknown) {
+ return 0;
+ }
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#141: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:31:
+ * tested value */
WARNING:BRACES: braces {} are not necessary for single statement blocks
#597: FILE: drivers/net/txgbe/base/txgbe_eeprom.c:487:
+ for (j = 0; j < seg; j++) {
+ checksum += buffer[j];
+ }
CHECK:SPACING: No space is necessary after a cast
#817: FILE: drivers/net/txgbe/base/txgbe_mng.c:24:
+ return (u8) (0 - sum);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#932: FILE: drivers/net/txgbe/base/txgbe_mng.c:139:
+ for (bi = 0; bi < dword_len; bi++) {
+ buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#942: FILE: drivers/net/txgbe/base/txgbe_mng.c:149:
+ for (; bi < dword_len + 2; bi++) {
+ buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#964: FILE: drivers/net/txgbe/base/txgbe_mng.c:171:
+ for (; bi <= dword_len; bi++) {
+ buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1012: FILE: drivers/net/txgbe/base/txgbe_mng.c:219:
+ for (i <<= 2; i < len; i++) {
+ ((u8 *)buf)[i] = ((u8 *)&value)[j++];
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1050: FILE: drivers/net/txgbe/base/txgbe_mng.c:257:
+ for (i <<= 2; i < len; i++) {
+ ((u8 *)&value)[j++] = ((u8 *)buf)[i];
+ }
WARNING:LONG_LINE: line over 100 characters
#1369: FILE: drivers/net/txgbe/base/txgbe_mng.h:171:
+s32 txgbe_hic_set_drv_ver(struct txgbe_hw *hw, u8 maj, u8 min, u8 build, u8 ver, u16 len, const char *str);
total: 0 errors, 9 warnings, 1 checks, 1320 lines checked
^ permalink raw reply [flat|nested] only message in thread