From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79625 [PATCH v2 08/56] net/txgbe: add HW init and reset operation
Date: Mon, 5 Oct 2020 14:13:04 +0200 (CEST) [thread overview]
Message-ID: <20201005121304.456D61B9EE@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-9-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79625
_coding style issues_
WARNING:TYPO_SPELLING: 'adn' may be misspelled - perhaps 'and'?
#60:
Add hardware init function adn reset operation in mac layer.
WARNING:BRACES: braces {} are not necessary for single statement blocks
#180: FILE: drivers/net/txgbe/base/txgbe_hw.c:127:
+ for (i = 0; i < poll; i++) {
+ usec_delay(100);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#226: FILE: drivers/net/txgbe/base/txgbe_hw.c:288:
+ if (i == 10) {
+ err = TXGBE_ERR_FLASH_LOADING_FAILED;
+ }
CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#270: FILE: drivers/net/txgbe/base/txgbe_hw.c:332:
+ if (hw->phy.reset_disable == false)
CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#318: FILE: drivers/net/txgbe/base/txgbe_hw.c:380:
+ if (hw->mac.orig_link_settings_stored == false) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == txgbe_media_type_copper'
#444: FILE: drivers/net/txgbe/txgbe_ethdev.c:110:
+ if (err && (hw->phy.media_type == txgbe_media_type_copper)) {
CHECK:BRACES: braces {} should be used on all arms of this statement
#452: FILE: drivers/net/txgbe/txgbe_ethdev.c:118:
+ if (err == TXGBE_ERR_EEPROM_VERSION) {
[...]
+ } else if (err == TXGBE_ERR_SFP_NOT_SUPPORTED)
[...]
total: 0 errors, 3 warnings, 4 checks, 374 lines checked
parent reply other threads:[~2020-10-05 12:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-9-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005121304.456D61B9EE@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).