From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 59B7FA04B1
	for <public@inbox.dpdk.org>; Mon,  5 Oct 2020 14:13:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id C85D11BA45;
	Mon,  5 Oct 2020 14:13:04 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 456D61B9EE; Mon,  5 Oct 2020 14:13:04 +0200 (CEST)
In-Reply-To: <20201005120910.189343-9-jiawenwu@trustnetic.com>
References: <20201005120910.189343-9-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20201005121304.456D61B9EE@dpdk.org>
Date: Mon,  5 Oct 2020 14:13:04 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw79625 [PATCH v2 08/56] net/txgbe:
	add HW init and reset operation
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79625

_coding style issues_


WARNING:TYPO_SPELLING: 'adn' may be misspelled - perhaps 'and'?
#60: 
Add hardware init function adn reset operation in mac layer.

WARNING:BRACES: braces {} are not necessary for single statement blocks
#180: FILE: drivers/net/txgbe/base/txgbe_hw.c:127:
+	for (i = 0; i < poll; i++) {
+		usec_delay(100);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#226: FILE: drivers/net/txgbe/base/txgbe_hw.c:288:
+		if (i == 10) {
+			err = TXGBE_ERR_FLASH_LOADING_FAILED;
+		}

CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#270: FILE: drivers/net/txgbe/base/txgbe_hw.c:332:
+	if (hw->phy.reset_disable == false)

CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#318: FILE: drivers/net/txgbe/base/txgbe_hw.c:380:
+	if (hw->mac.orig_link_settings_stored == false) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == txgbe_media_type_copper'
#444: FILE: drivers/net/txgbe/txgbe_ethdev.c:110:
+	if (err && (hw->phy.media_type == txgbe_media_type_copper)) {

CHECK:BRACES: braces {} should be used on all arms of this statement
#452: FILE: drivers/net/txgbe/txgbe_ethdev.c:118:
+	if (err == TXGBE_ERR_EEPROM_VERSION) {
[...]
+	} else if (err == TXGBE_ERR_SFP_NOT_SUPPORTED)
[...]

total: 0 errors, 3 warnings, 4 checks, 374 lines checked