automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79627 [PATCH v2 09/56] net/txgbe: add PHY init
Date: Mon,  5 Oct 2020 14:13:13 +0200 (CEST)	[thread overview]
Message-ID: <20201005121313.B3D0B1B7FA@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-10-jiawenwu@trustnetic.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79627

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#261: FILE: drivers/net/txgbe/base/txgbe_phy.c:64:
+	if (hw->phy.nw_mng_if_sel & TXGBE_ETHPHYIF_MDIO_ACT) {
+		hw->phy.addr = TXGBE_ETHPHYIF_MDIO_BASE(hw->phy.nw_mng_if_sel);
+	}

WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#523: FILE: drivers/net/txgbe/base/txgbe_phy.h:67:
+#define TXGBE_PHY_AFE_DFE_ENABLE                0x01805D

WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#559: FILE: drivers/net/txgbe/base/txgbe_phy.h:103:
+#define TXGBE_PHY_AFE_DFE_ENABLE_DFE_EN0                        0x10

WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#560: FILE: drivers/net/txgbe/base/txgbe_phy.h:104:
+#define TXGBE_PHY_AFE_DFE_ENABLE_AFE_EN0                        0x1

WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#560: FILE: drivers/net/txgbe/base/txgbe_phy.h:104:
+#define TXGBE_PHY_AFE_DFE_ENABLE_AFE_EN0                        0x1

WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#561: FILE: drivers/net/txgbe/base/txgbe_phy.h:105:
+#define TXGBE_PHY_AFE_DFE_ENABLE_MASK                           0xFF

WARNING:TYPO_SPELLING: 'TRANSMITER' may be misspelled - perhaps 'TRANSMITTER'?
#662: FILE: drivers/net/txgbe/base/txgbe_phy.h:206:
+#define TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL	0x0

total: 0 errors, 7 warnings, 0 checks, 701 lines checked

           reply	other threads:[~2020-10-05 12:13 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20201005120910.189343-10-jiawenwu@trustnetic.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201005121313.B3D0B1B7FA@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).