From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79628 [PATCH v2 10/56] net/txgbe: add module identify
Date: Mon, 5 Oct 2020 14:14:58 +0200 (CEST) [thread overview]
Message-ID: <20201005121458.A38261B868@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-11-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79628
_coding style issues_
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#106: FILE: drivers/net/txgbe/base/txgbe_phy.c:11:
+STATIC void txgbe_i2c_stop(struct txgbe_hw *hw);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'connector ==
TXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE'
#402: FILE: drivers/net/txgbe/base/txgbe_phy.c:528:
+ if ((connector ==
+ TXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE) &&
+ (cable_length > 0) &&
+ ((device_tech >> 4) ==
+ TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cable_length > 0'
#402: FILE: drivers/net/txgbe/base/txgbe_phy.c:528:
+ if ((connector ==
+ TXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE) &&
+ (cable_length > 0) &&
+ ((device_tech >> 4) ==
+ TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL))
WARNING:TYPO_SPELLING: 'TRANSMITER' may be misspelled - perhaps 'TRANSMITTER'?
#406: FILE: drivers/net/txgbe/base/txgbe_phy.c:532:
+ TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL))
CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#477: FILE: drivers/net/txgbe/base/txgbe_phy.c:603:
+ if (hw->allow_unsupported_sfp == true) {
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#478: FILE: drivers/net/txgbe/base/txgbe_phy.c:604:
+ DEBUGOUT(
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#691: FILE: drivers/net/txgbe/base/txgbe_phy.c:817:
+
+}
total: 0 errors, 2 warnings, 5 checks, 649 lines checked
parent reply other threads:[~2020-10-05 12:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-11-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005121458.A38261B868@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).