From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9E3AEA04B1
	for <public@inbox.dpdk.org>; Mon,  5 Oct 2020 14:15:03 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2B4BA1B96F;
	Mon,  5 Oct 2020 14:15:00 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id A38261B868; Mon,  5 Oct 2020 14:14:58 +0200 (CEST)
In-Reply-To: <20201005120910.189343-11-jiawenwu@trustnetic.com>
References: <20201005120910.189343-11-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20201005121458.A38261B868@dpdk.org>
Date: Mon,  5 Oct 2020 14:14:58 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw79628 [PATCH v2 10/56] net/txgbe:
	add module identify
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79628

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#106: FILE: drivers/net/txgbe/base/txgbe_phy.c:11:
+STATIC void txgbe_i2c_stop(struct txgbe_hw *hw);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'connector ==
 				     TXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE'
#402: FILE: drivers/net/txgbe/base/txgbe_phy.c:528:
+			if ((connector ==
+				     TXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE) &&
+			    (cable_length > 0) &&
+			    ((device_tech >> 4) ==
+				     TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cable_length > 0'
#402: FILE: drivers/net/txgbe/base/txgbe_phy.c:528:
+			if ((connector ==
+				     TXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE) &&
+			    (cable_length > 0) &&
+			    ((device_tech >> 4) ==
+				     TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL))

WARNING:TYPO_SPELLING: 'TRANSMITER' may be misspelled - perhaps 'TRANSMITTER'?
#406: FILE: drivers/net/txgbe/base/txgbe_phy.c:532:
+				     TXGBE_SFF_QSFP_TRANSMITER_850NM_VCSEL))

CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#477: FILE: drivers/net/txgbe/base/txgbe_phy.c:603:
+				if (hw->allow_unsupported_sfp == true) {

CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#478: FILE: drivers/net/txgbe/base/txgbe_phy.c:604:
+					DEBUGOUT(

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#691: FILE: drivers/net/txgbe/base/txgbe_phy.c:817:
+
+}

total: 0 errors, 2 warnings, 5 checks, 649 lines checked