From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79631 [PATCH v2 15/56] net/txgbe: add link status change
Date: Mon, 5 Oct 2020 14:15:13 +0200 (CEST) [thread overview]
Message-ID: <20201005121513.3BD381BA57@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-16-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79631
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#59:
Add ethdev link interrupt handler, MAC setup link and check link status and get capabilities.
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#95: FILE: drivers/net/txgbe/base/txgbe_hw.c:15:
+STATIC s32 txgbe_setup_copper_link_raptor(struct txgbe_hw *hw,
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#115: FILE: drivers/net/txgbe/base/txgbe_hw.c:112:
+{
+
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#188: FILE: drivers/net/txgbe/base/txgbe_hw.c:185:
+ break;
+ } else {
CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_PMA_PMD_MASK>
#442: FILE: drivers/net/txgbe/base/txgbe_hw.c:631:
+ u64 pma_pmd_10gs = autoc & TXGBE_AUTOC_10Gs_PMA_PMD_MASK;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#460: FILE: drivers/net/txgbe/base/txgbe_hw.c:649:
+ if (speed == TXGBE_LINK_SPEED_UNKNOWN) {
+ return TXGBE_ERR_LINK_SETUP;
+ }
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.smart_speed_active == false'
#483: FILE: drivers/net/txgbe/base/txgbe_hw.c:672:
+ if ((orig_autoc & TXGBE_AUTOC_KR_SUPP) &&
+ (hw->phy.smart_speed_active == false))
CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#484: FILE: drivers/net/txgbe/base/txgbe_hw.c:673:
+ (hw->phy.smart_speed_active == false))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed == TXGBE_LINK_SPEED_10GB_FULL'
#493: FILE: drivers/net/txgbe/base/txgbe_hw.c:682:
+ if ((speed == TXGBE_LINK_SPEED_10GB_FULL) &&
+ (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI'
#493: FILE: drivers/net/txgbe/base/txgbe_hw.c:682:
+ if ((speed == TXGBE_LINK_SPEED_10GB_FULL) &&
+ (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI)) {
CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_SFI>
#494: FILE: drivers/net/txgbe/base/txgbe_hw.c:683:
+ (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI)) {
CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_LMS_10Gs>
#496: FILE: drivers/net/txgbe/base/txgbe_hw.c:685:
+ autoc |= TXGBE_AUTOC_LMS_10Gs;
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed == TXGBE_LINK_SPEED_1GB_FULL'
#501: FILE: drivers/net/txgbe/base/txgbe_hw.c:690:
+ if ((speed == TXGBE_LINK_SPEED_1GB_FULL) &&
+ (pma_pmd_1g == TXGBE_AUTOC_1G_SFI)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pma_pmd_1g == TXGBE_AUTOC_1G_SFI'
#501: FILE: drivers/net/txgbe/base/txgbe_hw.c:690:
+ if ((speed == TXGBE_LINK_SPEED_1GB_FULL) &&
+ (pma_pmd_1g == TXGBE_AUTOC_1G_SFI)) {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#511: FILE: drivers/net/txgbe/base/txgbe_hw.c:700:
+ if (autoc == current_autoc) {
+ return status;
+ }
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'status != 0'
#597: FILE: drivers/net/txgbe/base/txgbe_hw.c:933:
+ if ((status != 0) ||
+ (fw_offset == 0) || (fw_offset == 0xFFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_offset == 0'
#597: FILE: drivers/net/txgbe/base/txgbe_hw.c:933:
+ if ((status != 0) ||
+ (fw_offset == 0) || (fw_offset == 0xFFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_offset == 0xFFFF'
#597: FILE: drivers/net/txgbe/base/txgbe_hw.c:933:
+ if ((status != 0) ||
+ (fw_offset == 0) || (fw_offset == 0xFFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'status != 0'
#606: FILE: drivers/net/txgbe/base/txgbe_hw.c:942:
+ if ((status != 0) ||
+ (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_lesm_param_offset == 0'
#606: FILE: drivers/net/txgbe/base/txgbe_hw.c:942:
+ if ((status != 0) ||
+ (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_lesm_param_offset == 0xFFFF'
#606: FILE: drivers/net/txgbe/base/txgbe_hw.c:942:
+ if ((status != 0) ||
+ (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'status == 0'
#615: FILE: drivers/net/txgbe/base/txgbe_hw.c:951:
+ if ((status == 0) &&
+ (fw_lesm_state & TXGBE_FW_LESM_STATE_ENABLED))
WARNING:BRACES: braces {} are not necessary for single statement blocks
#640: FILE: drivers/net/txgbe/base/txgbe_hw.c:976:
+ if (autoc & TXGBE_AUTOC_LINK_DIA_MASK) {
+ autoc &= ~TXGBE_AUTOC_LINK_DIA_MASK;
+ }
CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#670: FILE: drivers/net/txgbe/base/txgbe_hw.h:22:
+extern s32 txgbe_reset_pipeline_raptor(struct txgbe_hw *hw);
total: 0 errors, 6 warnings, 18 checks, 1183 lines checked
parent reply other threads:[~2020-10-05 12:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-16-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005121513.3BD381BA57@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).