From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EC7FA04B1 for ; Mon, 5 Oct 2020 14:15:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 642131B868; Mon, 5 Oct 2020 14:15:14 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 3BD381BA57; Mon, 5 Oct 2020 14:15:13 +0200 (CEST) In-Reply-To: <20201005120910.189343-16-jiawenwu@trustnetic.com> References: <20201005120910.189343-16-jiawenwu@trustnetic.com> To: test-report@dpdk.org Cc: Jiawen Wu Message-Id: <20201005121513.3BD381BA57@dpdk.org> Date: Mon, 5 Oct 2020 14:15:13 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw79631 [PATCH v2 15/56] net/txgbe: add link status change X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/79631 _coding style issues_ WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #59: Add ethdev link interrupt handler, MAC setup link and check link status and get capabilities. WARNING:AVOID_EXTERNS: externs should be avoided in .c files #95: FILE: drivers/net/txgbe/base/txgbe_hw.c:15: +STATIC s32 txgbe_setup_copper_link_raptor(struct txgbe_hw *hw, CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #115: FILE: drivers/net/txgbe/base/txgbe_hw.c:112: +{ + WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return #188: FILE: drivers/net/txgbe/base/txgbe_hw.c:185: + break; + } else { CHECK:CAMELCASE: Avoid CamelCase: #442: FILE: drivers/net/txgbe/base/txgbe_hw.c:631: + u64 pma_pmd_10gs = autoc & TXGBE_AUTOC_10Gs_PMA_PMD_MASK; WARNING:BRACES: braces {} are not necessary for single statement blocks #460: FILE: drivers/net/txgbe/base/txgbe_hw.c:649: + if (speed == TXGBE_LINK_SPEED_UNKNOWN) { + return TXGBE_ERR_LINK_SETUP; + } CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.smart_speed_active == false' #483: FILE: drivers/net/txgbe/base/txgbe_hw.c:672: + if ((orig_autoc & TXGBE_AUTOC_KR_SUPP) && + (hw->phy.smart_speed_active == false)) CHECK:BOOL_COMPARISON: Using comparison to false is error prone #484: FILE: drivers/net/txgbe/base/txgbe_hw.c:673: + (hw->phy.smart_speed_active == false)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed == TXGBE_LINK_SPEED_10GB_FULL' #493: FILE: drivers/net/txgbe/base/txgbe_hw.c:682: + if ((speed == TXGBE_LINK_SPEED_10GB_FULL) && + (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI' #493: FILE: drivers/net/txgbe/base/txgbe_hw.c:682: + if ((speed == TXGBE_LINK_SPEED_10GB_FULL) && + (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI)) { CHECK:CAMELCASE: Avoid CamelCase: #494: FILE: drivers/net/txgbe/base/txgbe_hw.c:683: + (pma_pmd_10gs == TXGBE_AUTOC_10Gs_SFI)) { CHECK:CAMELCASE: Avoid CamelCase: #496: FILE: drivers/net/txgbe/base/txgbe_hw.c:685: + autoc |= TXGBE_AUTOC_LMS_10Gs; CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'speed == TXGBE_LINK_SPEED_1GB_FULL' #501: FILE: drivers/net/txgbe/base/txgbe_hw.c:690: + if ((speed == TXGBE_LINK_SPEED_1GB_FULL) && + (pma_pmd_1g == TXGBE_AUTOC_1G_SFI)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pma_pmd_1g == TXGBE_AUTOC_1G_SFI' #501: FILE: drivers/net/txgbe/base/txgbe_hw.c:690: + if ((speed == TXGBE_LINK_SPEED_1GB_FULL) && + (pma_pmd_1g == TXGBE_AUTOC_1G_SFI)) { WARNING:BRACES: braces {} are not necessary for single statement blocks #511: FILE: drivers/net/txgbe/base/txgbe_hw.c:700: + if (autoc == current_autoc) { + return status; + } CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'status != 0' #597: FILE: drivers/net/txgbe/base/txgbe_hw.c:933: + if ((status != 0) || + (fw_offset == 0) || (fw_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_offset == 0' #597: FILE: drivers/net/txgbe/base/txgbe_hw.c:933: + if ((status != 0) || + (fw_offset == 0) || (fw_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_offset == 0xFFFF' #597: FILE: drivers/net/txgbe/base/txgbe_hw.c:933: + if ((status != 0) || + (fw_offset == 0) || (fw_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'status != 0' #606: FILE: drivers/net/txgbe/base/txgbe_hw.c:942: + if ((status != 0) || + (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_lesm_param_offset == 0' #606: FILE: drivers/net/txgbe/base/txgbe_hw.c:942: + if ((status != 0) || + (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'fw_lesm_param_offset == 0xFFFF' #606: FILE: drivers/net/txgbe/base/txgbe_hw.c:942: + if ((status != 0) || + (fw_lesm_param_offset == 0) || (fw_lesm_param_offset == 0xFFFF)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'status == 0' #615: FILE: drivers/net/txgbe/base/txgbe_hw.c:951: + if ((status == 0) && + (fw_lesm_state & TXGBE_FW_LESM_STATE_ENABLED)) WARNING:BRACES: braces {} are not necessary for single statement blocks #640: FILE: drivers/net/txgbe/base/txgbe_hw.c:976: + if (autoc & TXGBE_AUTOC_LINK_DIA_MASK) { + autoc &= ~TXGBE_AUTOC_LINK_DIA_MASK; + } CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #670: FILE: drivers/net/txgbe/base/txgbe_hw.h:22: +extern s32 txgbe_reset_pipeline_raptor(struct txgbe_hw *hw); total: 0 errors, 6 warnings, 18 checks, 1183 lines checked