From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79633 [PATCH v2 16/56] net/txgbe: add multi-speed link setup
Date: Mon, 5 Oct 2020 14:17:00 +0200 (CEST) [thread overview]
Message-ID: <20201005121700.13BDA1BA45@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-17-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79633
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == txgbe_media_type_fiber'
#232: FILE: drivers/net/txgbe/base/txgbe_hw.c:505:
+ if ((hw->phy.media_type == txgbe_media_type_fiber) &&
+ !txgbe_mng_enabled(hw)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'link_speed == TXGBE_LINK_SPEED_1GB_FULL'
#488: FILE: drivers/net/txgbe/base/txgbe_hw.c:1005:
+ if (link_up && (link_speed == TXGBE_LINK_SPEED_1GB_FULL))
total: 0 errors, 0 warnings, 2 checks, 444 lines checked
parent reply other threads:[~2020-10-05 12:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-17-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005121700.13BDA1BA45@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).