From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6CF88A04BA
	for <public@inbox.dpdk.org>; Mon,  5 Oct 2020 14:17:04 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A13F91BA5D;
	Mon,  5 Oct 2020 14:17:01 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 13BDA1BA45; Mon,  5 Oct 2020 14:17:00 +0200 (CEST)
In-Reply-To: <20201005120910.189343-17-jiawenwu@trustnetic.com>
References: <20201005120910.189343-17-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20201005121700.13BDA1BA45@dpdk.org>
Date: Mon,  5 Oct 2020 14:17:00 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw79633 [PATCH v2 16/56] net/txgbe:
	add multi-speed link setup
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79633

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'hw->phy.media_type == txgbe_media_type_fiber'
#232: FILE: drivers/net/txgbe/base/txgbe_hw.c:505:
+	if ((hw->phy.media_type == txgbe_media_type_fiber) &&
+	    !txgbe_mng_enabled(hw)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'link_speed == TXGBE_LINK_SPEED_1GB_FULL'
#488: FILE: drivers/net/txgbe/base/txgbe_hw.c:1005:
+	if (link_up && (link_speed == TXGBE_LINK_SPEED_1GB_FULL))

total: 0 errors, 0 warnings, 2 checks, 444 lines checked