From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79634 [PATCH v2 17/56] net/txgbe: add autoc read and write
Date: Mon, 5 Oct 2020 14:17:07 +0200 (CEST) [thread overview]
Message-ID: <20201005121707.E6B371B774@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-18-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79634
_coding style issues_
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#116: FILE: drivers/net/txgbe/base/txgbe_phy.c:1402:
+ msleep(10);
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#129: FILE: drivers/net/txgbe/base/txgbe_phy.c:1415:
+ msleep(1);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#131: FILE: drivers/net/txgbe/base/txgbe_phy.c:1417:
+ * for corresponding LAN port */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#158: FILE: drivers/net/txgbe/base/txgbe_phy.c:1444:
+ * Control1 Register Bit[15](VR_RST) */
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17)
#173: FILE: drivers/net/txgbe/base/txgbe_phy.c:1459:
+ } else {
+ wr32_epcs(hw, VR_AN_KR_MODE_CL, 0x1);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#188: FILE: drivers/net/txgbe/base/txgbe_phy.c:1474:
+ if (hw->link_status == TXGBE_LINK_STATUS_KX4) {
+ goto out;
+ }
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#198: FILE: drivers/net/txgbe/base/txgbe_phy.c:1484:
+ msleep(10);
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#217: FILE: drivers/net/txgbe/base/txgbe_phy.c:1503:
+ msleep(1);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#220: FILE: drivers/net/txgbe/base/txgbe_phy.c:1506:
+ * for corresponding LAN port */
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#262: FILE: drivers/net/txgbe/base/txgbe_phy.c:1548:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY MPLLA
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#268: FILE: drivers/net/txgbe/base/txgbe_phy.c:1554:
+ /* Set VR XS, PMA or MII Synopsys Enterprise Gen5 12G PHY MPLLA
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#274: FILE: drivers/net/txgbe/base/txgbe_phy.c:1560:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#280: FILE: drivers/net/txgbe/base/txgbe_phy.c:1566:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#286: FILE: drivers/net/txgbe/base/txgbe_phy.c:1572:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#291: FILE: drivers/net/txgbe/base/txgbe_phy.c:1577:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#296: FILE: drivers/net/txgbe/base/txgbe_phy.c:1582:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#301: FILE: drivers/net/txgbe/base/txgbe_phy.c:1587:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#306: FILE: drivers/net/txgbe/base/txgbe_phy.c:1592:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY AFE-DFE
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#306: FILE: drivers/net/txgbe/base/txgbe_phy.c:1592:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY AFE-DFE
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#307: FILE: drivers/net/txgbe/base/txgbe_phy.c:1593:
+ * Enable Register Bit[7:0] = 8'd0 //AFE_EN_0/3_1, DFE_EN_0/3_1
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#309: FILE: drivers/net/txgbe/base/txgbe_phy.c:1595:
+ wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, 0x0);
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#311: FILE: drivers/net/txgbe/base/txgbe_phy.c:1597:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#316: FILE: drivers/net/txgbe/base/txgbe_phy.c:1602:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Tx Rate
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#322: FILE: drivers/net/txgbe/base/txgbe_phy.c:1608:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx Rate
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#328: FILE: drivers/net/txgbe/base/txgbe_phy.c:1614:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Tx General
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#333: FILE: drivers/net/txgbe/base/txgbe_phy.c:1619:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx General
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#338: FILE: drivers/net/txgbe/base/txgbe_phy.c:1624:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY MPLLA Control
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#350: FILE: drivers/net/txgbe/base/txgbe_phy.c:1636:
+ * Register Bit[15](VR_RST) */
WARNING:BRACES: braces {} are not necessary for single statement blocks
#384: FILE: drivers/net/txgbe/base/txgbe_phy.c:1670:
+ if (hw->link_status == TXGBE_LINK_STATUS_KX) {
+ goto out;
+ }
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#394: FILE: drivers/net/txgbe/base/txgbe_phy.c:1680:
+ msleep(10);
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#413: FILE: drivers/net/txgbe/base/txgbe_phy.c:1699:
+ msleep(1);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#416: FILE: drivers/net/txgbe/base/txgbe_phy.c:1702:
+ * for corresponding LAN port */
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#472: FILE: drivers/net/txgbe/base/txgbe_phy.c:1758:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY MPLLA Control
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#478: FILE: drivers/net/txgbe/base/txgbe_phy.c:1764:
+ /* Set VR XS, PMA or MII Synopsys Enterprise Gen5 12G PHY MPLLA Control
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#484: FILE: drivers/net/txgbe/base/txgbe_phy.c:1770:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#494: FILE: drivers/net/txgbe/base/txgbe_phy.c:1780:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY VCO
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#502: FILE: drivers/net/txgbe/base/txgbe_phy.c:1788:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY AFE-DFE
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#502: FILE: drivers/net/txgbe/base/txgbe_phy.c:1788:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY AFE-DFE
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#503: FILE: drivers/net/txgbe/base/txgbe_phy.c:1789:
+ * Enable Register Bit[4], Bit[0] = 1'b0 //AFE_EN_0, DFE_EN_0
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#505: FILE: drivers/net/txgbe/base/txgbe_phy.c:1791:
+ wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE,
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#507: FILE: drivers/net/txgbe/base/txgbe_phy.c:1793:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#512: FILE: drivers/net/txgbe/base/txgbe_phy.c:1798:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Tx Rate
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#518: FILE: drivers/net/txgbe/base/txgbe_phy.c:1804:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx Rate
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#524: FILE: drivers/net/txgbe/base/txgbe_phy.c:1810:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Tx General
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#529: FILE: drivers/net/txgbe/base/txgbe_phy.c:1815:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY Rx General
WARNING:TYPO_SPELLING: 'Synopsys' may be misspelled - perhaps 'Synopsis'?
#534: FILE: drivers/net/txgbe/base/txgbe_phy.c:1820:
+ /* Set VR XS, PMA, or MII Synopsys Enterprise Gen5 12G PHY MPLLA Control
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#588: FILE: drivers/net/txgbe/base/txgbe_phy.c:1874:
+ msleep(10);
WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#604: FILE: drivers/net/txgbe/base/txgbe_phy.c:1890:
+ msleep(1);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#606: FILE: drivers/net/txgbe/base/txgbe_phy.c:1892:
+ * for corresponding LAN port */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#701: FILE: drivers/net/txgbe/base/txgbe_phy.c:1987:
+ * Bit[7:0](DFE_TAP1_0) = 8'd20 */
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#703: FILE: drivers/net/txgbe/base/txgbe_phy.c:1989:
+ value = rd32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE);
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#705: FILE: drivers/net/txgbe/base/txgbe_phy.c:1991:
+ wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, value);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#708: FILE: drivers/net/txgbe/base/txgbe_phy.c:1994:
+ * Bit[7:0](DFE_TAP1_0) = 8'd20 */
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#710: FILE: drivers/net/txgbe/base/txgbe_phy.c:1996:
+ /* 9. Set VR_MII_Gen5_12G_AFE_DFE_EN_CTRL Register
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#711: FILE: drivers/net/txgbe/base/txgbe_phy.c:1997:
+ * Bit[4](DFE_EN_0) = 1'b0, Bit[0](AFE_EN_0) = 1'b0 */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#711: FILE: drivers/net/txgbe/base/txgbe_phy.c:1997:
+ * Bit[4](DFE_EN_0) = 1'b0, Bit[0](AFE_EN_0) = 1'b0 */
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#712: FILE: drivers/net/txgbe/base/txgbe_phy.c:1998:
+ value = rd32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE);
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#714: FILE: drivers/net/txgbe/base/txgbe_phy.c:2000:
+ wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, value);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#735: FILE: drivers/net/txgbe/base/txgbe_phy.c:2021:
+ * Bit[12:8](RX_VREF_CTRL) = 5'hF */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#738: FILE: drivers/net/txgbe/base/txgbe_phy.c:2024:
+ * Bit[13:8](TX_EQ_MAIN) = 6'd30, Bit[5:0](TX_EQ_PRE) = 6'd4 */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#743: FILE: drivers/net/txgbe/base/txgbe_phy.c:2029:
+ * (TX_EQ_OVR_RIDE) = 1'b1, Bit[5:0](TX_EQ_POST) = 6'd36 */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#764: FILE: drivers/net/txgbe/base/txgbe_phy.c:2050:
+ * Bit[7:0](DFE_TAP1_0) = 8'd00 */
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#766: FILE: drivers/net/txgbe/base/txgbe_phy.c:2052:
+ /* 9. Set VR_MII_Gen5_12G_AFE_DFE_EN_CTRL Register
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#767: FILE: drivers/net/txgbe/base/txgbe_phy.c:2053:
+ * Bit[4](DFE_EN_0) = 1'b0, Bit[0](AFE_EN_0) = 1'b0 */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#767: FILE: drivers/net/txgbe/base/txgbe_phy.c:2053:
+ * Bit[4](DFE_EN_0) = 1'b0, Bit[0](AFE_EN_0) = 1'b0 */
WARNING:TYPO_SPELLING: 'AFE' may be misspelled - perhaps 'SAFE'?
#775: FILE: drivers/net/txgbe/base/txgbe_phy.c:2061:
+ wr32_epcs(hw, TXGBE_PHY_AFE_DFE_ENABLE, 0x0);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#785: FILE: drivers/net/txgbe/base/txgbe_phy.c:2071:
+ * Register Bit[15](VR_RST) */
CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_LMS_10Gs>
#817: FILE: drivers/net/txgbe/base/txgbe_phy.c:2103:
+ autoc |= TXGBE_AUTOC_LMS_10Gs;
CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_SFI>
#821: FILE: drivers/net/txgbe/base/txgbe_phy.c:2107:
+ TXGBE_AUTOC_10Gs_SFI;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#834: FILE: drivers/net/txgbe/base/txgbe_phy.c:2120:
+ if (hw->device_id != TXGBE_DEV_ID_RAPTOR_SGMII) {
+ return autoc;
+ }
CHECK:CAMELCASE: Avoid CamelCase: <TXGBE_AUTOC_10Gs_KR>
#862: FILE: drivers/net/txgbe/base/txgbe_phy.c:2148:
+ TXGBE_AUTOC_10Gs_KR;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#866: FILE: drivers/net/txgbe/base/txgbe_phy.c:2152:
+ if (sr_an_adv_reg2 & SR_AN_MMD_ADV_REG2_BP_TYPE_KR) {
+ autoc |= TXGBE_AUTOC_10G_KR;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#869: FILE: drivers/net/txgbe/base/txgbe_phy.c:2155:
+ if (sr_an_adv_reg2 & SR_AN_MMD_ADV_REG2_BP_TYPE_KX4) {
+ autoc |= TXGBE_AUTOC_10G_KX4;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#872: FILE: drivers/net/txgbe/base/txgbe_phy.c:2158:
+ if (sr_an_adv_reg2 & SR_AN_MMD_ADV_REG2_BP_TYPE_KX) {
+ autoc |= TXGBE_AUTOC_1G_KX;
+ }
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#929: FILE: drivers/net/txgbe/base/txgbe_phy.c:2215:
+ if (speed == TXGBE_LINK_SPEED_10GB_FULL) {
[...]
+ } else if (speed == TXGBE_LINK_SPEED_1GB_FULL) {
[...]
total: 0 errors, 72 warnings, 3 checks, 899 lines checked
parent reply other threads:[~2020-10-05 12:17 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-18-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005121707.E6B371B774@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).