From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDCA4A04B1 for ; Mon, 5 Oct 2020 14:17:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C682D1BABD; Mon, 5 Oct 2020 14:17:13 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id BAC2D1BAB9; Mon, 5 Oct 2020 14:17:12 +0200 (CEST) In-Reply-To: <20201005120910.189343-19-jiawenwu@trustnetic.com> References: <20201005120910.189343-19-jiawenwu@trustnetic.com> To: test-report@dpdk.org Cc: Jiawen Wu Message-Id: <20201005121712.BAC2D1BAB9@dpdk.org> Date: Mon, 5 Oct 2020 14:17:12 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw79635 [PATCH v2 18/56] net/txgbe: add MAC address operations X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/79635 _coding style issues_ WARNING:AVOID_EXTERNS: externs should be avoided in .c files #125: FILE: drivers/net/txgbe/base/txgbe_hw.c:20: +STATIC s32 txgbe_mta_vector(struct txgbe_hw *hw, u8 *mc_addr); WARNING:AVOID_EXTERNS: externs should be avoided in .c files #126: FILE: drivers/net/txgbe/base/txgbe_hw.c:21: +STATIC s32 txgbe_get_san_mac_addr_offset(struct txgbe_hw *hw, WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_update_mc_addr_list', this function's name, in a string #468: FILE: drivers/net/txgbe/base/txgbe_hw.c:433: + DEBUGOUT("txgbe_update_mc_addr_list Complete "); total: 0 errors, 3 warnings, 0 checks, 702 lines checked