From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AFB2A04B1 for ; Mon, 5 Oct 2020 14:17:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F15751BA57; Mon, 5 Oct 2020 14:17:21 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 8D8921BA9E; Mon, 5 Oct 2020 14:17:20 +0200 (CEST) In-Reply-To: <20201005120910.189343-22-jiawenwu@trustnetic.com> References: <20201005120910.189343-22-jiawenwu@trustnetic.com> To: test-report@dpdk.org Cc: Jiawen Wu Message-Id: <20201005121720.8D8921BA9E@dpdk.org> Date: Mon, 5 Oct 2020 14:17:20 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw79637 [PATCH v2 21/56] net/txgbe: add RX and TX queues setup and release X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/79637 _coding style issues_ WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #146: FILE: drivers/net/txgbe/txgbe_rxtx.c:89: + unsigned i; CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc > TXGBE_RING_DESC_MAX' #224: FILE: drivers/net/txgbe/txgbe_rxtx.c:199: + if (nb_desc % TXGBE_TXD_ALIGN != 0 || + (nb_desc > TXGBE_RING_DESC_MAX) || + (nb_desc < TXGBE_RING_DESC_MIN)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc < TXGBE_RING_DESC_MIN' #224: FILE: drivers/net/txgbe/txgbe_rxtx.c:199: + if (nb_desc % TXGBE_TXD_ALIGN != 0 || + (nb_desc > TXGBE_RING_DESC_MAX) || + (nb_desc < TXGBE_RING_DESC_MIN)) { CHECK:SPACING: No space is necessary after a cast #308: FILE: drivers/net/txgbe/txgbe_rxtx.c:283: + txq->tx_ring = (struct txgbe_tx_desc *) TMZ_VADDR(tz); CHECK:CAMELCASE: Avoid CamelCase: #318: FILE: drivers/net/txgbe/txgbe_rxtx.c:293: + PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%"PRIx64, CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #318: FILE: drivers/net/txgbe/txgbe_rxtx.c:293: + PMD_INIT_LOG(DEBUG, "sw_ring=%p hw_ring=%p dma_addr=0x%"PRIx64, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #359: FILE: drivers/net/txgbe/txgbe_rxtx.c:334: + unsigned i; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #453: FILE: drivers/net/txgbe/txgbe_rxtx.c:428: + unsigned i; WARNING:BRACES: braces {} are not necessary for single statement blocks #470: FILE: drivers/net/txgbe/txgbe_rxtx.c:445: + for (i = 0; i < len; i++) { + rxq->rx_ring[i] = zeroed_desc; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #479: FILE: drivers/net/txgbe/txgbe_rxtx.c:454: + for (i = rxq->nb_rx_desc; i < len; ++i) { + rxq->sw_ring[i].mbuf = &rxq->fake_mbuf; + } CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #491: FILE: drivers/net/txgbe/txgbe_rxtx.c:466: + +} CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc > TXGBE_RING_DESC_MAX' #518: FILE: drivers/net/txgbe/txgbe_rxtx.c:493: + if (nb_desc % TXGBE_RXD_ALIGN != 0 || + (nb_desc > TXGBE_RING_DESC_MAX) || + (nb_desc < TXGBE_RING_DESC_MIN)) { CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'nb_desc < TXGBE_RING_DESC_MIN' #518: FILE: drivers/net/txgbe/txgbe_rxtx.c:493: + if (nb_desc % TXGBE_RXD_ALIGN != 0 || + (nb_desc > TXGBE_RING_DESC_MAX) || + (nb_desc < TXGBE_RING_DESC_MIN)) { CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #639: FILE: drivers/net/txgbe/txgbe_rxtx.c:614: + "dma_addr=0x%"PRIx64, CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #775: FILE: drivers/net/txgbe/txgbe_rxtx.h:122: + struct rte_mbuf *rx_stage[RTE_PMD_TXGBE_RX_MAX_BURST*2]; ^ total: 0 errors, 5 warnings, 10 checks, 728 lines checked