From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79640 [PATCH v2 24/56] net/txgbe: fill simple transmit function
Date: Tue, 6 Oct 2020 11:42:38 +0200 (CEST) [thread overview]
Message-ID: <20201006094238.E15302C6E@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-25-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79640
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around txq->sw_ring[txq->tx_next_dd - (txq->tx_free_thresh - 1)]
#107: FILE: drivers/net/txgbe/txgbe_rxtx.c:72:
+ txep = &(txq->sw_ring[txq->tx_next_dd - (txq->tx_free_thresh - 1)]);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around txq->tx_ring[txq->tx_tail]
#187: FILE: drivers/net/txgbe/txgbe_rxtx.c:152:
+ volatile struct txgbe_tx_desc *txdp = &(txq->tx_ring[txq->tx_tail]);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around txq->sw_ring[txq->tx_tail]
#188: FILE: drivers/net/txgbe/txgbe_rxtx.c:153:
+ struct txgbe_tx_entry *txep = &(txq->sw_ring[txq->tx_tail]);
CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#190: FILE: drivers/net/txgbe/txgbe_rxtx.c:155:
+ const int N_PER_LOOP_MASK = N_PER_LOOP-1;
^
CHECK:SPACING: No space is necessary after a cast
#198: FILE: drivers/net/txgbe/txgbe_rxtx.c:163:
+ mainpart = (nb_pkts & ((uint32_t) ~N_PER_LOOP_MASK));
CHECK:SPACING: No space is necessary after a cast
#199: FILE: drivers/net/txgbe/txgbe_rxtx.c:164:
+ leftover = (nb_pkts & ((uint32_t) N_PER_LOOP_MASK));
WARNING:BRACES: braces {} are not necessary for single statement blocks
#202: FILE: drivers/net/txgbe/txgbe_rxtx.c:167:
+ for (j = 0; j < N_PER_LOOP; ++j) {
+ (txep + i + j)->mbuf = *(pkts + i + j);
+ }
CHECK:SPACING: No space is necessary after a cast
#269: FILE: drivers/net/txgbe/txgbe_rxtx.c:234:
+ (unsigned) txq->port_id, (unsigned) txq->queue_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#269: FILE: drivers/net/txgbe/txgbe_rxtx.c:234:
+ (unsigned) txq->port_id, (unsigned) txq->queue_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#269: FILE: drivers/net/txgbe/txgbe_rxtx.c:234:
+ (unsigned) txq->port_id, (unsigned) txq->queue_id,
CHECK:SPACING: No space is necessary after a cast
#270: FILE: drivers/net/txgbe/txgbe_rxtx.c:235:
+ (unsigned) txq->tx_tail, (unsigned) nb_pkts);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#270: FILE: drivers/net/txgbe/txgbe_rxtx.c:235:
+ (unsigned) txq->tx_tail, (unsigned) nb_pkts);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#270: FILE: drivers/net/txgbe/txgbe_rxtx.c:235:
+ (unsigned) txq->tx_tail, (unsigned) nb_pkts);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around tx_pkts[nb_tx]
#295: FILE: drivers/net/txgbe/txgbe_rxtx.c:260:
+ ret = tx_xmit_pkts(tx_queue, &(tx_pkts[nb_tx]), n);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->offloads == 0'
#315: FILE: drivers/net/txgbe/txgbe_rxtx.c:366:
+ if ((txq->offloads == 0) &&
+ (txq->tx_free_thresh >= RTE_PMD_TXGBE_TX_MAX_BURST)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->tx_free_thresh >= RTE_PMD_TXGBE_TX_MAX_BURST'
#315: FILE: drivers/net/txgbe/txgbe_rxtx.c:366:
+ if ((txq->offloads == 0) &&
+ (txq->tx_free_thresh >= RTE_PMD_TXGBE_TX_MAX_BURST)) {
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#334: FILE: drivers/net/txgbe/txgbe_rxtx.h:55:
+ * Transmit Descriptor
+******************************************************************************/
total: 0 errors, 6 warnings, 11 checks, 353 lines checked
parent reply other threads:[~2020-10-06 9:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-25-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006094238.E15302C6E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).