From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DC98A04BB for ; Tue, 6 Oct 2020 11:42:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05ED92952; Tue, 6 Oct 2020 11:42:47 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id 25AE02BC7; Tue, 6 Oct 2020 11:42:45 +0200 (CEST) In-Reply-To: <20201005120910.189343-26-jiawenwu@trustnetic.com> References: <20201005120910.189343-26-jiawenwu@trustnetic.com> To: test-report@dpdk.org Cc: Jiawen Wu Message-Id: <20201006094245.25AE02BC7@dpdk.org> Date: Tue, 6 Oct 2020 11:42:45 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw79641 [PATCH v2 25/56] net/txgbe: fill transmit function with hardware offload X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/79641 _coding style issues_ CHECK:SPACING: spaces preferred around that '-' (ctx:VxV) #133: FILE: drivers/net/txgbe/txgbe_ethdev.c:132: + txq = eth_dev->data->tx_queues[eth_dev->data->nb_tx_queues-1]; ^ CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #174: FILE: drivers/net/txgbe/txgbe_rxtx.c:29: +static const u64 TXGBE_TX_OFFLOAD_MASK = ( CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->ctx_cache[txq->ctx_curr].flags == flags' #313: FILE: drivers/net/txgbe/txgbe_rxtx.c:403: + if (likely((txq->ctx_cache[txq->ctx_curr].flags == flags) && + (txq->ctx_cache[txq->ctx_curr].tx_offload.data[0] == + (txq->ctx_cache[txq->ctx_curr].tx_offload_mask.data[0] + & tx_offload.data[0])) && + (txq->ctx_cache[txq->ctx_curr].tx_offload.data[1] == + (txq->ctx_cache[txq->ctx_curr].tx_offload_mask.data[1] + & tx_offload.data[1])))) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'txq->ctx_cache[txq->ctx_curr].flags == flags' #324: FILE: drivers/net/txgbe/txgbe_rxtx.c:414: + if (likely((txq->ctx_cache[txq->ctx_curr].flags == flags) && + (txq->ctx_cache[txq->ctx_curr].tx_offload.data[0] == + (txq->ctx_cache[txq->ctx_curr].tx_offload_mask.data[0] + & tx_offload.data[0])) && + (txq->ctx_cache[txq->ctx_curr].tx_offload.data[1] == + (txq->ctx_cache[txq->ctx_curr].tx_offload_mask.data[1] + & tx_offload.data[1])))) WARNING:BRACES: braces {} are not necessary for single statement blocks #361: FILE: drivers/net/txgbe/txgbe_rxtx.c:451: + if (ol_flags & PKT_TX_VLAN_PKT) { + tmp |= TXGBE_TXD_CC; + } WARNING:TYPO_SPELLING: 'suport' may be misspelled - perhaps 'support'? #390: FILE: drivers/net/txgbe/txgbe_rxtx.c:480: + /* Only suport flags in TXGBE_TX_OFFLOAD_MASK */ WARNING:BRACES: braces {} are not necessary for single statement blocks #395: FILE: drivers/net/txgbe/txgbe_rxtx.c:485: + if (oflags & PKT_TX_VLAN) { + ptype |= RTE_PTYPE_L2_ETHER_VLAN; + } WARNING:BRACES: braces {} are not necessary for any arm of this statement #400: FILE: drivers/net/txgbe/txgbe_rxtx.c:490: + if (oflags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IP_CKSUM)) { [...] + } else if (oflags & (PKT_TX_OUTER_IPV6)) { [...] WARNING:BRACES: braces {} are not necessary for any arm of this statement #406: FILE: drivers/net/txgbe/txgbe_rxtx.c:496: + if (oflags & (PKT_TX_IPV4 | PKT_TX_IP_CKSUM)) { [...] + } else if (oflags & (PKT_TX_IPV6)) { [...] WARNING:BRACES: braces {} are not necessary for single statement blocks #425: FILE: drivers/net/txgbe/txgbe_rxtx.c:515: + if (oflags & PKT_TX_TCP_SEG) { + ptype |= (tun ? RTE_PTYPE_INNER_L4_TCP : RTE_PTYPE_L4_TCP); + } CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #622: FILE: drivers/net/txgbe/txgbe_rxtx.c:712: + tx_offload.ptid = tx_desc_ol_flags_to_ptid( CHECK:SPACING: No space is necessary after a cast #655: FILE: drivers/net/txgbe/txgbe_rxtx.c:745: + tx_last = (uint16_t) (tx_id + nb_used - 1); CHECK:SPACING: No space is necessary after a cast #659: FILE: drivers/net/txgbe/txgbe_rxtx.c:749: + tx_last = (uint16_t) (tx_last - txq->nb_tx_desc); CHECK:SPACING: No space is necessary after a cast #663: FILE: drivers/net/txgbe/txgbe_rxtx.c:753: + (unsigned) txq->port_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #663: FILE: drivers/net/txgbe/txgbe_rxtx.c:753: + (unsigned) txq->port_id, CHECK:SPACING: No space is necessary after a cast #664: FILE: drivers/net/txgbe/txgbe_rxtx.c:754: + (unsigned) txq->queue_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #664: FILE: drivers/net/txgbe/txgbe_rxtx.c:754: + (unsigned) txq->queue_id, CHECK:SPACING: No space is necessary after a cast #665: FILE: drivers/net/txgbe/txgbe_rxtx.c:755: + (unsigned) pkt_len, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #665: FILE: drivers/net/txgbe/txgbe_rxtx.c:755: + (unsigned) pkt_len, CHECK:SPACING: No space is necessary after a cast #666: FILE: drivers/net/txgbe/txgbe_rxtx.c:756: + (unsigned) tx_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #666: FILE: drivers/net/txgbe/txgbe_rxtx.c:756: + (unsigned) tx_id, CHECK:SPACING: No space is necessary after a cast #667: FILE: drivers/net/txgbe/txgbe_rxtx.c:757: + (unsigned) tx_last); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #667: FILE: drivers/net/txgbe/txgbe_rxtx.c:757: + (unsigned) tx_last); WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring #713: FILE: drivers/net/txgbe/txgbe_rxtx.c:803: + if (nb_tx == 0) CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #751: FILE: drivers/net/txgbe/txgbe_rxtx.c:841: + if (tx_ol_req) { + WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #754: FILE: drivers/net/txgbe/txgbe_rxtx.c:844: + * not the packet len but the tcp payload len */ CHECK:SPACING: No space is necessary after a cast #841: FILE: drivers/net/txgbe/txgbe_rxtx.c:931: + (unsigned) txq->port_id, (unsigned) txq->queue_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #841: FILE: drivers/net/txgbe/txgbe_rxtx.c:931: + (unsigned) txq->port_id, (unsigned) txq->queue_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #841: FILE: drivers/net/txgbe/txgbe_rxtx.c:931: + (unsigned) txq->port_id, (unsigned) txq->queue_id, CHECK:SPACING: No space is necessary after a cast #842: FILE: drivers/net/txgbe/txgbe_rxtx.c:932: + (unsigned) tx_id, (unsigned) nb_tx); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #842: FILE: drivers/net/txgbe/txgbe_rxtx.c:932: + (unsigned) tx_id, (unsigned) nb_tx); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #842: FILE: drivers/net/txgbe/txgbe_rxtx.c:932: + (unsigned) tx_id, (unsigned) nb_tx); CHECK:CAMELCASE: Avoid CamelCase: #859: FILE: drivers/net/txgbe/txgbe_rxtx.c:1039: + " - offloads = 0x%" PRIx64, WARNING:STRING_FRAGMENTS: Consecutive strings are generally better as a single string #862: FILE: drivers/net/txgbe/txgbe_rxtx.c:1042: + " - tx_free_thresh = %lu " "[RTE_PMD_TXGBE_TX_MAX_BURST=%lu]", total: 0 errors, 18 warnings, 16 checks, 832 lines checked