From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79644 [PATCH v2 27/56] net/txgbe: fill receive functions
Date: Tue, 6 Oct 2020 11:42:58 +0200 (CEST) [thread overview]
Message-ID: <20201006094258.C85832BC7@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-28-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79644
_coding style issues_
WARNING:IF_1: Consider removing the #if 1 and its #endif
#214: FILE: drivers/net/txgbe/txgbe_rxtx.c:57:
+#if 1
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#373: FILE: drivers/net/txgbe/txgbe_rxtx.c:1158:
+ pkt_flags |= txgbe_rxd_pkt_info_to_pkt_flags(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#376: FILE: drivers/net/txgbe/txgbe_rxtx.c:1161:
+ mb->packet_type = txgbe_rxd_pkt_info_to_pkt_type(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#380: FILE: drivers/net/txgbe/txgbe_rxtx.c:1165:
+ mb->hash.rss = rte_le_to_cpu_32(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#383: FILE: drivers/net/txgbe/txgbe_rxtx.c:1168:
+ mb->hash.fdir.hash = rte_le_to_cpu_16(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#386: FILE: drivers/net/txgbe/txgbe_rxtx.c:1171:
+ mb->hash.fdir.id = rte_le_to_cpu_16(
WARNING:BRACES: braces {} are not necessary for single statement blocks
#392: FILE: drivers/net/txgbe/txgbe_rxtx.c:1177:
+ for (j = 0; j < LOOK_AHEAD; ++j) {
+ rxq->rx_stage[i + j] = rxep[j].mbuf;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#402: FILE: drivers/net/txgbe/txgbe_rxtx.c:1187:
+ for (i = 0; i < nb_rx; ++i) {
+ rxq->sw_ring[rxq->rx_tail + i].mbuf = NULL;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#431: FILE: drivers/net/txgbe/txgbe_rxtx.c:1216:
+ if (reset_mbuf) {
+ mb->port = rxq->port_id;
+ }
CHECK:SPACING: No space is necessary after a cast
#501: FILE: drivers/net/txgbe/txgbe_rxtx.c:1286:
+ "queue_id=%u", (unsigned) rxq->port_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#501: FILE: drivers/net/txgbe/txgbe_rxtx.c:1286:
+ "queue_id=%u", (unsigned) rxq->port_id,
CHECK:SPACING: No space is necessary after a cast
#502: FILE: drivers/net/txgbe/txgbe_rxtx.c:1287:
+ (unsigned) rxq->queue_id);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#502: FILE: drivers/net/txgbe/txgbe_rxtx.c:1287:
+ (unsigned) rxq->queue_id);
CHECK:SPACING: No space is necessary after a cast
#633: FILE: drivers/net/txgbe/txgbe_rxtx.c:1418:
+ (unsigned) rxq->port_id, (unsigned) rxq->queue_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#633: FILE: drivers/net/txgbe/txgbe_rxtx.c:1418:
+ (unsigned) rxq->port_id, (unsigned) rxq->queue_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#633: FILE: drivers/net/txgbe/txgbe_rxtx.c:1418:
+ (unsigned) rxq->port_id, (unsigned) rxq->queue_id,
CHECK:SPACING: No space is necessary after a cast
#634: FILE: drivers/net/txgbe/txgbe_rxtx.c:1419:
+ (unsigned) rx_id, (unsigned) staterr,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#634: FILE: drivers/net/txgbe/txgbe_rxtx.c:1419:
+ (unsigned) rx_id, (unsigned) staterr,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#634: FILE: drivers/net/txgbe/txgbe_rxtx.c:1419:
+ (unsigned) rx_id, (unsigned) staterr,
CHECK:SPACING: No space is necessary after a cast
#635: FILE: drivers/net/txgbe/txgbe_rxtx.c:1420:
+ (unsigned) rte_le_to_cpu_16(rxd.qw1.hi.len));
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#635: FILE: drivers/net/txgbe/txgbe_rxtx.c:1420:
+ (unsigned) rte_le_to_cpu_16(rxd.qw1.hi.len));
CHECK:SPACING: No space is necessary after a cast
#640: FILE: drivers/net/txgbe/txgbe_rxtx.c:1425:
+ "queue_id=%u", (unsigned) rxq->port_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#640: FILE: drivers/net/txgbe/txgbe_rxtx.c:1425:
+ "queue_id=%u", (unsigned) rxq->port_id,
CHECK:SPACING: No space is necessary after a cast
#641: FILE: drivers/net/txgbe/txgbe_rxtx.c:1426:
+ (unsigned) rxq->queue_id);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#641: FILE: drivers/net/txgbe/txgbe_rxtx.c:1426:
+ (unsigned) rxq->queue_id);
CHECK:SPACING: No space is necessary after a cast
#684: FILE: drivers/net/txgbe/txgbe_rxtx.c:1469:
+ pkt_len = (uint16_t) (rte_le_to_cpu_16(rxd.qw1.hi.len) -
CHECK:BRACES: braces {} should be used on all arms of this statement
#706: FILE: drivers/net/txgbe/txgbe_rxtx.c:1491:
+ if (likely(pkt_flags & PKT_RX_RSS_HASH))
[...]
+ else if (pkt_flags & PKT_RX_FDIR) {
[...]
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#709: FILE: drivers/net/txgbe/txgbe_rxtx.c:1494:
+ rxm->hash.fdir.hash = rte_le_to_cpu_16(
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#712: FILE: drivers/net/txgbe/txgbe_rxtx.c:1497:
+ rxm->hash.fdir.id = rte_le_to_cpu_16(
WARNING:TYPO_SPELLING: 'situtation' may be misspelled - perhaps 'situation'?
#729: FILE: drivers/net/txgbe/txgbe_rxtx.c:1514:
+ * RDH register, which creates a "full" ring situtation from the
CHECK:SPACING: No space is necessary after a cast
#732: FILE: drivers/net/txgbe/txgbe_rxtx.c:1517:
+ nb_hold = (uint16_t) (nb_hold + rxq->nb_rx_hold);
CHECK:SPACING: No space is necessary after a cast
#736: FILE: drivers/net/txgbe/txgbe_rxtx.c:1521:
+ (unsigned) rxq->port_id, (unsigned) rxq->queue_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#736: FILE: drivers/net/txgbe/txgbe_rxtx.c:1521:
+ (unsigned) rxq->port_id, (unsigned) rxq->queue_id,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#736: FILE: drivers/net/txgbe/txgbe_rxtx.c:1521:
+ (unsigned) rxq->port_id, (unsigned) rxq->queue_id,
CHECK:SPACING: No space is necessary after a cast
#737: FILE: drivers/net/txgbe/txgbe_rxtx.c:1522:
+ (unsigned) rx_id, (unsigned) nb_hold,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#737: FILE: drivers/net/txgbe/txgbe_rxtx.c:1522:
+ (unsigned) rx_id, (unsigned) nb_hold,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#737: FILE: drivers/net/txgbe/txgbe_rxtx.c:1522:
+ (unsigned) rx_id, (unsigned) nb_hold,
CHECK:SPACING: No space is necessary after a cast
#738: FILE: drivers/net/txgbe/txgbe_rxtx.c:1523:
+ (unsigned) nb_rx);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#738: FILE: drivers/net/txgbe/txgbe_rxtx.c:1523:
+ (unsigned) nb_rx);
CHECK:SPACING: No space is necessary after a cast
#739: FILE: drivers/net/txgbe/txgbe_rxtx.c:1524:
+ rx_id = (uint16_t) ((rx_id == 0) ?
CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#763: FILE: drivers/net/txgbe/txgbe_rxtx.c:1548:
+txgbe_fill_cluster_head_buf(
CHECK:BRACES: braces {} should be used on all arms of this statement
#786: FILE: drivers/net/txgbe/txgbe_rxtx.c:1571:
+ if (likely(pkt_flags & PKT_RX_RSS_HASH))
[...]
+ else if (pkt_flags & PKT_RX_FDIR) {
[...]
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'rte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed'
#899: FILE: drivers/net/txgbe/txgbe_rxtx.c:1684:
+ rte_eth_devices[rxq->port_id].data->
+ rx_mbuf_alloc_failed++;
WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'rte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed'
#916: FILE: drivers/net/txgbe/txgbe_rxtx.c:1701:
+ rte_eth_devices[rxq->port_id].data->
+ rx_mbuf_alloc_failed++;
CHECK:BRACES: braces {} should be used on all arms of this statement
#944: FILE: drivers/net/txgbe/txgbe_rxtx.c:1729:
+ if (!bulk_alloc) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#956: FILE: drivers/net/txgbe/txgbe_rxtx.c:1741:
+ } else
CHECK:BRACES: braces {} should be used on all arms of this statement
#1027: FILE: drivers/net/txgbe/txgbe_rxtx.c:1812:
+ if (unlikely(rxm->data_len <= rxq->crc_len)) {
[...]
+ } else
[...]
CHECK:BRACES: Unbalanced braces around else statement
#1037: FILE: drivers/net/txgbe/txgbe_rxtx.c:1822:
+ } else
WARNING:TYPO_SPELLING: 'situtation' may be misspelled - perhaps 'situation'?
#1062: FILE: drivers/net/txgbe/txgbe_rxtx.c:1847:
+ * RDH register, which creates a "full" ring situtation from the
WARNING:TYPO_SPELLING: 'Regualr' may be misspelled - perhaps 'Regular'?
#1146: FILE: drivers/net/txgbe/txgbe_rxtx.c:2708:
+ PMD_INIT_LOG(DEBUG, "Using Regualr (non-vector, "
total: 0 errors, 23 warnings, 27 checks, 1190 lines checked
Warning in drivers/net/txgbe/txgbe_rxtx.c:
Using rte_smp_[r/w]mb
parent reply other threads:[~2020-10-06 9:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-28-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006094258.C85832BC7@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).