From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66565A04BB for ; Tue, 6 Oct 2020 11:43:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5CB602C6E; Tue, 6 Oct 2020 11:42:59 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id C85832BC7; Tue, 6 Oct 2020 11:42:58 +0200 (CEST) In-Reply-To: <20201005120910.189343-28-jiawenwu@trustnetic.com> References: <20201005120910.189343-28-jiawenwu@trustnetic.com> To: test-report@dpdk.org Cc: Jiawen Wu Message-Id: <20201006094258.C85832BC7@dpdk.org> Date: Tue, 6 Oct 2020 11:42:58 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw79644 [PATCH v2 27/56] net/txgbe: fill receive functions X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/79644 _coding style issues_ WARNING:IF_1: Consider removing the #if 1 and its #endif #214: FILE: drivers/net/txgbe/txgbe_rxtx.c:57: +#if 1 CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #373: FILE: drivers/net/txgbe/txgbe_rxtx.c:1158: + pkt_flags |= txgbe_rxd_pkt_info_to_pkt_flags( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #376: FILE: drivers/net/txgbe/txgbe_rxtx.c:1161: + mb->packet_type = txgbe_rxd_pkt_info_to_pkt_type( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #380: FILE: drivers/net/txgbe/txgbe_rxtx.c:1165: + mb->hash.rss = rte_le_to_cpu_32( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #383: FILE: drivers/net/txgbe/txgbe_rxtx.c:1168: + mb->hash.fdir.hash = rte_le_to_cpu_16( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #386: FILE: drivers/net/txgbe/txgbe_rxtx.c:1171: + mb->hash.fdir.id = rte_le_to_cpu_16( WARNING:BRACES: braces {} are not necessary for single statement blocks #392: FILE: drivers/net/txgbe/txgbe_rxtx.c:1177: + for (j = 0; j < LOOK_AHEAD; ++j) { + rxq->rx_stage[i + j] = rxep[j].mbuf; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #402: FILE: drivers/net/txgbe/txgbe_rxtx.c:1187: + for (i = 0; i < nb_rx; ++i) { + rxq->sw_ring[rxq->rx_tail + i].mbuf = NULL; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #431: FILE: drivers/net/txgbe/txgbe_rxtx.c:1216: + if (reset_mbuf) { + mb->port = rxq->port_id; + } CHECK:SPACING: No space is necessary after a cast #501: FILE: drivers/net/txgbe/txgbe_rxtx.c:1286: + "queue_id=%u", (unsigned) rxq->port_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #501: FILE: drivers/net/txgbe/txgbe_rxtx.c:1286: + "queue_id=%u", (unsigned) rxq->port_id, CHECK:SPACING: No space is necessary after a cast #502: FILE: drivers/net/txgbe/txgbe_rxtx.c:1287: + (unsigned) rxq->queue_id); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #502: FILE: drivers/net/txgbe/txgbe_rxtx.c:1287: + (unsigned) rxq->queue_id); CHECK:SPACING: No space is necessary after a cast #633: FILE: drivers/net/txgbe/txgbe_rxtx.c:1418: + (unsigned) rxq->port_id, (unsigned) rxq->queue_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #633: FILE: drivers/net/txgbe/txgbe_rxtx.c:1418: + (unsigned) rxq->port_id, (unsigned) rxq->queue_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #633: FILE: drivers/net/txgbe/txgbe_rxtx.c:1418: + (unsigned) rxq->port_id, (unsigned) rxq->queue_id, CHECK:SPACING: No space is necessary after a cast #634: FILE: drivers/net/txgbe/txgbe_rxtx.c:1419: + (unsigned) rx_id, (unsigned) staterr, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #634: FILE: drivers/net/txgbe/txgbe_rxtx.c:1419: + (unsigned) rx_id, (unsigned) staterr, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #634: FILE: drivers/net/txgbe/txgbe_rxtx.c:1419: + (unsigned) rx_id, (unsigned) staterr, CHECK:SPACING: No space is necessary after a cast #635: FILE: drivers/net/txgbe/txgbe_rxtx.c:1420: + (unsigned) rte_le_to_cpu_16(rxd.qw1.hi.len)); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #635: FILE: drivers/net/txgbe/txgbe_rxtx.c:1420: + (unsigned) rte_le_to_cpu_16(rxd.qw1.hi.len)); CHECK:SPACING: No space is necessary after a cast #640: FILE: drivers/net/txgbe/txgbe_rxtx.c:1425: + "queue_id=%u", (unsigned) rxq->port_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #640: FILE: drivers/net/txgbe/txgbe_rxtx.c:1425: + "queue_id=%u", (unsigned) rxq->port_id, CHECK:SPACING: No space is necessary after a cast #641: FILE: drivers/net/txgbe/txgbe_rxtx.c:1426: + (unsigned) rxq->queue_id); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #641: FILE: drivers/net/txgbe/txgbe_rxtx.c:1426: + (unsigned) rxq->queue_id); CHECK:SPACING: No space is necessary after a cast #684: FILE: drivers/net/txgbe/txgbe_rxtx.c:1469: + pkt_len = (uint16_t) (rte_le_to_cpu_16(rxd.qw1.hi.len) - CHECK:BRACES: braces {} should be used on all arms of this statement #706: FILE: drivers/net/txgbe/txgbe_rxtx.c:1491: + if (likely(pkt_flags & PKT_RX_RSS_HASH)) [...] + else if (pkt_flags & PKT_RX_FDIR) { [...] CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #709: FILE: drivers/net/txgbe/txgbe_rxtx.c:1494: + rxm->hash.fdir.hash = rte_le_to_cpu_16( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #712: FILE: drivers/net/txgbe/txgbe_rxtx.c:1497: + rxm->hash.fdir.id = rte_le_to_cpu_16( WARNING:TYPO_SPELLING: 'situtation' may be misspelled - perhaps 'situation'? #729: FILE: drivers/net/txgbe/txgbe_rxtx.c:1514: + * RDH register, which creates a "full" ring situtation from the CHECK:SPACING: No space is necessary after a cast #732: FILE: drivers/net/txgbe/txgbe_rxtx.c:1517: + nb_hold = (uint16_t) (nb_hold + rxq->nb_rx_hold); CHECK:SPACING: No space is necessary after a cast #736: FILE: drivers/net/txgbe/txgbe_rxtx.c:1521: + (unsigned) rxq->port_id, (unsigned) rxq->queue_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #736: FILE: drivers/net/txgbe/txgbe_rxtx.c:1521: + (unsigned) rxq->port_id, (unsigned) rxq->queue_id, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #736: FILE: drivers/net/txgbe/txgbe_rxtx.c:1521: + (unsigned) rxq->port_id, (unsigned) rxq->queue_id, CHECK:SPACING: No space is necessary after a cast #737: FILE: drivers/net/txgbe/txgbe_rxtx.c:1522: + (unsigned) rx_id, (unsigned) nb_hold, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #737: FILE: drivers/net/txgbe/txgbe_rxtx.c:1522: + (unsigned) rx_id, (unsigned) nb_hold, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #737: FILE: drivers/net/txgbe/txgbe_rxtx.c:1522: + (unsigned) rx_id, (unsigned) nb_hold, CHECK:SPACING: No space is necessary after a cast #738: FILE: drivers/net/txgbe/txgbe_rxtx.c:1523: + (unsigned) nb_rx); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #738: FILE: drivers/net/txgbe/txgbe_rxtx.c:1523: + (unsigned) nb_rx); CHECK:SPACING: No space is necessary after a cast #739: FILE: drivers/net/txgbe/txgbe_rxtx.c:1524: + rx_id = (uint16_t) ((rx_id == 0) ? CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #763: FILE: drivers/net/txgbe/txgbe_rxtx.c:1548: +txgbe_fill_cluster_head_buf( CHECK:BRACES: braces {} should be used on all arms of this statement #786: FILE: drivers/net/txgbe/txgbe_rxtx.c:1571: + if (likely(pkt_flags & PKT_RX_RSS_HASH)) [...] + else if (pkt_flags & PKT_RX_FDIR) { [...] WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'rte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed' #899: FILE: drivers/net/txgbe/txgbe_rxtx.c:1684: + rte_eth_devices[rxq->port_id].data-> + rx_mbuf_alloc_failed++; WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'rte_eth_devices[rxq->port_id].data->rx_mbuf_alloc_failed' #916: FILE: drivers/net/txgbe/txgbe_rxtx.c:1701: + rte_eth_devices[rxq->port_id].data-> + rx_mbuf_alloc_failed++; CHECK:BRACES: braces {} should be used on all arms of this statement #944: FILE: drivers/net/txgbe/txgbe_rxtx.c:1729: + if (!bulk_alloc) { [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #956: FILE: drivers/net/txgbe/txgbe_rxtx.c:1741: + } else CHECK:BRACES: braces {} should be used on all arms of this statement #1027: FILE: drivers/net/txgbe/txgbe_rxtx.c:1812: + if (unlikely(rxm->data_len <= rxq->crc_len)) { [...] + } else [...] CHECK:BRACES: Unbalanced braces around else statement #1037: FILE: drivers/net/txgbe/txgbe_rxtx.c:1822: + } else WARNING:TYPO_SPELLING: 'situtation' may be misspelled - perhaps 'situation'? #1062: FILE: drivers/net/txgbe/txgbe_rxtx.c:1847: + * RDH register, which creates a "full" ring situtation from the WARNING:TYPO_SPELLING: 'Regualr' may be misspelled - perhaps 'Regular'? #1146: FILE: drivers/net/txgbe/txgbe_rxtx.c:2708: + PMD_INIT_LOG(DEBUG, "Using Regualr (non-vector, " total: 0 errors, 23 warnings, 27 checks, 1190 lines checked Warning in drivers/net/txgbe/txgbe_rxtx.c: Using rte_smp_[r/w]mb