From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79646 [PATCH v2 28/56] net/txgbe: add device start operation
Date: Tue, 6 Oct 2020 11:43:07 +0200 (CEST) [thread overview]
Message-ID: <20201006094307.61B272C16@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-29-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79646
_coding style issues_
WARNING:BRACES: braces {} are not necessary for single statement blocks
#427: FILE: drivers/net/txgbe/base/txgbe_hw.c:1920:
+ if ((value & 0x3) != SR_PCS_CTRL2_TYPE_SEL_X) {
+ hw->link_status = TXGBE_LINK_STATUS_NONE;
+ }
WARNING:TYPO_SPELLING: 'transmiter' may be misspelled - perhaps 'transmitter'?
#473: FILE: drivers/net/txgbe/base/txgbe_hw.c:1966:
+ /* enable mac transmiter */
WARNING:BRACES: braces {} are not necessary for single statement blocks
#476: FILE: drivers/net/txgbe/base/txgbe_hw.c:1969:
+ for (i = 0; i < 4; i++) {
+ wr32m(hw, TXGBE_IVAR(i), 0x80808080, 0);
+ }
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_dev_start', this function's name, in a string
#831: FILE: drivers/net/txgbe/txgbe_ethdev.c:755:
+ PMD_INIT_LOG(ERR, "failure in txgbe_dev_start(): %d", err);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#880: FILE: drivers/net/txgbe/txgbe_rxtx.c:2484:
+ unsigned i;
total: 0 errors, 5 warnings, 0 checks, 863 lines checked
parent reply other threads:[~2020-10-06 9:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-29-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006094307.61B272C16@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).