From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 87207A04BB
	for <public@inbox.dpdk.org>; Tue,  6 Oct 2020 11:43:09 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 7F3BE2C6E;
	Tue,  6 Oct 2020 11:43:08 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 61B272C16; Tue,  6 Oct 2020 11:43:07 +0200 (CEST)
In-Reply-To: <20201005120910.189343-29-jiawenwu@trustnetic.com>
References: <20201005120910.189343-29-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20201006094307.61B272C16@dpdk.org>
Date: Tue,  6 Oct 2020 11:43:07 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw79646 [PATCH v2 28/56] net/txgbe:
	add device start operation
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79646

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#427: FILE: drivers/net/txgbe/base/txgbe_hw.c:1920:
+	if ((value & 0x3) != SR_PCS_CTRL2_TYPE_SEL_X) {
+		hw->link_status = TXGBE_LINK_STATUS_NONE;
+	}

WARNING:TYPO_SPELLING: 'transmiter' may be misspelled - perhaps 'transmitter'?
#473: FILE: drivers/net/txgbe/base/txgbe_hw.c:1966:
+	/* enable mac transmiter */

WARNING:BRACES: braces {} are not necessary for single statement blocks
#476: FILE: drivers/net/txgbe/base/txgbe_hw.c:1969:
+	for (i = 0; i < 4; i++) {
+		wr32m(hw, TXGBE_IVAR(i), 0x80808080, 0);
+	}

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_dev_start', this function's name, in a string
#831: FILE: drivers/net/txgbe/txgbe_ethdev.c:755:
+	PMD_INIT_LOG(ERR, "failure in txgbe_dev_start(): %d", err);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#880: FILE: drivers/net/txgbe/txgbe_rxtx.c:2484:
+	unsigned i;

total: 0 errors, 5 warnings, 0 checks, 863 lines checked