* [dpdk-test-report] |WARNING| pw79646 [PATCH v2 28/56] net/txgbe: add device start operation
[not found] <20201005120910.189343-29-jiawenwu@trustnetic.com>
@ 2020-10-06 9:43 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-10-06 9:43 UTC (permalink / raw)
To: test-report; +Cc: Jiawen Wu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79646
_coding style issues_
WARNING:BRACES: braces {} are not necessary for single statement blocks
#427: FILE: drivers/net/txgbe/base/txgbe_hw.c:1920:
+ if ((value & 0x3) != SR_PCS_CTRL2_TYPE_SEL_X) {
+ hw->link_status = TXGBE_LINK_STATUS_NONE;
+ }
WARNING:TYPO_SPELLING: 'transmiter' may be misspelled - perhaps 'transmitter'?
#473: FILE: drivers/net/txgbe/base/txgbe_hw.c:1966:
+ /* enable mac transmiter */
WARNING:BRACES: braces {} are not necessary for single statement blocks
#476: FILE: drivers/net/txgbe/base/txgbe_hw.c:1969:
+ for (i = 0; i < 4; i++) {
+ wr32m(hw, TXGBE_IVAR(i), 0x80808080, 0);
+ }
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'txgbe_dev_start', this function's name, in a string
#831: FILE: drivers/net/txgbe/txgbe_ethdev.c:755:
+ PMD_INIT_LOG(ERR, "failure in txgbe_dev_start(): %d", err);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#880: FILE: drivers/net/txgbe/txgbe_rxtx.c:2484:
+ unsigned i;
total: 0 errors, 5 warnings, 0 checks, 863 lines checked
^ permalink raw reply [flat|nested] only message in thread