From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2014FA04BB for ; Tue, 6 Oct 2020 11:43:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1A41B2C28; Tue, 6 Oct 2020 11:43:26 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 1017) id C52C629C6; Tue, 6 Oct 2020 11:43:24 +0200 (CEST) In-Reply-To: <20201005120910.189343-34-jiawenwu@trustnetic.com> References: <20201005120910.189343-34-jiawenwu@trustnetic.com> To: test-report@dpdk.org Cc: Jiawen Wu Message-Id: <20201006094324.C52C629C6@dpdk.org> Date: Tue, 6 Oct 2020 11:43:24 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw79652 [PATCH v2 33/56] net/txgbe: add device stats get X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Sender: "test-report" Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/79652 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last_counter' - possible side-effects? #320: FILE: drivers/net/txgbe/txgbe_ethdev.c:951: +#define UPDATE_QP_COUNTER_32bit(reg, last_counter, counter) \ + { \ + uint32_t current_counter = rd32(hw, reg); \ + if (current_counter < last_counter) \ + current_counter += 0x100000000LL; \ + if (!hw->offset_loaded) \ + last_counter = current_counter; \ + counter = current_counter - last_counter; \ + counter &= 0xFFFFFFFFLL; \ + } CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last_counter' may be better as '(last_counter)' to avoid precedence issues #320: FILE: drivers/net/txgbe/txgbe_ethdev.c:951: +#define UPDATE_QP_COUNTER_32bit(reg, last_counter, counter) \ + { \ + uint32_t current_counter = rd32(hw, reg); \ + if (current_counter < last_counter) \ + current_counter += 0x100000000LL; \ + if (!hw->offset_loaded) \ + last_counter = current_counter; \ + counter = current_counter - last_counter; \ + counter &= 0xFFFFFFFFLL; \ + } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'counter' - possible side-effects? #320: FILE: drivers/net/txgbe/txgbe_ethdev.c:951: +#define UPDATE_QP_COUNTER_32bit(reg, last_counter, counter) \ + { \ + uint32_t current_counter = rd32(hw, reg); \ + if (current_counter < last_counter) \ + current_counter += 0x100000000LL; \ + if (!hw->offset_loaded) \ + last_counter = current_counter; \ + counter = current_counter - last_counter; \ + counter &= 0xFFFFFFFFLL; \ + } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'last_counter' - possible side-effects? #331: FILE: drivers/net/txgbe/txgbe_ethdev.c:962: +#define UPDATE_QP_COUNTER_36bit(reg_lsb, reg_msb, last_counter, counter) \ + { \ + uint64_t current_counter_lsb = rd32(hw, reg_lsb); \ + uint64_t current_counter_msb = rd32(hw, reg_msb); \ + uint64_t current_counter = (current_counter_msb << 32) | \ + current_counter_lsb; \ + if (current_counter < last_counter) \ + current_counter += 0x1000000000LL; \ + if (!hw->offset_loaded) \ + last_counter = current_counter; \ + counter = current_counter - last_counter; \ + counter &= 0xFFFFFFFFFLL; \ + } CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'last_counter' may be better as '(last_counter)' to avoid precedence issues #331: FILE: drivers/net/txgbe/txgbe_ethdev.c:962: +#define UPDATE_QP_COUNTER_36bit(reg_lsb, reg_msb, last_counter, counter) \ + { \ + uint64_t current_counter_lsb = rd32(hw, reg_lsb); \ + uint64_t current_counter_msb = rd32(hw, reg_msb); \ + uint64_t current_counter = (current_counter_msb << 32) | \ + current_counter_lsb; \ + if (current_counter < last_counter) \ + current_counter += 0x1000000000LL; \ + if (!hw->offset_loaded) \ + last_counter = current_counter; \ + counter = current_counter - last_counter; \ + counter &= 0xFFFFFFFFFLL; \ + } CHECK:MACRO_ARG_REUSE: Macro argument reuse 'counter' - possible side-effects? #331: FILE: drivers/net/txgbe/txgbe_ethdev.c:962: +#define UPDATE_QP_COUNTER_36bit(reg_lsb, reg_msb, last_counter, counter) \ + { \ + uint64_t current_counter_lsb = rd32(hw, reg_lsb); \ + uint64_t current_counter_msb = rd32(hw, reg_msb); \ + uint64_t current_counter = (current_counter_msb << 32) | \ + current_counter_lsb; \ + if (current_counter < last_counter) \ + current_counter += 0x1000000000LL; \ + if (!hw->offset_loaded) \ + last_counter = current_counter; \ + counter = current_counter - last_counter; \ + counter &= 0xFFFFFFFFFLL; \ + } WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #349: FILE: drivers/net/txgbe/txgbe_ethdev.c:980: + unsigned i; CHECK:CAMELCASE: Avoid CamelCase: #417: FILE: drivers/net/txgbe/txgbe_ethdev.c:1048: + hw_stats->rx_size_1024_to_max_packets += rd64(hw, TXGBE_MACRX1024toMAXL); CHECK:CAMELCASE: Avoid CamelCase: #423: FILE: drivers/net/txgbe/txgbe_ethdev.c:1054: + hw_stats->tx_size_1024_to_max_packets += rd64(hw, TXGBE_MACTX1024toMAXL); total: 0 errors, 1 warnings, 8 checks, 536 lines checked