From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79654 [PATCH v2 37/56] net/txgbe: add SWFW semaphore and lock
Date: Tue, 6 Oct 2020 11:43:30 +0200 (CEST) [thread overview]
Message-ID: <20201006094330.1E42149E0@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-38-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79654
_coding style issues_
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#137: FILE: drivers/net/txgbe/base/txgbe_hw.c:708:
+ return 0;
+ } else {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'alt_san_mac_blk_offset == 0'
#210: FILE: drivers/net/txgbe/base/txgbe_hw.c:1152:
+ if ((alt_san_mac_blk_offset == 0) ||
+ (alt_san_mac_blk_offset == 0xFFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'alt_san_mac_blk_offset == 0xFFFF'
#210: FILE: drivers/net/txgbe/base/txgbe_hw.c:1152:
+ if ((alt_san_mac_blk_offset == 0) ||
+ (alt_san_mac_blk_offset == 0xFFFF))
WARNING:BRACES: braces {} are not necessary for single statement blocks
#223: FILE: drivers/net/txgbe/base/txgbe_hw.c:1165:
+ if (hw->rom.read16(hw, offset, wwnn_prefix)) {
+ DEBUGOUT("eeprom read at offset %d failed", offset);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#315: FILE: drivers/net/txgbe/txgbe_ethdev.c:355:
+ if (hw->mac.acquire_swfw_sync(hw, mask) < 0) {
+ PMD_DRV_LOG(DEBUG, "SWFW common locks released");
+ }
total: 0 errors, 3 warnings, 2 checks, 253 lines checked
parent reply other threads:[~2020-10-06 9:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-38-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006094330.1E42149E0@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).