From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 68A79A04BB
	for <public@inbox.dpdk.org>; Tue,  6 Oct 2020 11:43:32 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 5F56C2952;
	Tue,  6 Oct 2020 11:43:31 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 1017)
 id 1E42149E0; Tue,  6 Oct 2020 11:43:30 +0200 (CEST)
In-Reply-To: <20201005120910.189343-38-jiawenwu@trustnetic.com>
References: <20201005120910.189343-38-jiawenwu@trustnetic.com>
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Message-Id: <20201006094330.1E42149E0@dpdk.org>
Date: Tue,  6 Oct 2020 11:43:30 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw79654 [PATCH v2 37/56] net/txgbe:
	add SWFW semaphore and lock
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org
Sender: "test-report" <test-report-bounces@dpdk.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79654

_coding style issues_


WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#137: FILE: drivers/net/txgbe/base/txgbe_hw.c:708:
+			return 0;
+		} else {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'alt_san_mac_blk_offset == 0'
#210: FILE: drivers/net/txgbe/base/txgbe_hw.c:1152:
+	if ((alt_san_mac_blk_offset == 0) ||
+	    (alt_san_mac_blk_offset == 0xFFFF))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'alt_san_mac_blk_offset == 0xFFFF'
#210: FILE: drivers/net/txgbe/base/txgbe_hw.c:1152:
+	if ((alt_san_mac_blk_offset == 0) ||
+	    (alt_san_mac_blk_offset == 0xFFFF))

WARNING:BRACES: braces {} are not necessary for single statement blocks
#223: FILE: drivers/net/txgbe/base/txgbe_hw.c:1165:
+	if (hw->rom.read16(hw, offset, wwnn_prefix)) {
+		DEBUGOUT("eeprom read at offset %d failed", offset);
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#315: FILE: drivers/net/txgbe/txgbe_ethdev.c:355:
+	if (hw->mac.acquire_swfw_sync(hw, mask) < 0) {
+		PMD_DRV_LOG(DEBUG, "SWFW common locks released");
+	}

total: 0 errors, 3 warnings, 2 checks, 253 lines checked