* [dpdk-test-report] |WARNING| pw79654 [PATCH v2 37/56] net/txgbe: add SWFW semaphore and lock
[not found] <20201005120910.189343-38-jiawenwu@trustnetic.com>
@ 2020-10-06 9:43 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2020-10-06 9:43 UTC (permalink / raw)
To: test-report; +Cc: Jiawen Wu
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79654
_coding style issues_
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#137: FILE: drivers/net/txgbe/base/txgbe_hw.c:708:
+ return 0;
+ } else {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'alt_san_mac_blk_offset == 0'
#210: FILE: drivers/net/txgbe/base/txgbe_hw.c:1152:
+ if ((alt_san_mac_blk_offset == 0) ||
+ (alt_san_mac_blk_offset == 0xFFFF))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'alt_san_mac_blk_offset == 0xFFFF'
#210: FILE: drivers/net/txgbe/base/txgbe_hw.c:1152:
+ if ((alt_san_mac_blk_offset == 0) ||
+ (alt_san_mac_blk_offset == 0xFFFF))
WARNING:BRACES: braces {} are not necessary for single statement blocks
#223: FILE: drivers/net/txgbe/base/txgbe_hw.c:1165:
+ if (hw->rom.read16(hw, offset, wwnn_prefix)) {
+ DEBUGOUT("eeprom read at offset %d failed", offset);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#315: FILE: drivers/net/txgbe/txgbe_ethdev.c:355:
+ if (hw->mac.acquire_swfw_sync(hw, mask) < 0) {
+ PMD_DRV_LOG(DEBUG, "SWFW common locks released");
+ }
total: 0 errors, 3 warnings, 2 checks, 253 lines checked
^ permalink raw reply [flat|nested] only message in thread