From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jiawen Wu <jiawenwu@trustnetic.com>
Subject: [dpdk-test-report] |WARNING| pw79655 [PATCH v2 36/56] net/txgbe: add VLAN handle support
Date: Tue, 6 Oct 2020 11:43:33 +0200 (CEST) [thread overview]
Message-ID: <20201006094333.E92221C01@dpdk.org> (raw)
In-Reply-To: <20201005120910.189343-37-jiawenwu@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/79655
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#212: FILE: drivers/net/txgbe/txgbe_ethdev.c:45:
+#define TXGBE_SET_HWSTRIP(h, q) do {\
+ uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+ uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+ (h)->bitmap[idx] |= 1 << bit;\
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#218: FILE: drivers/net/txgbe/txgbe_ethdev.c:51:
+#define TXGBE_CLEAR_HWSTRIP(h, q) do {\
+ uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+ uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+ (h)->bitmap[idx] &= ~(1 << bit);\
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#224: FILE: drivers/net/txgbe/txgbe_ethdev.c:57:
+#define TXGBE_GET_HWSTRIP(h, q, r) do {\
+ uint32_t idx = (q) / (sizeof((h)->bitmap[0]) * NBBY); \
+ uint32_t bit = (q) % (sizeof((h)->bitmap[0]) * NBBY); \
+ (r) = (h)->bitmap[idx] >> bit & 1;\
+ } while (0)
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#522: FILE: drivers/net/txgbe/txgbe_ethdev.c:844:
+ if (rxq->offloads & DEV_RX_OFFLOAD_VLAN_STRIP) {
[...]
+ } else {
[...]
WARNING:BRACES: braces {} are not necessary for single statement blocks
#558: FILE: drivers/net/txgbe/txgbe_ethdev.c:880:
+ if (mask & ETH_VLAN_STRIP_MASK) {
+ txgbe_vlan_hw_strip_config(dev);
+ }
total: 0 errors, 2 warnings, 3 checks, 572 lines checked
parent reply other threads:[~2020-10-06 9:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20201005120910.189343-37-jiawenwu@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006094333.E92221C01@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiawenwu@trustnetic.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).